perf: Add special case to Table.add_rows to increase performance#608
Merged
lars-reimann merged 5 commits intomainfrom Apr 5, 2024
Merged
perf: Add special case to Table.add_rows to increase performance#608lars-reimann merged 5 commits intomainfrom
Table.add_rows to increase performance#608lars-reimann merged 5 commits intomainfrom
Conversation
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
…olumns => 0 rows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 53
Lines 3208 3212 +4
=========================================
+ Hits 3208 3212 +4 ☔ View full report in Codecov by Sentry. |
WinPlay02
reviewed
Apr 3, 2024
WinPlay02
approved these changes
Apr 3, 2024
Contributor
WinPlay02
left a comment
There was a problem hiding this comment.
Consider the suggestion, otherwise I agree. I'll close my second PR then.
I guess checking the schema will ensure correctness and will prevent surprising the user, that sometimes an add_rows operation works, and sometimes it doesn't
Co-authored-by: WinPlay02 <winplay02_gh@woberlaender.de>
lars-reimann
approved these changes
Apr 5, 2024
lars-reimann
pushed a commit
that referenced
this pull request
Apr 17, 2024
## [0.21.0](v0.20.0...v0.21.0) (2024-04-17) ### Features * add ARIMA model ([#577](#577)) ([8b9c7a9](8b9c7a9)), closes [#570](#570) * Add ImageList class ([#534](#534)) ([3cb74a2](3cb74a2)), closes [#528](#528) [#599](#599) [#600](#600) * more hash, sizeof and eq implementations ([#609](#609)) ([2bc0b0a](2bc0b0a)) ### Performance Improvements * Add special case to `Table.add_rows` to increase performance ([#608](#608)) ([ffb8304](ffb8304)), closes [#606](#606) * improve performance of model & forward layer ([#616](#616)) ([e856cd5](e856cd5)), closes [#610](#610) * lazily import our modules and external libraries ([#624](#624)) ([20fc313](20fc313)) * treat Tables specially when calling add_rows ([#606](#606)) ([e555b85](e555b85)), closes [#575](#575)
Member
|
🎉 This PR is included in version 0.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #606
Summary of Changes
perf: Add special case to
Table.add_rowsto increase performance