feat: memoization improvements by WinPlay02 · Pull Request #81 · Safe-DS/Runner

WinPlay02 · 2024-04-08T22:56:21Z

Summary of Changes

shared memory
lazy comparisons
limited memory
value removal strategies
use deterministic seed for hashing

Closes #44

… value removal strategies

github-actions · 2024-04-08T22:57:47Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	7	0	0	0.69s
✅ PYTHON	mypy	7		0	2.57s
✅ PYTHON	ruff	7	0	0	0.03s
✅ REPOSITORY	git_diff	yes		no	0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

WinPlay02

This is still a draft, as there are some open questions

src/safeds_runner/server/_memoization_map.py

…tion-improvements

…dule

…nction, as talked about in the PR

codecov · 2024-04-10T10:03:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6f820bf) to head (c7f8cb9).

Additional details and impacted files

@@            Coverage Diff             @@
##              main       #81    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        14     +3     
  Lines          530       721   +191     
==========================================
+ Hits           530       721   +191

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…tion-improvements

fix: apply wrapping / unwrapping recursively fix: comparison of ExplicitIdentityWrapper against other ExplicitIdentityWrapper with different identity, but same value test: memoization utils

…emoization-improvements # Conflicts: # src/safeds_runner/server/_memoization_strategies.py

…tion-improvements

lars-reimann · 2024-04-13T08:11:16Z

@WinPlay02 Is this ready for review or are you still working on it?

lars-reimann · 2024-04-13T09:14:36Z

Some quick testing shows some major performance improvements compared to main.

After clicking on "Explore Table", there's always still roughly a 3s delay between the program message and the first placeholder_type, but afterward the table view and profiling appear much faster.

That initial delay might be related to the startup delay we observed for the library, since each worker process has to load the library?

WinPlay02 · 2024-04-13T10:35:13Z

Some quick testing shows some major performance improvements compared to main.

After clicking on "Explore Table", there's always still roughly a 3s delay between the program message and the first placeholder_type, but afterward the table view and profiling appear much faster.

That initial delay might be related to the startup delay we observed for the library, since each worker process has to load the library?

Yes, that should be the Startup delay. That's now the hardest problem to solve.

WinPlay02 · 2024-04-13T10:47:42Z

@WinPlay02 Is this ready for review or are you still working on it?

It was still in draft, as the strategies now use functions instead of lambdas (passing to the pipeline process lead to a PickleError), which arguably is not as clean, but I don't know a better solution for now.

I also tried to use a process pool, as discussed on Thursday, but I didn't find a satisfying solution on how it should be handled, if the max. amount of processes has been reached. (Waiting in a queue, vs sending an Error)

Using any pool (library) doesn't map to this pipeline based usage model very well, as they are made with parallelism or concurrency in mind.

Apart from these two things, it should be reviewable

src/safeds_runner/server/_memoization_strategies.py

src/safeds_runner/server/_memoization_utils.py

lars-reimann

Really nice, great work!

## [0.11.0](v0.10.0...v0.11.0) (2024-04-17) ### Features * bump `safe-ds` to `v0.21.0` ([#86](#86)) ([d780822](d780822)), closes [#85](#85) * memoization improvements ([#81](#81)) ([6bc2288](6bc2288)), closes [#44](#44)

lars-reimann · 2024-04-17T15:21:57Z

🎉 This PR is included in version 0.11.0 🎉

The release is available on:

v0.11.0
GitHub release

Your semantic-release bot 📦🚀

feat: memoization shared memory + lazy comparisons + limited memory +…

c2675b5

… value removal strategies

WinPlay02 commented Apr 8, 2024

View reviewed changes

src/safeds_runner/server/_memoization_map.py Outdated Show resolved Hide resolved

src/safeds_runner/server/_memoization_map.py Outdated Show resolved Hide resolved

src/safeds_runner/server/_memoization_map.py Outdated Show resolved Hide resolved

WinPlay02 added 8 commits April 9, 2024 01:18

fix: wrong hints

8413469

Merge branch 'main' of https://github.com/Safe-DS/Runner into memoiza…

2e67c9b

…tion-improvements

feat: use deterministic hash seed for runner (and subprocesses)

bde713a

refactor: move functions around, to split up huge _memoization_map mo…

b022b60

…dule

style: linter fixes

2fc3997

docs: explain fixed value

8e42bbd

feat: no longer use whitelist, instead rely on overridden __hash__ fu…

1d0e302

…nction, as talked about in the PR

fix: use correct memory size

bbe6ce5

WinPlay02 and others added 14 commits April 10, 2024 12:09

style: linter fixes

0e1b8de

style: apply automated linter fixes

07be946

Merge branch 'main' of https://github.com/Safe-DS/Runner into memoiza…

2e8c22a

…tion-improvements

test: memoization map + strategies

720bb11

feat: support wrap / unwrap of more collection types

e17c51e

fix: apply wrapping / unwrapping recursively fix: comparison of ExplicitIdentityWrapper against other ExplicitIdentityWrapper with different identity, but same value test: memoization utils

feat: limit available memory to half of physical available memory

be1cf37

Merge remote-tracking branch 'origin/memoization-improvements' into m…

fa714b4

…emoization-improvements # Conflicts: # src/safeds_runner/server/_memoization_strategies.py

Merge branch 'main' of https://github.com/Safe-DS/Runner into memoiza…

427912e

…tion-improvements

style: linter fixes

63cc233

style: linter fixes (split raises test into two branches)

7146085

style: apply automated linter fixes

702154a

style: linter fixes

ffb0c38

style: apply automated linter fixes

b5f0961

style: linter ignores (enough fighting against the linter)

3cd3792

WinPlay02 marked this pull request as ready for review April 13, 2024 10:47

WinPlay02 requested a review from a team as a code owner April 13, 2024 10:47

lars-reimann requested changes Apr 16, 2024

View reviewed changes

src/safeds_runner/server/_memoization_strategies.py Outdated Show resolved Hide resolved

src/safeds_runner/server/_memoization_strategies.py Outdated Show resolved Hide resolved

src/safeds_runner/server/_memoization_utils.py Outdated Show resolved Hide resolved

WinPlay02 and others added 5 commits April 16, 2024 20:12

refactor: make interface of ExplicitIdentityWrapperLazy easier

0071545

refactor: make interface of memoization strategies more explicit

7c1b3b8

refactor: rename lru_inverse to mru

5024fb2

docs: describe memoization value removal strategies

91f847e

style: apply automated linter fixes

c7f8cb9

WinPlay02 requested a review from lars-reimann April 16, 2024 18:30

lars-reimann approved these changes Apr 16, 2024

View reviewed changes

lars-reimann merged commit 6bc2288 into main Apr 16, 2024

lars-reimann deleted the memoization-improvements branch April 16, 2024 19:32

lars-reimann added the released Included in a release label Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: memoization improvements#81

feat: memoization improvements#81
lars-reimann merged 28 commits intomainfrom
memoization-improvements

WinPlay02 commented Apr 8, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Apr 8, 2024 •

edited

Loading

Uh oh!

WinPlay02 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 10, 2024 •

edited

Loading

Uh oh!

lars-reimann commented Apr 13, 2024

Uh oh!

lars-reimann commented Apr 13, 2024

Uh oh!

WinPlay02 commented Apr 13, 2024

Uh oh!

WinPlay02 commented Apr 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lars-reimann left a comment

Uh oh!

lars-reimann commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

WinPlay02 commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Uh oh!

github-actions bot commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦙 MegaLinter status: ✅ SUCCESS

Uh oh!

WinPlay02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lars-reimann commented Apr 13, 2024

Uh oh!

lars-reimann commented Apr 13, 2024

Uh oh!

WinPlay02 commented Apr 13, 2024

Uh oh!

WinPlay02 commented Apr 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lars-reimann left a comment

Choose a reason for hiding this comment

Uh oh!

lars-reimann commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WinPlay02 commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024 •

edited

Loading

codecov bot commented Apr 10, 2024 •

edited

Loading