Skip to content

feat: move ImputerStrategy to safeds.data.tabular.typing#174

Merged
lars-reimann merged 4 commits intomainfrom
imputer_strategy
Apr 4, 2023
Merged

feat: move ImputerStrategy to safeds.data.tabular.typing#174
lars-reimann merged 4 commits intomainfrom
imputer_strategy

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann commented Apr 4, 2023

Summary of Changes

  • Move the abstract base class ImputerStrategy to safeds.data.tabular.typing since it is only needed for type annotations
  • Improve documentation

@lars-reimann lars-reimann requested a review from a team as a code owner April 4, 2023 16:51
@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Apr 4, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 5 0 0 0.73s
✅ PYTHON mypy 5 0 2.23s
✅ PYTHON ruff 5 0 0 0.04s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2023

Codecov Report

Merging #174 (6bd0e19) into main (526b96e) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   93.87%   93.88%   +0.01%     
==========================================
  Files          40       41       +1     
  Lines        1453     1456       +3     
==========================================
+ Hits         1364     1367       +3     
  Misses         89       89              
Impacted Files Coverage Δ
...rc/safeds/data/tabular/typing/_imputer_strategy.py 83.33% <83.33%> (ø)
src/safeds/data/tabular/transformation/__init__.py 100.00% <100.00%> (ø)
src/safeds/data/tabular/transformation/_imputer.py 94.02% <100.00%> (+1.07%) ⬆️
src/safeds/data/tabular/typing/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann merged commit 205c8e2 into main Apr 4, 2023
@lars-reimann lars-reimann deleted the imputer_strategy branch April 4, 2023 17:04
lars-reimann pushed a commit that referenced this pull request Apr 4, 2023
## [0.9.0](v0.8.0...v0.9.0) (2023-04-04)

### Features

* container for images ([#159](#159)) ([ed7ae34](ed7ae34)), closes [#158](#158)
* improve error handling for `predict` ([#145](#145)) ([a5ff11c](a5ff11c)), closes [#9](#9)
* move `ImputerStrategy` to `safeds.data.tabular.typing` ([#174](#174)) ([205c8e2](205c8e2))
* rename `n_neighbors` to `number_of_neighbors` ([#162](#162)) ([526b96e](526b96e))

### Bug Fixes

* export `TableTransformer` and `InvertibleTableTransformer` ([#135](#135)) ([81c3695](81c3695))
@lars-reimann
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants