Skip to content

feat: rename n_neighbors to number_of_neighbors#162

Merged
lars-reimann merged 1 commit intomainfrom
number_of_neighbors
Apr 4, 2023
Merged

feat: rename n_neighbors to number_of_neighbors#162
lars-reimann merged 1 commit intomainfrom
number_of_neighbors

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann commented Apr 4, 2023

Summary of Changes

Rename the n_neighbors parameter of KNearestNeighbors to number_of_neighbors for the sake of consistency.

@lars-reimann lars-reimann requested a review from a team as a code owner April 4, 2023 14:45
@lars-reimann
Copy link
Copy Markdown
Member Author

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.66s
✅ PYTHON mypy 2 0 1.9s
✅ PYTHON ruff 2 0 0 0.05s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann merged commit 526b96e into main Apr 4, 2023
@lars-reimann lars-reimann deleted the number_of_neighbors branch April 4, 2023 14:48
lars-reimann pushed a commit that referenced this pull request Apr 4, 2023
## [0.9.0](v0.8.0...v0.9.0) (2023-04-04)

### Features

* container for images ([#159](#159)) ([ed7ae34](ed7ae34)), closes [#158](#158)
* improve error handling for `predict` ([#145](#145)) ([a5ff11c](a5ff11c)), closes [#9](#9)
* move `ImputerStrategy` to `safeds.data.tabular.typing` ([#174](#174)) ([205c8e2](205c8e2))
* rename `n_neighbors` to `number_of_neighbors` ([#162](#162)) ([526b96e](526b96e))

### Bug Fixes

* export `TableTransformer` and `InvertibleTableTransformer` ([#135](#135)) ([81c3695](81c3695))
@lars-reimann
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant