Skip to content

feat: improve error handling for predict#145

Merged
lars-reimann merged 2 commits intomainfrom
9-better-error-message-when-predict-is-called-with-a-table-that-already-contains-the-target
Apr 2, 2023
Merged

feat: improve error handling for predict#145
lars-reimann merged 2 commits intomainfrom
9-better-error-message-when-predict-is-called-with-a-table-that-already-contains-the-target

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann commented Apr 2, 2023

Closes #9.

Summary of Changes

  • Use appropriate exception types.
  • Improve messages of raised exception.
  • Improve documentation.

@lars-reimann lars-reimann requested a review from a team as a code owner April 2, 2023 12:46
@lars-reimann lars-reimann linked an issue Apr 2, 2023 that may be closed by this pull request
Better error message when predict() is called with a Table that already contains the target #9
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2023 •
edited
Loading

Codecov Report

Merging #145 (724c37b) into main (a311727) will increase coverage by 0.17%.
The diff coverage is 94.11%.

❗ Current head 724c37b differs from pull request most recent head 96a43ad. Consider uploading reports for the commit 96a43ad to get more accurate results

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   93.32%   93.50%   +0.17%     
==========================================
  Files          36       36              
  Lines        1364     1370       +6     
==========================================
+ Hits         1273     1281       +8     
+ Misses         91       89       -2
Impacted Files Coverage Δ
src/safeds/ml/classification/_ada_boost.py 95.83% <ø> (ø)
src/safeds/ml/classification/_classifier.py 94.11% <ø> (ø)
src/safeds/ml/classification/_decision_tree.py 95.83% <ø> (ø)
...lassification/_gradient_boosting_classification.py 95.83% <ø> (ø)
...c/safeds/ml/classification/_k_nearest_neighbors.py 96.00% <ø> (ø)
...c/safeds/ml/classification/_logistic_regression.py 95.83% <ø> (ø)
src/safeds/ml/classification/_random_forest.py 95.83% <ø> (ø)
src/safeds/ml/regression/_ada_boost.py 95.83% <ø> (ø)
src/safeds/ml/regression/_decision_tree.py 95.83% <ø> (ø)
...rc/safeds/ml/regression/_elastic_net_regression.py 95.83% <ø> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Apr 2, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 30 0 0 1.12s
✅ PYTHON mypy 30 0 2.21s
✅ PYTHON ruff 30 0 0 0.06s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann merged commit a5ff11c into main Apr 2, 2023
@lars-reimann lars-reimann deleted the 9-better-error-message-when-predict-is-called-with-a-table-that-already-contains-the-target branch April 2, 2023 12:56
lars-reimann pushed a commit that referenced this pull request Apr 4, 2023
@semantic-release-bot
chore(release): 0.9.0 [skip ci]
4f84e6f 
## [0.9.0](v0.8.0...v0.9.0) (2023-04-04)

### Features

* container for images ([#159](#159)) ([ed7ae34](ed7ae34)), closes [#158](#158)
* improve error handling for `predict` ([#145](#145)) ([a5ff11c](a5ff11c)), closes [#9](#9)
* move `ImputerStrategy` to `safeds.data.tabular.typing` ([#174](#174)) ([205c8e2](205c8e2))
* rename `n_neighbors` to `number_of_neighbors` ([#162](#162)) ([526b96e](526b96e))

### Bug Fixes

* export `TableTransformer` and `InvertibleTableTransformer` ([#135](#135)) ([81c3695](81c3695))
@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Apr 4, 2023

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released Included in a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better error message when predict() is called with a Table that already contains the target

1 participant

@lars-reimann