Skip to content

feat: improve ColumnTypes#132

Merged
lars-reimann merged 8 commits intomainfrom
113-subclasses-of-columntype
Mar 31, 2023
Merged

feat: improve ColumnTypes#132
lars-reimann merged 8 commits intomainfrom
113-subclasses-of-columntype

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann commented Mar 31, 2023

Closes #113.

Summary of Changes

  • Rename subclasses:
    old new
    IntColumnType Integer
    BooleanColumnType Boolean
    FloatColumnType RealNumber
    StringColumnType String
  • Add new subclass Anything for columns that contain any values
  • Add parameter is_nullable to all types to indicate that null values are allowed
  • Add tests

@lars-reimann lars-reimann requested a review from a team as a code owner March 31, 2023 12:55
@lars-reimann lars-reimann linked an issue Mar 31, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Mar 31, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 21 0 0 0.88s
✅ PYTHON flake8 21 0 0.53s
✅ PYTHON isort 21 0 0 0.26s
✅ PYTHON mypy 21 0 2.02s
✅ PYTHON pylint 21 0 2.87s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2023

Codecov Report

Merging #132 (4c85717) into main (e8cf7a6) will increase coverage by 0.72%.
The diff coverage is 100.00%.

❗ Current head 4c85717 differs from pull request most recent head c42e259. Consider uploading reports for the commit c42e259 to get more accurate results

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   93.44%   94.16%   +0.72%     
==========================================
  Files          36       36              
  Lines        1296     1336      +40     
==========================================
+ Hits         1211     1258      +47     
+ Misses         85       78       -7     
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_column.py 90.14% <ø> (ø)
src/safeds/data/tabular/typing/__init__.py 100.00% <ø> (ø)
src/safeds/data/tabular/typing/_column_type.py 100.00% <100.00%> (+14.00%) ⬆️
src/safeds/data/tabular/typing/_table_schema.py 92.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann merged commit 1786a87 into main Mar 31, 2023
@lars-reimann lars-reimann deleted the 113-subclasses-of-columntype branch March 31, 2023 13:03
lars-reimann pushed a commit that referenced this pull request Mar 31, 2023
## [0.8.0](v0.7.0...v0.8.0) (2023-03-31)

### Features

* create empty `Table` without schema ([#128](#128)) ([ddd3f59](ddd3f59)), closes [#127](#127)
* improve `ColumnType`s ([#132](#132)) ([1786a87](1786a87)), closes [#113](#113)
* infer schema of row if not passed explicitly ([#134](#134)) ([c5869bb](c5869bb)), closes [#15](#15)
* new method `is_fitted` to check whether a model is fitted ([#130](#130)) ([8e1c3ea](8e1c3ea))
* new method `is_fitted` to check whether a transformer is fitted ([#131](#131)) ([e20954f](e20954f))
* rename `drop_XY` methods of `Table` to `remove_XY` ([#122](#122)) ([98d76a4](98d76a4))
* rename `fit_transform` to `fit_and_transform` ([#119](#119)) ([76a7112](76a7112)), closes [#112](#112)
* rename `shuffle` to `shuffle_rows` ([#125](#125)) ([ea21928](ea21928))
* rename `slice` to `slice_rows` ([#126](#126)) ([20d21c2](20d21c2))
* rename `TableSchema` to `Schema` ([#133](#133)) ([1419d25](1419d25))
@lars-reimann
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subclasses of ColumnType

1 participant