Skip to content

feat: rename drop_XY methods of Table to remove_XY#122

Merged
lars-reimann merged 3 commits intomainfrom
rename_drop_methods
Mar 30, 2023
Merged

feat: rename drop_XY methods of Table to remove_XY#122
lars-reimann merged 3 commits intomainfrom
rename_drop_methods

Conversation

@lars-reimann
Copy link
Copy Markdown
Member

Summary of Changes

Rename the drop_XY methods of Table to remove_XY. When users want to get rid of columns, they will probably look for "remove", particularly, since the names of methods to include new columns and rows start with "add".

@lars-reimann lars-reimann marked this pull request as ready for review March 30, 2023 15:28
@lars-reimann lars-reimann requested a review from a team as a code owner March 30, 2023 15:28
@lars-reimann lars-reimann changed the title feat: rename drop_XY method to remove_XY feat: rename drop_XY methods of Table to remove_XY Mar 30, 2023
@lars-reimann
Copy link
Copy Markdown
Member Author

lars-reimann commented Mar 30, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 22 0 0 1.12s
✅ PYTHON flake8 22 0 0.7s
✅ PYTHON isort 22 0 0 0.25s
✅ PYTHON mypy 22 0 2.14s
✅ PYTHON pylint 22 0 3.8s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2023

Codecov Report

Merging #122 (79bd0b7) into main (76a7112) will not change coverage.
The diff coverage is 96.15%.

❗ Current head 79bd0b7 differs from pull request most recent head 989740e. Consider uploading reports for the commit 989740e to get more accurate results

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files          36       36           
  Lines        1258     1258           
=======================================
  Hits         1171     1171           
  Misses         87       87           
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_table.py 91.13% <96.15%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann merged commit 98d76a4 into main Mar 30, 2023
@lars-reimann lars-reimann deleted the rename_drop_methods branch March 30, 2023 15:35
lars-reimann pushed a commit that referenced this pull request Mar 31, 2023
## [0.8.0](v0.7.0...v0.8.0) (2023-03-31)

### Features

* create empty `Table` without schema ([#128](#128)) ([ddd3f59](ddd3f59)), closes [#127](#127)
* improve `ColumnType`s ([#132](#132)) ([1786a87](1786a87)), closes [#113](#113)
* infer schema of row if not passed explicitly ([#134](#134)) ([c5869bb](c5869bb)), closes [#15](#15)
* new method `is_fitted` to check whether a model is fitted ([#130](#130)) ([8e1c3ea](8e1c3ea))
* new method `is_fitted` to check whether a transformer is fitted ([#131](#131)) ([e20954f](e20954f))
* rename `drop_XY` methods of `Table` to `remove_XY` ([#122](#122)) ([98d76a4](98d76a4))
* rename `fit_transform` to `fit_and_transform` ([#119](#119)) ([76a7112](76a7112)), closes [#112](#112)
* rename `shuffle` to `shuffle_rows` ([#125](#125)) ([ea21928](ea21928))
* rename `slice` to `slice_rows` ([#126](#126)) ([20d21c2](20d21c2))
* rename `TableSchema` to `Schema` ([#133](#133)) ([1419d25](1419d25))
@lars-reimann
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant