Skip to content

feat: rename fit_transform to fit_and_transform#119

Merged
lars-reimann merged 2 commits intoSafe-DS:mainfrom
gantanikhilraj:main
Mar 30, 2023
Merged

feat: rename fit_transform to fit_and_transform#119
lars-reimann merged 2 commits intoSafe-DS:mainfrom
gantanikhilraj:main

Conversation

@gantanikhilraj
Copy link
Copy Markdown
Contributor

@gantanikhilraj gantanikhilraj commented Mar 30, 2023 •
edited by lars-reimann
Loading

Closes #112.

Summary of Changes

Rename fit_transform to fit_and_transform to better indicate that this method combines the two steps fit and transform.

@gantanikhilraj gantanikhilraj requested a review from a team as a code owner March 30, 2023 04:58
@gantanikhilraj gantanikhilraj changed the title fix : fit_transform to fix_and_transform fix: fit_transform to fix_and_transform Mar 30, 2023
@dev-DTECH dev-DTECH mentioned this pull request Mar 30, 2023
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #119 (6cf8823) into main (95e1fc7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files          36       36           
  Lines        1258     1258           
=======================================
  Hits         1171     1171           
  Misses         87       87
Impacted Files Coverage Δ
.../data/tabular/transformation/_table_transformer.py 93.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann changed the title fix: fit_transform to fix_and_transform feat: rename fit_transform to fix_and_transform Mar 30, 2023
@gantanikhilraj gantanikhilraj changed the title feat: rename fit_transform to fix_and_transform fix: rename fit_transform to fix_and_transform Mar 30, 2023
@gantanikhilraj gantanikhilraj changed the title fix: rename fit_transform to fix_and_transform feat: rename fit_transform to fix_and_transform Mar 30, 2023
@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Mar 30, 2023

@gantanikhilraj Please leave the title with feat instead of fix, since this change is supposed to lead to a minor version increment 0.7.0 to 0.8.0. A fix would change the version from 0.7.0 to 0.7.1.

@gantanikhilraj
Copy link
Copy Markdown
Contributor Author

gantanikhilraj commented Mar 30, 2023

@gantanikhilraj Please leave the title with feat instead of fix, since this change is supposed to lead to a minor version increment 0.7.0 to 0.8.0. A fix would change the version from 0.7.0 to 0.7.1.

Ok @lars-reimann .

@lars-reimann lars-reimann changed the title feat: rename fit_transform to fix_and_transform feat: rename fit_transform to fit_and_transform Mar 30, 2023
lars-reimann
lars-reimann approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! I've just shortened the PR description a bit so it focuses more on the user-facing impact and renamed the test classes that correspond to the method.

@lars-reimann lars-reimann merged commit 76a7112 into Safe-DS:main Mar 30, 2023
@lars-reimann lars-reimann mentioned this pull request Mar 30, 2023
Closed
lars-reimann pushed a commit that referenced this pull request Mar 31, 2023
@semantic-release-bot
chore(release): 0.8.0 [skip ci]
2acbc6a 
## [0.8.0](v0.7.0...v0.8.0) (2023-03-31)

### Features

* create empty `Table` without schema ([#128](#128)) ([ddd3f59](ddd3f59)), closes [#127](#127)
* improve `ColumnType`s ([#132](#132)) ([1786a87](1786a87)), closes [#113](#113)
* infer schema of row if not passed explicitly ([#134](#134)) ([c5869bb](c5869bb)), closes [#15](#15)
* new method `is_fitted` to check whether a model is fitted ([#130](#130)) ([8e1c3ea](8e1c3ea))
* new method `is_fitted` to check whether a transformer is fitted ([#131](#131)) ([e20954f](e20954f))
* rename `drop_XY` methods of `Table` to `remove_XY` ([#122](#122)) ([98d76a4](98d76a4))
* rename `fit_transform` to `fit_and_transform` ([#119](#119)) ([76a7112](76a7112)), closes [#112](#112)
* rename `shuffle` to `shuffle_rows` ([#125](#125)) ([ea21928](ea21928))
* rename `slice` to `slice_rows` ([#126](#126)) ([20d21c2](20d21c2))
* rename `TableSchema` to `Schema` ([#133](#133)) ([1419d25](1419d25))
@lars-reimann
Copy link
Copy Markdown
Member

lars-reimann commented Mar 31, 2023

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

Assignees

No one assigned

Labels

released Included in a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename fit_transform to fit_and_transform

2 participants

@gantanikhilraj @lars-reimann