Skip to content

chore!: remove deprecated livechat:saveDepartment method #37462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 6 commits into from
Nov 12, 2025
Merged

chore!: remove deprecated livechat:saveDepartment method #37462

ggazzo merged 6 commits into from
Nov 12, 2025

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 10, 2025 •
edited by coderabbitai bot
Loading

ARCH-1877

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Breaking Changes
    • Removed the deprecated livechat:saveDepartment public API method in this major version release. This is a breaking change requiring users to migrate away from this method before upgrading. Please consult migration documentation for alternative approaches to manage Livechat departments.

@juliajforesti juliajforesti added this to the 8.0.0 milestone Nov 10, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 10, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2249046

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025 •
edited
Loading

Walkthrough

This PR removes the deprecated livechat:saveDepartment Meteor method from the public API, including its server-side implementation, type definitions, import declarations, and related test coverage. A changeset documents the major version bump for @rocket.chat/meteor.

Changes

Cohort / File(s) Summary
Changeset
.changeset/nervous-wombats-look.md		 Documents major version bump for @rocket.chat/meteor package with removal of deprecated public API method.
Method implementation removal
apps/meteor/app/livechat/server/methods/saveDepartment.ts, apps/meteor/app/livechat/server/index.ts		 Removes the entire server-side livechat:saveDepartment method implementation, its Meteor method registration, TypeScript interface augmentation, and side-effect import.
Test refactoring
apps/meteor/tests/data/livechat/department.ts		 Refactors createDepartment function signature, removes createDepartmentWithMethod export, and updates call sites to use the simplified direct HTTP-based creation.
Test suite updates
apps/meteor/tests/end-to-end/api/livechat/14-units.ts		 Removes imports for methodCall and createDepartmentWithMethod; deletes test block covering the livechat:saveDepartment method and associated validation cases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Most changes are straightforward removals of deprecated method code and related test cases
  • Test helper refactoring in department.ts is localized and follows a clear consolidation pattern
  • Removal is clean across multiple files with consistent intent

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo
  • MartinSchoeler
  • dougfabris

Poem

🐇 A deprecated path fades away,
Clearing cobwebs from yesterday,
With tests refined and methods gone,
Rocket.Chat moves bold and strong! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: removing the deprecated livechat:saveDepartment method, which is confirmed by all modified files.
Linked Issues check ✅ Passed The PR successfully removes the deprecated livechat:saveDepartment method as required by ARCH-1877, including the method implementation, imports, tests, and related code.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the deprecated livechat:saveDepartment method; no unrelated modifications or scope creep detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-saveDepartment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 10be746 and 2249046.

📒 Files selected for processing (5)
  • .changeset/nervous-wombats-look.md (1 hunks)
  • apps/meteor/app/livechat/server/index.ts (0 hunks)
  • apps/meteor/app/livechat/server/methods/saveDepartment.ts (0 hunks)
  • apps/meteor/tests/data/livechat/department.ts (6 hunks)
  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts (1 hunks)
💤 Files with no reviewable changes (2)
  • apps/meteor/app/livechat/server/index.ts
  • apps/meteor/app/livechat/server/methods/saveDepartment.ts
🧰 Additional context used
🧠 Learnings (14)
📓 Common learnings 
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,tsx,js,jsx} : Avoid code comments in the implementation

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Maintain test isolation between test cases

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use descriptive test names that clearly communicate expected behavior

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Group related tests in the same file

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure tests run reliably in parallel without shared state conflicts

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,tsx,js,jsx} : Follow DRY by extracting reusable logic into helper functions or page objects

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,tsx,js,jsx} : Write concise, technical TypeScript/JavaScript with accurate typing

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure a clean state for each test execution

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/page-objects/**/*.ts : Utilize and place Page Object implementations under apps/meteor/tests/e2e/page-objects/

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use expect matchers (toEqual, toContain, toBeTruthy, toHaveLength, etc.) instead of assert statements

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use test.beforeAll() and test.afterAll() for setup and teardown

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-16T22:08:51.490Z 
Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Utilize Playwright fixtures (test, page, expect) consistently

Applied to files:

  • apps/meteor/tests/end-to-end/api/livechat/14-units.ts
📚 Learning: 2025-09-19T15:15:04.642Z 
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

  • .changeset/nervous-wombats-look.md
🧬 Code graph analysis (1)
apps/meteor/tests/data/livechat/department.ts (1)
apps/meteor/tests/data/api-data.ts (2)
  • request (10-10)
  • credentials (39-42)
🔇 Additional comments (1)
apps/meteor/tests/data/livechat/department.ts (1)

20-31: Default merge keeps helper flexible.

Merging NewDepartmentData with overrides keeps the helper ergonomic for tests that only tweak a few fields—thanks for tightening this up.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.94%. Comparing base (3c42f0d) to head (2249046).
⚠️ Report is 421 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #37462      +/-   ##
=================================================
+ Coverage          66.43%   70.94%   +4.50%     
=================================================
  Files               3276     3035     -241     
  Lines             109596   104621    -4975     
  Branches           20860    18436    -2424     
=================================================
+ Hits               72814    74219    +1405     
+ Misses             34116    28454    -5662     
+ Partials            2666     1948     -718
Flag Coverage Δ
e2e 58.09% <ø> (+0.24%) ⬆️
e2e-api ?
unit 72.27% <ø> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti force-pushed the chore/remove-saveDepartment branch from 4048dcb to b441e85 Compare November 11, 2025 17:19
@juliajforesti juliajforesti marked this pull request as ready for review November 12, 2025 12:19
@juliajforesti juliajforesti requested review from a team as code owners November 12, 2025 12:19
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 12, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 12, 2025
@ggazzo ggazzo merged commit 2ac0771 into release-8.0.0 Nov 12, 2025
52 checks passed
@ggazzo ggazzo deleted the chore/remove-saveDepartment branch November 12, 2025 16:28
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
7cf4e94
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
5b0ac68
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
648aad5
ggazzo pushed a commit that referenced this pull request Nov 13, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
481c8af
ggazzo pushed a commit that referenced this pull request Nov 18, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
94daba9
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
949b49c
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
efbedaf
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
b7b6960
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
169b783
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
73d9200
ggazzo pushed a commit that referenced this pull request Dec 9, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
eac2116
ggazzo pushed a commit that referenced this pull request Dec 10, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
d40f535
ggazzo pushed a commit that referenced this pull request Dec 15, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
6c8569f
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
2b6efe9
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
11c22ad
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
597a460
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
384f82c
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
f45897f
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
afd16cd
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
17838a4
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
9ebefc6
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
6f66c75
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
1f9a6de
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
a8c51b0
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
3047fd2
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
a7daa6d
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@juliajforesti @ggazzo
chore!: remove deprecated livechat:saveDepartment method (#37462)
cbe29e1
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
@juliajforesti @dougfabris
chore!: remove deprecated livechat:saveDepartment method (#37462)
9c34df2
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Dec 21, 2025
Merged
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
@juliajforesti @gaolin1
chore!: remove deprecated livechat:saveDepartment method (RocketCha…
4da9fe8 
…t#37462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@juliajforesti @ggazzo