-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Adds deprecation warning on livechat:saveDepartment
#36981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 561e963 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughIntroduces internal deprecation logging for the Meteor method livechat:saveDepartment using methodDeprecationLogger, emitting a notice for version 8.0.0 and REST path /v1/livechat/department. Adds a corresponding changeset entry marking a patch release for @rocket.chat/meteor. No public signatures or error handling are modified. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant M as Meteor Method<br/>livechat:saveDepartment
participant L as methodDeprecationLogger
participant S as Livechat Service/DB
C->>M: Call saveDepartment(payload)
rect rgba(200,220,255,0.25)
note over M,L: New deprecation notice
M->>L: log('livechat:saveDepartment', '8.0.0', '/v1/livechat/department')
L-->>M: acknowledged
end
M->>M: Get userId, check permissions, validate input
M->>S: Create/Update department
S-->>M: Result/Errors
M-->>C: Response
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
🔇 Additional comments (3)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36981 +/- ##
===========================================
- Coverage 67.32% 66.26% -1.07%
===========================================
Files 3339 3393 +54
Lines 113205 115456 +2251
Branches 20532 21157 +625
===========================================
+ Hits 76219 76503 +284
- Misses 34380 36342 +1962
- Partials 2606 2611 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
This PR adds a deprecation warning for
livechat:saveDepartmentmeteor method.Issue(s)
CTZ-65
Steps to test or reproduce
Further comments
Summary by CodeRabbit