Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 5, 2025

ARCH-1861

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Removed the deprecated Livechat agent information saving method.

@juliajforesti juliajforesti added this to the 8.0.0 milestone Nov 5, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 5, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

🦋 Changeset detected

Latest commit: 58799e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Walkthrough

The PR removes the deprecated livechat:saveAgentInfo DDP method from the Rocket.Chat Meteor server application. This includes deleting the method implementation file, removing its import from the server initialization, and documenting the removal through a changeset entry.

Changes

Cohort / File(s) Summary
Changeset documentation
.changeset/thick-guests-compete.md
Adds changeset entry documenting major version bump for @rocket.chat/meteor and removal of deprecated livechat:saveAgentInfo method
Livechat server method removal
apps/meteor/app/livechat/server/index.ts
Removes import of ./methods/saveAgentInfo module to prevent initialization of the deprecated method
apps/meteor/app/livechat/server/methods/saveAgentInfo.ts

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Straightforward removal of deprecated code with clear scope and homogeneous changes
  • Verify no other references to livechat:saveAgentInfo remain in the codebase
  • Confirm that the replacement REST endpoint mentioned in related PRs is available for clients

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • dougfabris
  • MartinSchoeler
  • sampaiodiego

Poem

🐰 A method deprecated, now sent to rest,
Its import removed, its code laid to jest,
The agent's old path fades into the night,
While newer roads lead our livechat right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removal of the deprecated livechat:saveAgentInfo method, which aligns with the actual code changes in the changeset.
Linked Issues check ✅ Passed The PR addresses ARCH-1861 by removing the livechat:saveAgentInfo method as required. The changeset, method removal, and import cleanup are consistent with the objective to deprecate and remove this method.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the deprecated livechat:saveAgentInfo method: the changeset entry, the method implementation deletion, and the import removal from index.ts are all in scope.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-saveAgentInfo

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1566dca and 58799e2.

📒 Files selected for processing (3)
  • .changeset/thick-guests-compete.md (1 hunks)
  • apps/meteor/app/livechat/server/index.ts (0 hunks)
  • apps/meteor/app/livechat/server/methods/saveAgentInfo.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • apps/meteor/app/livechat/server/index.ts
  • apps/meteor/app/livechat/server/methods/saveAgentInfo.ts
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

  • .changeset/thick-guests-compete.md
🔇 Additional comments (1)
.changeset/thick-guests-compete.md (1)

1-5: Changeset correctly documents the breaking change.

The version bump type is appropriate: removing a deprecated public method is a breaking change that warrants a major version bump. The description clearly documents what was removed.

Consider referencing the issue for additional traceability (e.g., "Removes deprecated livechat:saveAgentInfo method (ARCH-1861)"), though the current form is sufficient for a changeset entry.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.92%. Comparing base (3c42f0d) to head (58799e2).
⚠️ Report is 389 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #37393      +/-   ##
=================================================
+ Coverage          66.43%   70.92%   +4.48%     
=================================================
  Files               3276     3031     -245     
  Lines             109596   104339    -5257     
  Branches           20860    18373    -2487     
=================================================
+ Hits               72814    74001    +1187     
+ Misses             34116    28405    -5711     
+ Partials            2666     1933     -733     
Flag Coverage Δ
e2e 58.03% <ø> (+0.18%) ⬆️
e2e-api ?
unit 72.28% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti marked this pull request as ready for review November 5, 2025 19:04
@juliajforesti juliajforesti requested a review from a team as a code owner November 5, 2025 19:04
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Nov 5, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 5, 2025
@ggazzo ggazzo merged commit d1c640c into release-8.0.0 Nov 5, 2025
43 checks passed
@ggazzo ggazzo deleted the chore/remove-saveAgentInfo branch November 5, 2025 19:07
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants