.changeset/cuddly-dots-end.md (1)

1-7: Fix stray character and clarify endpoint path in changeset

There’s an orphan “7” at the end and the replacement endpoint should include the version prefix for clarity.

Apply this diff:

 Adds deprecation warning on `livechat:saveAgentInfo` with new endpoint replacing it; `livechat/agents.saveInfo`
+Adds deprecation warning for `livechat:saveAgentInfo`; replacement endpoint: `POST /v1/livechat/agents.saveInfo`.
-7

apps/meteor/client/views/omnichannel/agents/AgentEdit.tsx (1)

82-92: Send only mutable fields in agentData (avoid name/username/email), and precompute department IDs

Prevents leaking read‑only fields and makes payload minimal/explicit.

-  await saveAgentInfo({
-    agentId: agentData._id,
-    agentData: data,
-    agentDepartments: departments.map((dep) => dep.value),
-  });
+  const agentDepartmentsIds = departments.map((dep) => dep.value);
+  const { maxNumberSimultaneousChat, voipExtension } = data;
+  await saveAgentInfo({
+    agentId: agentData._id,
+    agentData: {
+      ...(typeof maxNumberSimultaneousChat === 'number' ? { maxNumberSimultaneousChat } : {}),
+      ...(voipEnabled ? { voipExtension } : {}),
+    },
+    agentDepartments: agentDepartmentsIds,
+  });

packages/rest-typings/src/v1/omnichannel.ts (1)

1726-1767: Add route signature to OmnichannelEndpoints to avoid relying on server-side module augmentation for client typing

You defined validators but didn’t wire the endpoint into the OmnichannelEndpoints map. Adding it here ensures useEndpoint gets proper types in the client without depending on ambient augmentation declared in a server file.

 export type OmnichannelEndpoints = {
+  '/v1/livechat/agents.saveInfo': {
+    POST: (params: POSTLivechatAgentSaveInfoParams) => void;
+  };

Please confirm TS type inference for useEndpoint('POST', '/v1/livechat/agents.saveInfo') works in the client after this change. If you prefer keeping the server-side augmentation, ensure the ambient declaration is included in the client TS program.

apps/meteor/tests/data/livechat/users.ts (1)

101-116: Assert success:true in response to catch silent failures

Currently only status and content-type are asserted.

   await request
     .post(api('livechat/agents.saveInfo'))
     .set(credentials)
     .send({
       agentId,
       agentData: livechatSettings,
       agentDepartments,
     })
     .expect('Content-Type', 'application/json')
-    .expect(200);
+    .expect(200)
+    .expect((res) => {
+      if (res.body?.success !== true) throw new Error('Expected { success: true } from livechat/agents.saveInfo');
+    });

apps/meteor/tests/e2e/omnichannel/omnichannel-agents.spec.ts (1)

118-118: Tighten waitForResponse filter (URL + method) to reduce flakiness

Use a predicate to ensure it’s the POST to the exact endpoint.

-    const response = page.waitForResponse('**/api/v1/livechat/agents.saveInfo');
+    const response = page.waitForResponse((r) => r.url().endsWith('/api/v1/livechat/agents.saveInfo') && r.request().method() === 'POST');

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: RocketChat/Rocket.Chat#0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Use descriptive test names that clearly communicate expected behavior

Learnt from: CR
PR: RocketChat/Rocket.Chat#0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,tsx} : Implement proper wait strategies for dynamic content

Learnt from: CR
PR: RocketChat/Rocket.Chat#0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,tsx} : Use page.waitFor() with specific conditions and avoid hardcoded timeouts

Learnt from: CR
PR: RocketChat/Rocket.Chat#0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Utilize Playwright fixtures (test, page, expect) consistently

Learnt from: CR
PR: RocketChat/Rocket.Chat#0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure tests run reliably in parallel without shared state conflicts

Learnt from: CR
PR: RocketChat/Rocket.Chat#0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Prefer web-first assertions (e.g., toBeVisible, toHaveText)

Learnt from: CR
PR: RocketChat/Rocket.Chat#0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-09-16T22:08:51.490Z
Learning: Applies to apps/meteor/tests/e2e/**/*.{ts,tsx} : Avoid using page.locator(); prefer semantic locators like page.getByRole, page.getByLabel, page.getByText, and page.getByTitle