Skip to content

Danger: block manual edits to generated error codes#930

Merged
AlvaroBrey merged 1 commit into
mainfrom
danger-generated-guard
Jun 15, 2026
Merged

Danger: block manual edits to generated error codes#930
AlvaroBrey merged 1 commit into
mainfrom
danger-generated-guard

Conversation

@AlvaroBrey

@AlvaroBrey AlvaroBrey commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
CI and Danger policy only; no runtime SDK or auth/data behavior changes.

Overview
Adds a Danger guard that fails PRs that touch files under src/generated/ (e.g. autogenerated error-codes.ts from purchases-error-codes), using the shared fail_on_generated_edits helper from RevenueCat/Dangerfile.

Bumps the sdks-common-config CircleCI orb from 3.21.0 to 3.21.1 so automated update_error_codes PRs get the correct labels.

Reviewed by Cursor Bugbot for commit 680579e. Bugbot is set up for automated code reviews on this repo. Configure here.

@AlvaroBrey AlvaroBrey self-assigned this Jun 15, 2026
@AlvaroBrey AlvaroBrey force-pushed the danger-generated-guard branch from a10ff79 to 8f5bb98 Compare June 15, 2026 09:56
Call the shared fail_on_generated_edits helper for src/generated/ (bypass via
pr:auto_codegen). Bump orb to 3.21.1, which applies the pr:auto_codegen label.
@AlvaroBrey AlvaroBrey force-pushed the danger-generated-guard branch from 8f5bb98 to 680579e Compare June 15, 2026 10:00
@AlvaroBrey AlvaroBrey marked this pull request as ready for review June 15, 2026 10:11
@AlvaroBrey AlvaroBrey requested a review from a team June 15, 2026 10:12
@AlvaroBrey AlvaroBrey merged commit 691d53a into main Jun 15, 2026
7 checks passed
@AlvaroBrey AlvaroBrey deleted the danger-generated-guard branch June 15, 2026 10:23
RCGitBot added a commit that referenced this pull request Jun 16, 2026
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* Add Slovenian support for paywalls (#932) via Monika Mateska
(@MonikaMateska)
* [WEB-4279] Discount line items in native wallets (#905) via James
O'Donnell (@james-od)

## RevenueCatUI SDK
### ✨ New Features
* WFL-217 | Add support for workflows endpoints (#913) via Rosie Watson
(@RosieWatson)

### 🔄 Other Changes
* [AUTOMATIC] Update generated error codes (#931) via RevenueCat Git Bot
(@RCGitBot)
* Danger: block manual edits to generated error codes (#930) via Álvaro
Brey (@AlvaroBrey)
* Add update-error-codes workflow (#926) via Álvaro Brey (@AlvaroBrey)
* test(e2e): add full Paddle E2E coverage to webbilling-demo (WST-564)
(#925) via Roger Solé (@rogersole)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Version and changelog-only changes with no runtime logic modified in
this PR.
> 
> **Overview**
> **Automatic release** that publishes **1.43.0** by aligning version
metadata everywhere it is duplicated: `.version`, `package.json`,
`src/helpers/constants.ts`, and the docs redirect in
`scripts/docs/index.html` (1.42.4 → 1.43.0).
> 
> `CHANGELOG.md` and `CHANGELOG.latest.md` are updated to document what
ships in this release (already merged elsewhere): **Slovenian paywall
locale**, **discount line items in native wallets**, **RevenueCatUI
workflows endpoints**, regenerated error codes plus CI/Danger
guardrails, and expanded Paddle E2E coverage in webbilling-demo.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
ef5e9f3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants