test(e2e): add full Paddle E2E coverage to webbilling-demo (WST-564)#925
Merged
Conversation
…t-scoped (WST-710) Extracted from #820 (credit: @nicfix). The /v1/events stub previously fulfilled any provider's /v1/events endpoint; Paddle exposes its own events-like endpoints that must go through. Also makes the userId/email fixtures explicitly test-scoped ahead of the Paddle E2E suite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adds VITE_RC_PADDLE_E2E_API_KEY / VITE_SKIP_PADDLE_TESTS wiring (fixtures, skip helper, .env.example, README, CircleCI exports). No tests reference the key yet; the config guard lands with the Paddle suite so CI cannot fail before the CircleCI secret exists. Infra lifted from #820 (credit: @nicfix). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 11, 2026
vicfergar
reviewed
Jun 12, 2026
685cb24 to
4a44191
Compare
rogersole
added a commit
that referenced
this pull request
Jun 12, 2026
Addresses review feedback on #925: parameterize the email-as-query-param test over inline and overlay, empirically confirming Paddle omits the email field in both modes when customerEmail is provided (the email travels via /checkout/start, before any presentation choice). Helper comment expanded to capture that. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…(WST-712) - navigateToPaddleLandingUrl + forcePaddleCheckoutMode: forces inline or overlay presentation by rewriting inline_checkout_enabled in the real /checkout/start response, so one E2E project covers both modes deterministically regardless of the backend per-project flag. - Mode-aware frame locators (inline container scoped; overlay via paddle.com iframe src) and completePaddleCheckoutForm parameterized by FrameLocator so it serves both modes (field locators from #820, credit: @nicfix). - config-guard test: fails loudly on CI if VITE_RC_PADDLE_E2E_API_KEY is missing instead of letting the suite silently skip. - First test: error screen when checkout/start returns missing paddle billing params (mode-agnostic, CI-safe). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…T-712) Replaces the role-based field guesses with Paddle's own test ids (cardNumberInput, authenticationEmailInput, cardPaymentFormSubmitButton) and the fill order proven in rc-billing-checkout/src/e2e (country first, Andorra to avoid the postcode field; wait for logoutLinkTextCTA before submitting). Pins the overlay frame selector to iframe.paddle-frame/iframe[name='paddle_frame']. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…n (WST-712) Verified against the real Paddle E2E project: this checkout has no logoutLinkTextCTA and renders the submit as 'Subscribe now', and the error screen shows 'An unknown error occurred' rather than the Stripe flow's 'Purchase not started' copy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Paddle authenticates the filled email asynchronously and silently swallows submit clicks that land mid-authentication (observed against the sandbox). Blur the email field and re-click submit until the form transitions away. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
3f3e271 to
b6dca4b
Compare
rogersole
added a commit
that referenced
this pull request
Jun 12, 2026
Addresses review feedback on #925: parameterize the email-as-query-param test over inline and overlay, empirically confirming Paddle omits the email field in both modes when customerEmail is provided (the email travels via /checkout/start, before any presentation choice). Helper comment expanded to capture that. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
f27a944 to
73b75ad
Compare
…ST-713) - Inline: open forced-inline checkout, click the RC return button (data-testid=paddle-return-button), assert the checkout unmounts and the demo stays on the paywall (no /success navigation). - Overlay: open forced-overlay checkout, close via Paddle's own control (fires a user-initiated checkout.closed), assert the overlay iframe is gone and the paywall is interactive again. Neither test completes a payment, so both always run on CI regardless of the datacenter-IP completion spike (WST-709). Overlay iframe/close-control selectors carry TODO(WST-713) markers to be pinned during headed verification against the sandbox. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…T-713)
Paddle's overlay close affordance is a 'Return to {seller}' button
inside the overlay frame, not an X/close control.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…T-714) - Inline: sandbox banner + RC order summary visible (presence only — exact totals depend on checkout.updated timing), form completion in the container-scoped frame, processing-or-success race, success page, Continue -> /success/. - Overlay: form completion in Paddle's overlay frame, success page. Both tests skip on CI until the WST-709 spike validates that Paddle sandbox completes purchases from datacenter IPs (Stripe does not), mirroring the Stripe suite's original LOCAL_ONLY_COMPLETION gating. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…xists (WST-714) The Paddle E2E project's products grant no entitlement yet, so the demo's entitlement-gated success page cannot render its content (it currently crashes on a null offering in WithEntitlement). Reaching /success/ already proves the purchase completed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… exists (WST-714) The paddle_e2e_test offering's products now grant an entitlement, so the success page renders its content like in the Stripe suite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The WST-709 spike (#923) confirmed Paddle sandbox completes purchases from CircleCI IPs — both happy paths passed on CI — so the local-only gating the Stripe suite needs is unnecessary here. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Addresses review feedback on #920: fold the near-identical inline and overlay happy-path tests into a single forEach over the two modes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Email as query parameter (inline): with customerEmail provided, Paddle omits the email field entirely (verified against the sandbox) — helper updated to treat the absent field as expected. - RC Paywall + Paddle (overlay): gated by ALLOW_PAYWALLS_TESTS; requires an RC Paywall configured on the paddle_e2e_test offering. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…-715) The paddle_e2e_test offering now has a V2 paywall: duration-labeled package buttons and a Continue CTA. The success page's Continue is scoped to the SDK footer since the paywall's own Continue CTA stays mounted behind the checkout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Parameterizes the RC Paywall purchase over inline and overlay, since inline mounts the RC checkout UI over the paywall and deserves its own coverage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Addresses review feedback on #925: parameterize the email-as-query-param test over inline and overlay, empirically confirming Paddle omits the email field in both modes when customerEmail is provided (the email travels via /checkout/start, before any presentation choice). Helper comment expanded to capture that. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
b6dca4b to
ad6c5c9
Compare
73b75ad to
287cbb1
Compare
This was referenced Jun 12, 2026
vicfergar
reviewed
Jun 12, 2026
vicfergar
reviewed
Jun 12, 2026
vicfergar
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, but I left a few suggestions.
It might also be worth checking why the number of skipped tests increased:
# In main:
64 skipped
162 passed
# In this branch:
82 skipped (+18)
176 passed (+14)
Addresses review feedback on #925: fold the two cancel tests into a forEach over the modes, and remove the 1s afterEach sleeps — Paddle showed no rate limiting across repeated back-to-back full-suite runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Re: the skipped-test increase — pulled the actual CI outputs from both runs and decoded them (
The +30 entries are the new Paddle suite: 10 tests × 3 browsers. Expected split is +20 skipped (firefox + webkit skip the whole suite on CI — same chromium-only policy as the existing The ~64-skip baseline is identical in both runs and fully accounted for:
Bottom line: zero unexpected skips, no Paddle test ever skips on chromium, and the baseline skip behavior is byte-for-byte the same as |
The previous filter only matched revenuecat.com, but production SDK builds send analytics to e.revenue.cat (and dev/test builds to localhost), so RevenueCat's own events were no longer being stubbed. Match by hostname against revenue.cat / revenuecat.com / localhost, still letting other providers' /v1/events-like endpoints through. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit eafccba. Configure here.
vicfergar
approved these changes
Jun 12, 2026
RCGitBot
added a commit
that referenced
this pull request
Jun 16, 2026
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add Slovenian support for paywalls (#932) via Monika Mateska (@MonikaMateska) * [WEB-4279] Discount line items in native wallets (#905) via James O'Donnell (@james-od) ## RevenueCatUI SDK ### ✨ New Features * WFL-217 | Add support for workflows endpoints (#913) via Rosie Watson (@RosieWatson) ### 🔄 Other Changes * [AUTOMATIC] Update generated error codes (#931) via RevenueCat Git Bot (@RCGitBot) * Danger: block manual edits to generated error codes (#930) via Álvaro Brey (@AlvaroBrey) * Add update-error-codes workflow (#926) via Álvaro Brey (@AlvaroBrey) * test(e2e): add full Paddle E2E coverage to webbilling-demo (WST-564) (#925) via Roger Solé (@rogersole) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and changelog-only changes with no runtime logic modified in this PR. > > **Overview** > **Automatic release** that publishes **1.43.0** by aligning version metadata everywhere it is duplicated: `.version`, `package.json`, `src/helpers/constants.ts`, and the docs redirect in `scripts/docs/index.html` (1.42.4 → 1.43.0). > > `CHANGELOG.md` and `CHANGELOG.latest.md` are updated to document what ships in this release (already merged elsewhere): **Slovenian paywall locale**, **discount line items in native wallets**, **RevenueCatUI workflows endpoints**, regenerated error codes plus CI/Danger guardrails, and expanded Paddle E2E coverage in webbilling-demo. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ef5e9f3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full Paddle E2E coverage for
examples/webbilling-demo(WST-564). This PR now targetsmainand contains the entire stack; #916, #917, #918, #919 and #920 remain open as individually reviewable slices of the same commits — merging this one merges everything (close the slices afterwards). Supersedes #820 (credit @nicfix for the original groundwork).Test suite (
src/tests/paddle/, 11 tests)VITE_RC_PADDLE_E2E_API_KEYis missing instead of silently skipping (skips locally)customerEmailis provided (verified against the sandbox; mode-independent since the email travels via/checkout/start)ALLOW_PAYWALLS_TESTScheckout/startreturningpaddle_billing_params: null→ error screenKey infrastructure
forcePaddleCheckoutMode(page, "inline" | "overlay"): rewritespaddle_billing_params.inline_checkout_enabledin the real/checkout/startresponse, so one E2E project deterministically covers both presentation modes regardless of the backend per-project flag (WST-700).completePaddleCheckoutForm(frame, ...): mode-agnostic form fill using Paddle's own test ids, Andorra to skip the postcode field, and a submit re-click loop (Paddle silently swallows submits that land while the async email authentication is in flight).iframe.paddle-frame, iframe[name='paddle_frame']./v1/eventsstub now only intercepts RevenueCat's endpoint (Paddle has its own);userId/emailfixtures test-scoped.VITE_RC_PADDLE_E2E_API_KEY,VITE_SKIP_PADDLE_TESTS, CircleCI exports, README setup section.CI
E2E_RC_PADDLE_E2E_API_KEYin CircleCI (configured) andpaddle_e2e_testoffering with entitlement + V2 paywall (configured).Test plan
tsc --noEmit, eslint, prettier clean🤖 Generated with Claude Code
Note
Low Risk
Changes are confined to demo E2E tests, docs, and CircleCI env exports; no production SDK or billing logic is modified.
Overview
Adds full Paddle E2E coverage to
examples/webbilling-demo, parallel to the existing Stripe Checkout suite.New Playwright specs under
src/tests/paddle/cover inline and overlay checkout (happy path, email via query param, RC Paywall, cancel/close, andcheckout/startmissingpaddle_billing_params).forcePaddleCheckoutModerewritesinline_checkout_enabledon the real/checkout/startresponse so both modes run from one E2E project. Shared helpers handle Paddle iframe locators, sandbox card fill (Andorra, submit retry loop), and navigation withVITE_RC_PADDLE_E2E_API_KEY.Harness updates:
SKIP_PADDLE_TESTS/skipPaddleTestsIfDisabled, CI guard so a missing Paddle key fails on CI instead of silent skip,userId/emailfixtures scoped per test, and/v1/eventsstubbing limited to RevenueCat hosts so Paddle traffic is not blocked. CircleCI,.env.example, and README documentVITE_RC_PADDLE_E2E_API_KEYandVITE_SKIP_PADDLE_TESTS; Paddle runs Chromium-only on CI.Reviewed by Cursor Bugbot for commit 521c28e. Bugbot is set up for automated code reviews on this repo. Configure here.