Skip to content

open-error-codes-pr: Change codegen label to match existing patterns#68

Merged
AlvaroBrey merged 1 commit into
mainfrom
chore/alvaro.brey/update-error-codes-label
Jun 15, 2026
Merged

open-error-codes-pr: Change codegen label to match existing patterns#68
AlvaroBrey merged 1 commit into
mainfrom
chore/alvaro.brey/update-error-codes-label

Conversation

@AlvaroBrey

@AlvaroBrey AlvaroBrey commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Let's not break the pr: pattern.

After this is done I'll release a new orb and bump it in consumers together with the check that prevents modifications to generated files

@AlvaroBrey AlvaroBrey requested a review from a team June 15, 2026 08:19
@AlvaroBrey AlvaroBrey requested a review from a team as a code owner June 15, 2026 08:19
@AlvaroBrey AlvaroBrey removed the request for review from a team June 15, 2026 08:19
@AlvaroBrey AlvaroBrey force-pushed the chore/alvaro.brey/update-error-codes-label branch from 34a0105 to 94e8534 Compare June 15, 2026 08:20
@RCGitBot

RCGitBot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/revenuecat/sdks-common-config?version=dev:94e853437a1c708499c30b25432524c92e8665d3

ajpallares
ajpallares approved these changes Jun 15, 2026
View reviewed changes

@ajpallares ajpallares left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Makes sense

@AlvaroBrey AlvaroBrey merged commit 1f4cafa into main Jun 15, 2026
16 checks passed
@RCGitBot

RCGitBot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/revenuecat/sdks-common-config?version=dev:1f4cafa698dc3f60e46f261f99c8d7224a46278c

1 similar comment
@RCGitBot

RCGitBot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/revenuecat/sdks-common-config?version=dev:1f4cafa698dc3f60e46f261f99c8d7224a46278c

@RCGitBot

RCGitBot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/revenuecat/sdks-common-config?version=3.21.1

This was referenced Jun 15, 2026
Merged
Merged
Merged
AlvaroBrey added a commit to RevenueCat/purchases-js that referenced this pull request Jun 15, 2026
@AlvaroBrey
Danger: block manual edits to generated error codes (#930)
691d53a 
- Adds a Danger check to prevent modification of autogenerated files
from
[purchases-error-codes](https://github.com/RevenueCat/purchases-error-codes).
Calls a function defined in
[RevenueCat/Dangerfile](RevenueCat/Dangerfile#16)
- Bumps the [shared
orb](RevenueCat/sdks-circleci-orb#68) to get the
proper labels on the generated PRs

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> CI and Danger policy only; no runtime SDK or auth/data behavior
changes.
> 
> **Overview**
> Adds a **Danger** guard that fails PRs that touch files under
`src/generated/` (e.g. autogenerated `error-codes.ts` from
purchases-error-codes), using the shared `fail_on_generated_edits`
helper from **RevenueCat/Dangerfile**.
> 
> Bumps the **sdks-common-config** CircleCI orb from `3.21.0` to
`3.21.1` so automated `update_error_codes` PRs get the correct labels.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
680579e. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajpallares ajpallares ajpallares approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlvaroBrey @RCGitBot @ajpallares