Skip to content

Add origin to HTTPResponseType#3793

Merged
vegaro merged 2 commits into
mainfrom
add-origin
Apr 10, 2024
Merged

Add origin to HTTPResponseType#3793
vegaro merged 2 commits into
mainfrom
add-origin

Conversation

@vegaro

@vegaro vegaro commented Apr 10, 2024

Copy link
Copy Markdown
Member

This is needed for Diagnostics

@vegaro vegaro added the pr:feat A new feature label Apr 10, 2024
@vegaro vegaro requested a review from a team April 10, 2024 10:32
@vegaro vegaro added refactor and removed pr:feat A new feature labels Apr 10, 2024
enum HTTPResponseOrigin {

case backend

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nitpick but should this line be removed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. According to the style guide it should. Thanks!

@vegaro vegaro enabled auto-merge (squash) April 10, 2024 11:08
@vegaro vegaro merged commit becc152 into main Apr 10, 2024
@vegaro vegaro deleted the add-origin branch April 10, 2024 11:38
tonidero pushed a commit that referenced this pull request Apr 12, 2024
**This is an automatic release.**

### Bugfixes
* Prevent Template 4 from wrapping Lifetime (#3789) via Josh Holtz
(@joshdholtz)
* Add enum entry for external purchases store (#3779) via Mark
Villacampa (@MarkVillacampa)
### Dependency Updates
* Bump fastlane from 2.219.0 to 2.220.0 (#3783) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Add option to intercept touch events in `PaywallViewController`
(#3801) via Toni Rico (@tonidero)
* Create DiagnosticsPostOperation (#3795) via Cesar de la Vega (@vegaro)
* Add diagnosticsQueue to BackendConfiguration (#3794) via Cesar de la
Vega (@vegaro)
* Add origin to HTTPResponseType (#3793) via Cesar de la Vega (@vegaro)
* Add name property to HTTPRequestPath (#3790) via Cesar de la Vega
(@vegaro)
* Add name to VerificationResult (#3792) via Cesar de la Vega (@vegaro)
* Add HTTPRequest.DiagnosticsPath (#3791) via Cesar de la Vega (@vegaro)
* Add async `syncAttributesAndOfferingsIfNeeded()` (#3785) via Josh
Holtz (@joshdholtz)
* iOS append events to JSONL file and get diagnostics events (#3781) via
Cesar de la Vega (@vegaro)
* Fix offerings integration test (#3782) via Josh Holtz (@joshdholtz)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants