Skip to content

Prevent Template 4 from wrapping Lifetime#3789

Merged
joshdholtz merged 2 commits into
mainfrom
fix-template-4-to-prevent-lifetime-wrapping
Apr 10, 2024
Merged

Prevent Template 4 from wrapping Lifetime#3789
joshdholtz merged 2 commits into
mainfrom
fix-template-4-to-prevent-lifetime-wrapping

Conversation

@joshdholtz

Copy link
Copy Markdown
Member

Motivation

Prevent "Lifetime" from wrapping in Template 4

Description

  • Added .frame(maxWidth: .infinity) to the package button textfields
    • They were not expanding all the way due to calculations on their parent's width
Before After
Screenshot 2024-04-09 at 9 12 57 PM Screenshot 2024-04-09 at 9 12 16 PM

@joshdholtz joshdholtz requested review from a team April 10, 2024 02:15
@joshdholtz joshdholtz added the pr:fix A bug fix label Apr 10, 2024
@joshdholtz joshdholtz merged commit 7d046c2 into main Apr 10, 2024
@joshdholtz joshdholtz deleted the fix-template-4-to-prevent-lifetime-wrapping branch April 10, 2024 14:19
tonidero pushed a commit that referenced this pull request Apr 12, 2024
**This is an automatic release.**

### Bugfixes
* Prevent Template 4 from wrapping Lifetime (#3789) via Josh Holtz
(@joshdholtz)
* Add enum entry for external purchases store (#3779) via Mark
Villacampa (@MarkVillacampa)
### Dependency Updates
* Bump fastlane from 2.219.0 to 2.220.0 (#3783) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Add option to intercept touch events in `PaywallViewController`
(#3801) via Toni Rico (@tonidero)
* Create DiagnosticsPostOperation (#3795) via Cesar de la Vega (@vegaro)
* Add diagnosticsQueue to BackendConfiguration (#3794) via Cesar de la
Vega (@vegaro)
* Add origin to HTTPResponseType (#3793) via Cesar de la Vega (@vegaro)
* Add name property to HTTPRequestPath (#3790) via Cesar de la Vega
(@vegaro)
* Add name to VerificationResult (#3792) via Cesar de la Vega (@vegaro)
* Add HTTPRequest.DiagnosticsPath (#3791) via Cesar de la Vega (@vegaro)
* Add async `syncAttributesAndOfferingsIfNeeded()` (#3785) via Josh
Holtz (@joshdholtz)
* iOS append events to JSONL file and get diagnostics events (#3781) via
Cesar de la Vega (@vegaro)
* Fix offerings integration test (#3782) via Josh Holtz (@joshdholtz)
@NachoSoto

Copy link
Copy Markdown
Contributor

Does this work when there are more than 3 and it scrolls horizontally?

@joshdholtz

Copy link
Copy Markdown
Member Author

Does this work when there are more than 3 and it scrolls horizontally?

Yup yup, it does!

Screen.Recording.2024-04-12.at.9.51.52.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants