iOS append events to JSONL file and get diagnostics events#3781
Merged
vegaro merged 22 commits intoApr 8, 2024
Conversation
vegaro
commented
Apr 3, 2024
aboedo
reviewed
Apr 3, 2024
aboedo
reviewed
Apr 3, 2024
7cef309 to
40cac7e
Compare
tonidero
reviewed
Apr 4, 2024
tonidero
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me! Just left some comments. Only thing blocking I think is deciding the format for the timestamp property.
| await fileHandler.append(line: jsonString) | ||
| } | ||
|
|
||
| func getEntries() async -> [DiagnosticsEvent] { |
Contributor
There was a problem hiding this comment.
I think this should be fine, but note that it shouldn't be necessarily needed to parse the entries back to a list of DiagnosticsEntry. We just need a list of jsons to send in the backend request. But I don't think this should be a performance issue, so we can do this 👍
Member
Author
There was a problem hiding this comment.
I see! Just noticed Android is also returning a stream of jsons
aboedo
approved these changes
Apr 4, 2024
tonidero
approved these changes
Apr 4, 2024
This was referenced Apr 11, 2024
tonidero
pushed a commit
that referenced
this pull request
Apr 12, 2024
**This is an automatic release.** ### Bugfixes * Prevent Template 4 from wrapping Lifetime (#3789) via Josh Holtz (@joshdholtz) * Add enum entry for external purchases store (#3779) via Mark Villacampa (@MarkVillacampa) ### Dependency Updates * Bump fastlane from 2.219.0 to 2.220.0 (#3783) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Add option to intercept touch events in `PaywallViewController` (#3801) via Toni Rico (@tonidero) * Create DiagnosticsPostOperation (#3795) via Cesar de la Vega (@vegaro) * Add diagnosticsQueue to BackendConfiguration (#3794) via Cesar de la Vega (@vegaro) * Add origin to HTTPResponseType (#3793) via Cesar de la Vega (@vegaro) * Add name property to HTTPRequestPath (#3790) via Cesar de la Vega (@vegaro) * Add name to VerificationResult (#3792) via Cesar de la Vega (@vegaro) * Add HTTPRequest.DiagnosticsPath (#3791) via Cesar de la Vega (@vegaro) * Add async `syncAttributesAndOfferingsIfNeeded()` (#3785) via Josh Holtz (@joshdholtz) * iOS append events to JSONL file and get diagnostics events (#3781) via Cesar de la Vega (@vegaro) * Fix offerings integration test (#3782) via Josh Holtz (@joshdholtz)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off #2672
Equivalent to RevenueCat/purchases-android#784
Adds DiagnosticsEntry classes and implements adding an entry to the file, getting all entries, and deleting X first entries