PaywallEventStore: also remove legacy revenuecat documents directory#3317
Merged
Conversation
Fixes #3316. Follow up to #3289. That previous fix was only removing the store itself, but not the `revenuecat` folder. Running an app with 4.27.2 produces this: ```bash $ tree -L 3 ~/Library/Developer/CoreSimulator/Devices/.../data/Containers/Data/Application/.../ ~/Library/Developer/CoreSimulator/Devices/.../data/Containers/Data/Application/.../ ├── Documents │ └── revenuecat │ └── paywall_event_store ``` After this fix, the Documents directory is empty. ```bash tree -L 4 ~/Library/Developer/CoreSimulator/Devices/.../data/Containers/Data/Application/.../ /Users/ignacio/Library/Developer/CoreSimulator/Devices/.../data/Containers/Data/Application/.../ ├── Documents ├── Library │ ├── Application Support │ │ └── revenuecat │ │ └── paywall_event_store ```
12 tasks
NachoSoto
pushed a commit
that referenced
this pull request
Oct 18, 2023
**This is an automatic release.** ### Bugfixes * `PaywallEventStore`: also remove legacy `revenuecat` documents directory (#3317) via NachoSoto (@NachoSoto) ### Other Changes * `CI`: run all iOS 17 tests (#3312) via NachoSoto (@NachoSoto) * `StoreKit 2`: Optionally send JWS tokens instead of receipts to the backend (#3227) via Mark Villacampa (@MarkVillacampa) * `CircleCI`: update simulators for Xcode 15.0.1 (#3311) via NachoSoto (@NachoSoto) * `StoreKit 1`: improved debug log for `finishTransactions` invoked outside the SDK (#3300) via NachoSoto (@NachoSoto) * `Debug View`: display receipt status (#3303) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3316. Follow up to #3289.
That previous fix was only removing the store itself, but not the
revenuecatfolder.Running an app with 4.27.2 produces this:
After this fix, the Documents directory is empty.
tree -L 4 ~/Library/Developer/CoreSimulator/Devices/.../data/Containers/Data/Application/.../ /Users/ignacio/Library/Developer/CoreSimulator/Devices/.../data/Containers/Data/Application/.../ ├── Documents ├── Library │ ├── Application Support │ │ └── revenuecat │ │ └── paywall_event_storeThis is still covered by the same test introduced in #3289.