StoreKit 1: improved debug log for finishTransactions invoked outside the SDK#3300
Merged
Merged
Conversation
tonidero
approved these changes
Oct 16, 2023
NachoSoto
added a commit
that referenced
this pull request
Oct 17, 2023
Follow up to #3300. Thanks to @aboedo for pointing out that this should never be logged during observer mode because we'll never have completion blocks in that case. I still left the "no callbacks to notify" part because it's useful to verify that the SDK is ignoring the transaction notification, but removed the warning that won't be relevant in this case.
NachoSoto
added a commit
that referenced
this pull request
Oct 18, 2023
Follow up to #3300. Thanks to @aboedo for pointing out that this should never be logged during observer mode because we'll never have completion blocks in that case. I still left the "no callbacks to notify" part because it's useful to verify that the SDK is ignoring the transaction notification, but removed the warning that won't be relevant in this case.
NachoSoto
pushed a commit
that referenced
this pull request
Oct 18, 2023
**This is an automatic release.** ### Bugfixes * `PaywallEventStore`: also remove legacy `revenuecat` documents directory (#3317) via NachoSoto (@NachoSoto) ### Other Changes * `CI`: run all iOS 17 tests (#3312) via NachoSoto (@NachoSoto) * `StoreKit 2`: Optionally send JWS tokens instead of receipts to the backend (#3227) via Mark Villacampa (@MarkVillacampa) * `CircleCI`: update simulators for Xcode 15.0.1 (#3311) via NachoSoto (@NachoSoto) * `StoreKit 1`: improved debug log for `finishTransactions` invoked outside the SDK (#3300) via NachoSoto (@NachoSoto) * `Debug View`: display receipt status (#3303) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2415 (comment)
This should make it more obvious for anyone running into this issue.