CI: run all iOS 17 tests#3312
Merged
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
==========================================
- Coverage 85.92% 85.80% -0.12%
==========================================
Files 237 236 -1
Lines 17061 16891 -170
==========================================
- Hits 14660 14494 -166
+ Misses 2401 2397 -4 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Oct 17, 2023
Xcode 15.0.1 (#3311) fixed performance issues, so we should be able to run all tests on iOS 17.
bf26a41 to
e34d71b
Compare
Requested by @NachoSoto for [ios-17-all-tests](https://github.com/RevenueCat/purchases-ios/tree/ios-17-all-tests) Co-authored-by: distiller <distiller@distillers-Virtual-Machine.local>
NachoSoto
commented
Oct 17, 2023
| jobs: | ||
| - run-test-ios-17: | ||
| xcode_version: '15.0.0' | ||
| xcode_version: '15.0.1' |
Contributor
Author
There was a problem hiding this comment.
CircleCI initially shipped the update under Xcode 15.0.0, but now it's its own 15.0.1
NachoSoto
pushed a commit
that referenced
this pull request
Oct 18, 2023
**This is an automatic release.** ### Bugfixes * `PaywallEventStore`: also remove legacy `revenuecat` documents directory (#3317) via NachoSoto (@NachoSoto) ### Other Changes * `CI`: run all iOS 17 tests (#3312) via NachoSoto (@NachoSoto) * `StoreKit 2`: Optionally send JWS tokens instead of receipts to the backend (#3227) via Mark Villacampa (@MarkVillacampa) * `CircleCI`: update simulators for Xcode 15.0.1 (#3311) via NachoSoto (@NachoSoto) * `StoreKit 1`: improved debug log for `finishTransactions` invoked outside the SDK (#3300) via NachoSoto (@NachoSoto) * `Debug View`: display receipt status (#3303) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xcode 15.0.1 (#3311) fixed performance issues (partially), so we should be able to run all tests on iOS 17.
See https://discuss.circleci.com/t/severe-performance-problems-with-xcode-15/49205/65?u=nachosoto