Xcode 15: fix non-visionOS build by replacing .custom platform#3005
Merged
Conversation
…sion` Fixes #2998. This is now fixed in SPM: swiftlang/swift-package-manager#6794, but we need a workaround for now. Since `.custom` doesn't work properly, this splits `Package.swift` based on Xcode version.
NachoSoto
commented
Aug 11, 2023
| .tvOS(.v11), | ||
| .iOS(.v11) | ||
| .iOS(.v11), | ||
| .visionOS(.v1) |
Contributor
Author
There was a problem hiding this comment.
An advantage of this is being able to define this too, even though for some reason it's not actually required.
Codecov Report
@@ Coverage Diff @@
## main #3005 +/- ##
==========================================
- Coverage 86.66% 86.61% -0.06%
==========================================
Files 219 219
Lines 15619 15619
==========================================
- Hits 13536 13528 -8
- Misses 2083 2091 +8 |
tonidero
approved these changes
Aug 11, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Not very familiar with this, but makes sense 🚢
aboedo
reviewed
Aug 11, 2023
| @@ -0,0 +1,56 @@ | |||
| // swift-tools-version:5.8 | |||
Contributor
Author
There was a problem hiding this comment.
Just added a separate Package@swift-5.7.swift to keep Xcode 14.1 compatibility (the min to submit to the App Store), and added a CI job to verify that.
NachoSoto
added a commit
that referenced
this pull request
Aug 11, 2023
_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_ ### Bugfixes * `Xcode 15`: fix non-`visionOS` build by replacing `.custom` platform (#3005) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: test for `SignatureVerificationMode.informational` and receipt posting when fetching `CustomerInfo` (#3000) via NachoSoto (@NachoSoto) * `Custom Entitlement Computation`: fixed `visionOS` build (#2999) via NachoSoto (@NachoSoto) * `HTTPClient`: extracted `HTTPRequestPath` protocol (#2986) via NachoSoto (@NachoSoto) * `CI`: add `visionOS` build (#2990) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
…3005) Fixes #2998. See #2989 for why this is needed in the first place. This is now fixed in SPM: swiftlang/swift-package-manager#6794, but we need a workaround for now. Since `.custom` doesn't work properly (it gets evaluated in Xcode even outside of that platform), this splits `Package.swift` based on Xcode version. Thanks @neonichu for helping with this.
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_ ### Bugfixes * `Xcode 15`: fix non-`visionOS` build by replacing `.custom` platform (#3005) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: test for `SignatureVerificationMode.informational` and receipt posting when fetching `CustomerInfo` (#3000) via NachoSoto (@NachoSoto) * `Custom Entitlement Computation`: fixed `visionOS` build (#2999) via NachoSoto (@NachoSoto) * `HTTPClient`: extracted `HTTPRequestPath` protocol (#2986) via NachoSoto (@NachoSoto) * `CI`: add `visionOS` build (#2990) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2998. See #2989 for why this is needed in the first place.
This is now fixed in SPM: swiftlang/swift-package-manager#6794, but we need a workaround for now.
Since
.customdoesn't work properly (it gets evaluated in Xcode even outside of that platform), this splitsPackage.swiftbased on Xcode version.Thanks @neonichu for helping with this.