HTTPClient: extracted HTTPRequestPath protocol#2986
Merged
NachoSoto merged 4 commits intoAug 10, 2023
Merged
Conversation
NachoSoto
commented
Aug 8, 2023
NachoSoto
commented
Aug 8, 2023
Contributor
Author
There was a problem hiding this comment.
It is now trivial to add a second enum for the new endpoints, which can be passed to HTTPClient and it'll make a request to the right place.
That way it will be impossible to make requests to the new server for paths that shouldn't go there.
5c5cc9f to
6302bd4
Compare
36f6942 to
377711d
Compare
This paves the way to add a second set of paths with a separate server URL to be able to shed requests to offerings and product entitlement mapping to a separate server. ### Changes: - New `HTTPRequestPath` with the same properties as `HTTPRequest.Path` + a new `serverHostURL` - Moved proxy logic from `SystemInfo`/`HTTPClient` to `HTTPRequestPath` - Simplified `HTTPRequest` implementation
377711d to
cdbb2bb
Compare
cdbb2bb to
2d226d7
Compare
02d6508 to
3d2add4
Compare
NachoSoto
added a commit
that referenced
this pull request
Aug 11, 2023
_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_ ### Bugfixes * `Xcode 15`: fix non-`visionOS` build by replacing `.custom` platform (#3005) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: test for `SignatureVerificationMode.informational` and receipt posting when fetching `CustomerInfo` (#3000) via NachoSoto (@NachoSoto) * `Custom Entitlement Computation`: fixed `visionOS` build (#2999) via NachoSoto (@NachoSoto) * `HTTPClient`: extracted `HTTPRequestPath` protocol (#2986) via NachoSoto (@NachoSoto) * `CI`: add `visionOS` build (#2990) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
This paves the way to add a second set of paths with a separate server URL to be able to shed requests to offerings and product entitlement mapping to a separate server. ### Changes: - New `HTTPRequestPath` with the same properties as `HTTPRequest.Path` + a new `serverHostURL` - Moved proxy logic from `SystemInfo`/`HTTPClient` to `HTTPRequestPath` - Simplified `HTTPRequest` implementation
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_ ### Bugfixes * `Xcode 15`: fix non-`visionOS` build by replacing `.custom` platform (#3005) via NachoSoto (@NachoSoto) ### Other Changes * `Integration Tests`: test for `SignatureVerificationMode.informational` and receipt posting when fetching `CustomerInfo` (#3000) via NachoSoto (@NachoSoto) * `Custom Entitlement Computation`: fixed `visionOS` build (#2999) via NachoSoto (@NachoSoto) * `HTTPClient`: extracted `HTTPRequestPath` protocol (#2986) via NachoSoto (@NachoSoto) * `CI`: add `visionOS` build (#2990) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This paves the way to add a second set of paths with a separate server URL to be able to shed requests to offerings and product entitlement mapping to a separate server.
Changes:
HTTPRequestPathwith the same properties asHTTPRequest.Path+ a newserverHostURLSystemInfo/HTTPClienttoHTTPRequestPathHTTPRequestimplementation