Skip to content

CI: add visionOS build#2990

Merged
NachoSoto merged 2 commits into
mainfrom
vision-os-ci
Aug 10, 2023
Merged

CI: add visionOS build#2990
NachoSoto merged 2 commits into
mainfrom
vision-os-ci

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

No description provided.

@NachoSoto NachoSoto added the ci label Aug 8, 2023
@NachoSoto NachoSoto requested a review from a team August 8, 2023 22:46
@codecov

codecov Bot commented Aug 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2990 (b1c44c8) into visionos-beta-3 (b1c44c8) will not change coverage.
The diff coverage is n/a.

❗ Current head b1c44c8 differs from pull request most recent head e610385. Consider uploading reports for the commit e610385 to get more accurate results

@@               Coverage Diff                @@
##           visionos-beta-3    #2990   +/-   ##
================================================
  Coverage            86.70%   86.70%           
================================================
  Files                  218      218           
  Lines                15617    15617           
================================================
  Hits                 13540    13540           
  Misses                2077     2077           

@NachoSoto NachoSoto changed the title CI: add visionOS tests CI: add visionOS build Aug 9, 2023
@NachoSoto NachoSoto force-pushed the visionos-beta-3 branch 2 times, most recently from 735f9b1 to bee593d Compare August 9, 2023 00:28
@NachoSoto

Copy link
Copy Markdown
Contributor Author

I think we need to wait on CircleCI to update to Beta 6.

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Once circleci updates :shipit:

@NachoSoto

Copy link
Copy Markdown
Contributor Author

Forgot to mention that I'm only building and not running tests because Nimble doesn't support visionOS and we can't update it without losing iOS 11 support.

Base automatically changed from visionos-beta-3 to main August 9, 2023 18:19
@NachoSoto NachoSoto enabled auto-merge (squash) August 10, 2023 04:09
@NachoSoto NachoSoto disabled auto-merge August 10, 2023 04:17
@NachoSoto NachoSoto enabled auto-merge (squash) August 10, 2023 04:19
@NachoSoto NachoSoto merged commit 9f72600 into main Aug 10, 2023
@NachoSoto NachoSoto deleted the vision-os-ci branch August 10, 2023 04:19
NachoSoto added a commit that referenced this pull request Aug 11, 2023
_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_

### Bugfixes
* `Xcode 15`: fix non-`visionOS` build by replacing `.custom` platform
(#3005) via NachoSoto (@NachoSoto)
### Other Changes
* `Integration Tests`: test for
`SignatureVerificationMode.informational` and receipt posting when
fetching `CustomerInfo` (#3000) via NachoSoto (@NachoSoto)
* `Custom Entitlement Computation`: fixed `visionOS` build (#2999) via
NachoSoto (@NachoSoto)
* `HTTPClient`: extracted `HTTPRequestPath` protocol (#2986) via
NachoSoto (@NachoSoto)
* `CI`: add `visionOS` build (#2990) via NachoSoto (@NachoSoto)

---------

Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
_This release is compatible with Xcode 15 beta 6 and visionOS beta 3_

### Bugfixes
* `Xcode 15`: fix non-`visionOS` build by replacing `.custom` platform
(#3005) via NachoSoto (@NachoSoto)
### Other Changes
* `Integration Tests`: test for
`SignatureVerificationMode.informational` and receipt posting when
fetching `CustomerInfo` (#3000) via NachoSoto (@NachoSoto)
* `Custom Entitlement Computation`: fixed `visionOS` build (#2999) via
NachoSoto (@NachoSoto)
* `HTTPClient`: extracted `HTTPRequestPath` protocol (#2986) via
NachoSoto (@NachoSoto)
* `CI`: add `visionOS` build (#2990) via NachoSoto (@NachoSoto)

---------

Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants