Signing: inject ClockType to ensure hardcoded signatures don't fail when intermediate key expires#2771
Merged
Merged
Conversation
…il when intermediate key expires Thanks to @aboedo for catching this and providing this simple idea.
tonidero
reviewed
Jul 10, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
FWIW, What I did was adding a day very far into the future (Year 2106) in Android for the unit tests. But this also works 👍
Member
Some poor dev is going to really hate you in 2107 |
aboedo
approved these changes
Jul 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #2771 +/- ##
==========================================
- Coverage 86.49% 86.49% -0.01%
==========================================
Files 214 214
Lines 15376 15379 +3
==========================================
+ Hits 13300 13302 +2
- Misses 2076 2077 +1
|
This was referenced Jul 11, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 11, 2023
**This is an automatic release.** ### New Features * `Trusted Entitlements`: (#2621) via NachoSoto (@NachoSoto) This new feature prevents MitM attacks between the SDK and the RevenueCat server. With verification enabled, the SDK ensures that the response created by the server was not modified by a third-party, and the entitlements received are exactly what was sent. This is 100% opt-in. `EntitlementInfos` have a new `VerificationResult` property, which will indicate the validity of the responses when this feature is enabled. ```swift let purchases = Purchases.configure( with: Configuration .builder(withAPIKey: "") .with(entitlementVerificationMode: .informational) ) let customerInfo = try await purchases.customerInfo() if !customerInfo.entitlements.verification.isVerified { print("Entitlements could not be verified") } ``` You can learn more from [the documentation](https://www.revenuecat.com/docs/trusted-entitlements). ### Other Changes * `TrustedEntitlements`: new `VerificationResult.isVerified` (#2788) via NachoSoto (@NachoSoto) * `Refactor`: extracted `Collection.subscript(safe:)` (#2779) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: added link to docs in `ErrorCode.signatureVerificationFailed` (#2783) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: improved documentation (#2782) via NachoSoto (@NachoSoto) * `Tests`: fixed flaky failure with asynchronous check (#2777) via NachoSoto (@NachoSoto) * `Integration Tests`: re-enable signature verification tests (#2744) via NachoSoto (@NachoSoto) * `CI`: remove `Jazzy` (#2775) via NachoSoto (@NachoSoto) * `Signing`: inject `ClockType` to ensure hardcoded signatures don't fail when intermediate key expires (#2771) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @aboedo for catching this and providing this simple idea.