Trusted Entitlements: re-enable public API#2621
Merged
Merged
Conversation
367da2d to
509e3a9
Compare
Entitlement VericicationEntitlement Verification
157cb14 to
f056004
Compare
Entitlement VerificationEntitlement Verification public API
f8592f5 to
a36c254
Compare
Codecov Report
@@ Coverage Diff @@
## main #2621 +/- ##
==========================================
+ Coverage 86.30% 86.49% +0.18%
==========================================
Files 214 214
Lines 15376 15376
==========================================
+ Hits 13271 13299 +28
+ Misses 2105 2077 -28
|
Entitlement Verification public APITrusted Entitlements: re-enable public API
813db34 to
7db168a
Compare
249d5fe to
ea3f6d7
Compare
ea3f6d7 to
bc21a0e
Compare
Trusted Entitlements: re-enable public APITrusted Entitlements: re-enable public API
3a28743 to
68f6db7
Compare
tonidero
reviewed
Jul 10, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a comment about the enforced mode
0207281 to
e5141e2
Compare
e5141e2 to
a587d67
Compare
Contributor
Author
|
Holding off until we verify #2744 is all green. |
tonidero
approved these changes
Jul 11, 2023
This was referenced Jul 11, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 11, 2023
**This is an automatic release.** ### New Features * `Trusted Entitlements`: (#2621) via NachoSoto (@NachoSoto) This new feature prevents MitM attacks between the SDK and the RevenueCat server. With verification enabled, the SDK ensures that the response created by the server was not modified by a third-party, and the entitlements received are exactly what was sent. This is 100% opt-in. `EntitlementInfos` have a new `VerificationResult` property, which will indicate the validity of the responses when this feature is enabled. ```swift let purchases = Purchases.configure( with: Configuration .builder(withAPIKey: "") .with(entitlementVerificationMode: .informational) ) let customerInfo = try await purchases.customerInfo() if !customerInfo.entitlements.verification.isVerified { print("Entitlements could not be verified") } ``` You can learn more from [the documentation](https://www.revenuecat.com/docs/trusted-entitlements). ### Other Changes * `TrustedEntitlements`: new `VerificationResult.isVerified` (#2788) via NachoSoto (@NachoSoto) * `Refactor`: extracted `Collection.subscript(safe:)` (#2779) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: added link to docs in `ErrorCode.signatureVerificationFailed` (#2783) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: improved documentation (#2782) via NachoSoto (@NachoSoto) * `Tests`: fixed flaky failure with asynchronous check (#2777) via NachoSoto (@NachoSoto) * `Integration Tests`: re-enable signature verification tests (#2744) via NachoSoto (@NachoSoto) * `CI`: remove `Jazzy` (#2775) via NachoSoto (@NachoSoto) * `Signing`: inject `ClockType` to ensure hardcoded signatures don't fail when intermediate key expires (#2771) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
tonidero
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Nov 17, 2023
) Depends on RevenueCat/purchases-ios#2621 and RevenueCat/purchases-android#1105. --------- Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is reverting #2350 and #2417