Skip to content

Integration Tests: re-enable signature verification tests#2744

Merged
NachoSoto merged 1 commit into
mainfrom
nacho/re-enable-signature-integration-tests
Jul 11, 2023
Merged

Integration Tests: re-enable signature verification tests#2744
NachoSoto merged 1 commit into
mainfrom
nacho/re-enable-signature-integration-tests

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

@NachoSoto NachoSoto added the test label Jun 30, 2023
@NachoSoto NachoSoto requested a review from a team June 30, 2023 17:02
@NachoSoto NachoSoto force-pushed the nacho/re-enable-signature-integration-tests branch 3 times, most recently from 19fef6e to 3e41ce0 Compare June 30, 2023 18:11
@NachoSoto NachoSoto force-pushed the nacho/verify-intermediate-key branch 2 times, most recently from fcbc752 to bef3bef Compare June 30, 2023 19:30
Base automatically changed from nacho/verify-intermediate-key to main June 30, 2023 19:44
@NachoSoto NachoSoto force-pushed the nacho/re-enable-signature-integration-tests branch from 3e41ce0 to b0d9a6d Compare June 30, 2023 20:03
@NachoSoto NachoSoto marked this pull request as ready for review June 30, 2023 20:04
@NachoSoto NachoSoto force-pushed the nacho/re-enable-signature-integration-tests branch from b0d9a6d to 0b5e29c Compare July 6, 2023 00:00
NachoSoto added a commit that referenced this pull request Jul 6, 2023
…abled

Signature verification is not working due to changing signature (see #2744), but the debug screen shouldn't show an error if verification isn't enabled.
NachoSoto added a commit that referenced this pull request Jul 6, 2023
This will be re-enabled in #2744
NachoSoto added a commit that referenced this pull request Jul 6, 2023
…abled (#2757)

Signature verification is not working due to changing signature (see
#2744), but the debug screen shouldn't show an error if verification
isn't enabled.
@NachoSoto NachoSoto force-pushed the nacho/re-enable-signature-integration-tests branch 2 times, most recently from 1b52ba0 to 2c89530 Compare July 7, 2023 04:23
@NachoSoto NachoSoto changed the base branch from main to nacho/signing-no-api-key July 7, 2023 04:23
@NachoSoto NachoSoto force-pushed the nacho/re-enable-signature-integration-tests branch from 2c89530 to c71a5ea Compare July 7, 2023 04:25
Base automatically changed from nacho/signing-no-api-key to main July 7, 2023 15:23
@NachoSoto NachoSoto force-pushed the nacho/re-enable-signature-integration-tests branch from c71a5ea to 49518f2 Compare July 10, 2023 14:05
@NachoSoto

Copy link
Copy Markdown
Contributor Author

They passed! 🎉

@NachoSoto NachoSoto merged commit 969cf84 into main Jul 11, 2023
@NachoSoto NachoSoto deleted the nacho/re-enable-signature-integration-tests branch July 11, 2023 14:28
NachoSoto added a commit that referenced this pull request Jul 11, 2023
**This is an automatic release.**

### New Features
* `Trusted Entitlements`: (#2621) via NachoSoto (@NachoSoto)

This new feature prevents MitM attacks between the SDK and the
RevenueCat server.
With verification enabled, the SDK ensures that the response created by
the server was not modified by a third-party, and the entitlements
received are exactly what was sent.
This is 100% opt-in. `EntitlementInfos` have a new `VerificationResult`
property, which will indicate the validity of the responses when this
feature is enabled.

```swift
let purchases = Purchases.configure(
  with: Configuration
    .builder(withAPIKey: "")
    .with(entitlementVerificationMode: .informational)
)
let customerInfo = try await purchases.customerInfo()
if !customerInfo.entitlements.verification.isVerified {
  print("Entitlements could not be verified")
}
```

You can learn more from [the
documentation](https://www.revenuecat.com/docs/trusted-entitlements).

### Other Changes
* `TrustedEntitlements`: new `VerificationResult.isVerified` (#2788) via
NachoSoto (@NachoSoto)
* `Refactor`: extracted `Collection.subscript(safe:)` (#2779) via
NachoSoto (@NachoSoto)
* `Trusted Entitlements`: added link to docs in
`ErrorCode.signatureVerificationFailed` (#2783) via NachoSoto
(@NachoSoto)
* `Trusted Entitlements`: improved documentation (#2782) via NachoSoto
(@NachoSoto)
* `Tests`: fixed flaky failure with asynchronous check (#2777) via
NachoSoto (@NachoSoto)
* `Integration Tests`: re-enable signature verification tests (#2744)
via NachoSoto (@NachoSoto)
* `CI`: remove `Jazzy` (#2775) via NachoSoto (@NachoSoto)
* `Signing`: inject `ClockType` to ensure hardcoded signatures don't
fail when intermediate key expires (#2771) via NachoSoto (@NachoSoto)

---------

Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants