Skip to content

Add Data.sha1#2696

Merged
NachoSoto merged 1 commit into
mainfrom
data-sha1
Jun 23, 2023
Merged

Add Data.sha1#2696
NachoSoto merged 1 commit into
mainfrom
data-sha1

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

This also refactors the implementation to be able to share the same code.

This algorithm will be used for some of the components in the new signatures.

@NachoSoto NachoSoto requested a review from a team June 22, 2023 19:50
@codecov

codecov Bot commented Jun 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2696 (479b8d3) into main (984b231) will decrease coverage by 0.04%.
The diff coverage is 56.41%.

❗ Current head 479b8d3 differs from pull request most recent head 90a2bcd. Consider uploading reports for the commit 90a2bcd to get more accurate results

@@            Coverage Diff             @@
##             main    #2696      +/-   ##
==========================================
- Coverage   86.58%   86.55%   -0.04%     
==========================================
  Files         211      209       -2     
  Lines       14987    14848     -139     
==========================================
- Hits        12976    12851     -125     
+ Misses       2011     1997      -14     
Impacted Files Coverage Δ
Sources/FoundationExtensions/Data+Extensions.swift 71.42% <56.41%> (-7.30%) ⬇️

... and 10 files with indirect coverage changes

Base automatically changed from data-as-string-refactor to main June 23, 2023 14:31
This also refactors the implementation to be able to share the same code
@NachoSoto NachoSoto enabled auto-merge (squash) June 23, 2023 15:41
@NachoSoto NachoSoto merged commit ed8d79d into main Jun 23, 2023
@NachoSoto NachoSoto deleted the data-sha1 branch June 23, 2023 17:45
tonidero pushed a commit that referenced this pull request Jun 26, 2023
**This is an automatic release.**

### Bugfixes
* Fix google play purchases missing purchase date (#2703) via Toni Rico
(@tonidero)
### Other Changes
* `PurchaseTester`: fixed `watchOS` build and ASC deployment (#2701) via
NachoSoto (@NachoSoto)
* Add `Data.sha1` (#2696) via NachoSoto (@NachoSoto)
* Refactor: extract `ErrorResponse` into its own file (#2697) via
NachoSoto (@NachoSoto)
* Add `Sequence<AdditiveArithmetic>.sum()` (#2694) via NachoSoto
(@NachoSoto)
* Refactored `Data.asString` implementation (#2695) via NachoSoto
(@NachoSoto)
* `Diagnostics`: new `FileHandler` for abstracting file operations
(#2673) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants