Diagnostics: new FileHandler for abstracting file operations#2673
Merged
Conversation
ffd0d4e to
c45de52
Compare
NachoSoto
commented
Jun 16, 2023
Contributor
Author
There was a problem hiding this comment.
This implementation avoids loading the entire file in memory.
c45de52 to
07d6d75
Compare
tonidero
approved these changes
Jun 19, 2023
| throw Error.failedMovingNewFile(from: otherURL, toURL: self.url, error) | ||
| } | ||
|
|
||
| self.fileHandle.closeAndLogErrors() |
Contributor
There was a problem hiding this comment.
So closing the fileHandle AFTER we've removed the original item won't be a problem? I'd imagine we would need to close it before deleting the file but I might be wrong.
Contributor
Author
There was a problem hiding this comment.
This is basically just a file descriptor inside. I did this after moving it because we don't want to leave an inconsistent state if any of the move operations fail.
| return result | ||
| } | ||
|
|
||
| func replaceHandler(with otherURL: URL) throws { |
Contributor
There was a problem hiding this comment.
I wonder if this function should be executed atomically, so if there are multiple threads using this handler, this doesn't cause any issues (We don't do this in Android either)
Contributor
Author
There was a problem hiding this comment.
That's handled by the fact that this type is an actor :)
https://www.swiftbysundell.com/articles/swift-actors/
| await self.handler.append(line: content) | ||
|
|
||
| let data = try await self.handler.readFile() | ||
| expect(data).to(matchLines(content)) |
Contributor
There was a problem hiding this comment.
Should we have a test making sure the file ends with a new line break?
Contributor
Author
There was a problem hiding this comment.
I thought it wasn't that important to add an explicit test, as long as the other logic works as expected (appending an existing file, etc). What do you think?
07d6d75 to
8a69cf4
Compare
tonidero
pushed a commit
that referenced
this pull request
Jun 26, 2023
**This is an automatic release.** ### Bugfixes * Fix google play purchases missing purchase date (#2703) via Toni Rico (@tonidero) ### Other Changes * `PurchaseTester`: fixed `watchOS` build and ASC deployment (#2701) via NachoSoto (@NachoSoto) * Add `Data.sha1` (#2696) via NachoSoto (@NachoSoto) * Refactor: extract `ErrorResponse` into its own file (#2697) via NachoSoto (@NachoSoto) * Add `Sequence<AdditiveArithmetic>.sum()` (#2694) via NachoSoto (@NachoSoto) * Refactored `Data.asString` implementation (#2695) via NachoSoto (@NachoSoto) * `Diagnostics`: new `FileHandler` for abstracting file operations (#2673) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
that referenced
this pull request
Sep 6, 2023
- New `PaywallEventStore` using `FileHandler` (#2673) - `MockFileHandler` - `PaywallStoredEvent`: this contains the necessary information to store an event: `PaywallEvent` + user ID - `Created PaywallEventSerializer`
NachoSoto
added a commit
that referenced
this pull request
Sep 6, 2023
- New `PaywallEventStore` using `FileHandler` (#2673) - `MockFileHandler` - `PaywallStoredEvent`: this contains the necessary information to store an event: `PaywallEvent` + user ID - `Created PaywallEventSerializer`
NachoSoto
added a commit
that referenced
this pull request
Sep 7, 2023
- New `PaywallEventStore` using `FileHandler` (#2673) - `MockFileHandler` - `PaywallStoredEvent`: this contains the necessary information to store an event: `PaywallEvent` + user ID - `Created PaywallEventSerializer`
NachoSoto
added a commit
that referenced
this pull request
Sep 7, 2023
- New `PaywallEventStore` using `FileHandler` (#2673) - `MockFileHandler` - `PaywallStoredEvent`: this contains the necessary information to store an event: `PaywallEvent` + user ID - `Created PaywallEventSerializer`
NachoSoto
added a commit
that referenced
this pull request
Sep 7, 2023
- New `PaywallEventStore` using `FileHandler` (#2673) - `MockFileHandler` - `PaywallStoredEvent`: this contains the necessary information to store an event: `PaywallEvent` + user ID - `Created PaywallEventSerializer`
NachoSoto
added a commit
that referenced
this pull request
Sep 7, 2023
- New `PaywallEventStore` using `FileHandler` (#2673) - `MockFileHandler` - `PaywallStoredEvent`: this contains the necessary information to store an event: `PaywallEvent` + user ID - `Created PaywallEventSerializer`
NachoSoto
added a commit
that referenced
this pull request
Sep 7, 2023
- New `PaywallEventStore` using `FileHandler` (#2673) - `MockFileHandler` - `PaywallStoredEvent`: this contains the necessary information to store an event: `PaywallEvent` + user ID - `Created PaywallEventSerializer`
NachoSoto
added a commit
that referenced
this pull request
Sep 7, 2023
NachoSoto
added a commit
that referenced
this pull request
Sep 8, 2023
NachoSoto
added a commit
that referenced
this pull request
Sep 14, 2023
NachoSoto
added a commit
that referenced
this pull request
Sep 14, 2023
NachoSoto
added a commit
that referenced
this pull request
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented as an
actorto easily synchronize operations on a file.Simple interface:
