Refactored Data.asString implementation#2695
Merged
Merged
Conversation
This was duplicated with the `hexString` implementation, which is also memory efficient. Also renamed the file and removed any unnecessary references to `NSData`
Codecov Report
@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
- Coverage 86.60% 86.59% -0.01%
==========================================
Files 209 209
Lines 14833 14825 -8
==========================================
- Hits 12846 12838 -8
Misses 1987 1987
|
tonidero
approved these changes
Jun 23, 2023
tonidero
pushed a commit
that referenced
this pull request
Jun 26, 2023
**This is an automatic release.** ### Bugfixes * Fix google play purchases missing purchase date (#2703) via Toni Rico (@tonidero) ### Other Changes * `PurchaseTester`: fixed `watchOS` build and ASC deployment (#2701) via NachoSoto (@NachoSoto) * Add `Data.sha1` (#2696) via NachoSoto (@NachoSoto) * Refactor: extract `ErrorResponse` into its own file (#2697) via NachoSoto (@NachoSoto) * Add `Sequence<AdditiveArithmetic>.sum()` (#2694) via NachoSoto (@NachoSoto) * Refactored `Data.asString` implementation (#2695) via NachoSoto (@NachoSoto) * `Diagnostics`: new `FileHandler` for abstracting file operations (#2673) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was duplicated with the
hexStringimplementation, which is also memory efficient.This also renames the file and removes any unnecessary references to
NSData