xrOS: fixed compilation by disabling debug overlay#2681
Merged
Conversation
3 tasks
2e046bb to
86812b6
Compare
Codecov Report
@@ Coverage Diff @@
## main #2681 +/- ##
==========================================
- Coverage 86.56% 86.52% -0.05%
==========================================
Files 209 208 -1
Lines 14833 14801 -32
==========================================
- Hits 12840 12806 -34
- Misses 1993 1995 +2
|
tonidero
reviewed
Jun 22, 2023
Contributor
There was a problem hiding this comment.
Hmm can it be xrOS after the previous line ((os(iOS) || os(macOS))? Same in the other places in this file
Member
There was a problem hiding this comment.
I think os(xrOS) is only available in swift(>=5.9) so that would mean this code would not compile in Xcode 14 (@NachoSoto correct me if I'm wrong)
Contributor
Author
There was a problem hiding this comment.
That’s correct, and short-circuiting doesn’t work in Xcode 13
MarkVillacampa
approved these changes
Jun 22, 2023
tonidero
approved these changes
Jun 22, 2023
2d6a553 to
653d6e5
Compare
653d6e5 to
c11dbcf
Compare
NachoSoto
pushed a commit
that referenced
this pull request
Jun 22, 2023
**This is an automatic release.** _This release is compatible with `Xcode 15 beta 2` and `visionOS beta 1`_ ### New Features * `xrOS`: added to list of supported platforms (#2682) via NachoSoto (@NachoSoto) ### Bugfixes * `xrOS`: fixed compilation by disabling debug overlay (#2681) via NachoSoto (@NachoSoto) * `xrOS`: added support for new `purchase(confirmIn:options:)` method (#2683) via NachoSoto (@NachoSoto) * `Xcode 15`: handle `Locale.currencyCode` deprecation (#2680) via NachoSoto (@NachoSoto) ### Other Changes * `PurchaseTester`: fixed release compilation (#2689) via NachoSoto (@NachoSoto) * `xrOS`: fixed runtime warning (#2691) via NachoSoto (@NachoSoto) * `xrOS`: added support to `PurchaseTester` (#2685) via NachoSoto (@NachoSoto) * `Signature Verification`: new `Integration Tests` (#2642) via NachoSoto (@NachoSoto) * `ErrorUtils`: handle `PurchasesError` to avoid creating unknown errors (#2686) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can look into making them work in the future, but for now this helps compile the SDK for
xrOS.