Skip to content

Signature Verification: new Integration Tests#2642

Merged
NachoSoto merged 5 commits into
mainfrom
nacho/sdk-3181-add-forceverificationerrors-dangerous-setting-for
Jun 22, 2023
Merged

Signature Verification: new Integration Tests#2642
NachoSoto merged 5 commits into
mainfrom
nacho/sdk-3181-add-forceverificationerrors-dangerous-setting-for

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@NachoSoto NachoSoto added the test label Jun 13, 2023
@NachoSoto NachoSoto requested a review from a team June 13, 2023 18:48
Base automatically changed from force-signature-failures to main June 13, 2023 20:43
@NachoSoto NachoSoto changed the title Signature Verification: new Integration Tests [WIP] Signature Verification: new Integration Tests Jun 13, 2023
@NachoSoto NachoSoto force-pushed the nacho/sdk-3181-add-forceverificationerrors-dangerous-setting-for branch from 4b04d25 to 368fb02 Compare June 15, 2023 17:28
@NachoSoto NachoSoto force-pushed the nacho/sdk-3181-add-forceverificationerrors-dangerous-setting-for branch 3 times, most recently from 5a83bc2 to cc80e6c Compare June 16, 2023 17:44
@NachoSoto NachoSoto changed the title [WIP] Signature Verification: new Integration Tests Signature Verification: new Integration Tests Jun 16, 2023
@NachoSoto NachoSoto marked this pull request as ready for review June 16, 2023 17:46
@RevenueCat RevenueCat deleted a comment from codecov Bot Jun 16, 2023
@RevenueCat RevenueCat deleted a comment from codecov Bot Jun 16, 2023
@codecov

codecov Bot commented Jun 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2642 (ad8382d) into main (a1481e6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   86.52%   86.50%   -0.03%     
==========================================
  Files         208      208              
  Lines       14794    14794              
==========================================
- Hits        12801    12797       -4     
- Misses       1993     1997       +4     

see 2 files with indirect coverage changes

@NachoSoto NachoSoto force-pushed the nacho/sdk-3181-add-forceverificationerrors-dangerous-setting-for branch from fc591c4 to 16f9833 Compare June 20, 2023 17:08
@NachoSoto NachoSoto force-pushed the nacho/sdk-3181-add-forceverificationerrors-dangerous-setting-for branch from 16f9833 to ad8382d Compare June 20, 2023 22:30
@NachoSoto

Copy link
Copy Markdown
Contributor Author

Bump @RevenueCat/coresdk

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

@NachoSoto NachoSoto merged commit 7a07b3f into main Jun 22, 2023
@NachoSoto NachoSoto deleted the nacho/sdk-3181-add-forceverificationerrors-dangerous-setting-for branch June 22, 2023 13:54
NachoSoto pushed a commit that referenced this pull request Jun 22, 2023
**This is an automatic release.**

_This release is compatible with `Xcode 15 beta 2` and `visionOS beta
1`_

### New Features
* `xrOS`: added to list of supported platforms (#2682) via NachoSoto
(@NachoSoto)
### Bugfixes
* `xrOS`: fixed compilation by disabling debug overlay (#2681) via
NachoSoto (@NachoSoto)
* `xrOS`: added support for new `purchase(confirmIn:options:)` method
(#2683) via NachoSoto (@NachoSoto)
* `Xcode 15`: handle `Locale.currencyCode` deprecation (#2680) via
NachoSoto (@NachoSoto)
### Other Changes
* `PurchaseTester`: fixed release compilation (#2689) via NachoSoto
(@NachoSoto)
* `xrOS`: fixed runtime warning (#2691) via NachoSoto (@NachoSoto)
* `xrOS`: added support to `PurchaseTester` (#2685) via NachoSoto
(@NachoSoto)
* `Signature Verification`: new `Integration Tests` (#2642) via
NachoSoto (@NachoSoto)
* `ErrorUtils`: handle `PurchasesError` to avoid creating unknown errors
(#2686) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants