Skip to content

[AUTOMATIC] Release/4.23.0#2692

Merged
NachoSoto merged 1 commit into
mainfrom
release/4.23.0
Jun 22, 2023
Merged

[AUTOMATIC] Release/4.23.0#2692
NachoSoto merged 1 commit into
mainfrom
release/4.23.0

Conversation

@RCGitBot

@RCGitBot RCGitBot commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

This is an automatic release.

This release is compatible with Xcode 15 beta 2 and visionOS beta 1

New Features

Bugfixes

Other Changes

@RCGitBot RCGitBot requested a review from a team June 22, 2023 16:06
@codecov

codecov Bot commented Jun 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2692 (8d7276d) into main (28bf4ce) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   86.60%   86.58%   -0.03%     
==========================================
  Files         209      209              
  Lines       14833    14833              
==========================================
- Hits        12846    12843       -3     
- Misses       1987     1990       +3     
Impacted Files Coverage Δ
Sources/Misc/SystemInfo.swift 98.38% <100.00%> (ø)

... and 1 file with indirect coverage changes

@NachoSoto

Copy link
Copy Markdown
Contributor

I broke watchOS on PurchaseTester, I'll fix it.

@NachoSoto NachoSoto enabled auto-merge (squash) June 22, 2023 17:53
@NachoSoto NachoSoto merged commit e99a821 into main Jun 22, 2023
@NachoSoto NachoSoto deleted the release/4.23.0 branch June 22, 2023 17:53
@abbana

abbana commented Jul 10, 2023

Copy link
Copy Markdown

[!] The platform of the target `` (visionOS 1.0) is not compatible with RevenueCat (4.23.1), which does not support `visionOS`.

I think you should add visionos as named in cocoapods upcoming 1.13 release CocoaPods/CocoaPods#11961

@NachoSoto

Copy link
Copy Markdown
Contributor

Thanks! We'll keep an eye on that CocoaPods release and add support for visionOS when that's out.

@abbana

abbana commented Jul 11, 2023

Copy link
Copy Markdown

Hi @NachoSoto can you please do it ASAP so I can port my app and having the users ready to make purchases from early 2024? CocoaPods next offifical release will be out too late for me to have that done on time.
Thanks.

@NachoSoto

Copy link
Copy Markdown
Contributor

Are you using a manual build of CocoaPods?

Alternatively you could use SPM for RevenueCat.

@abbana

abbana commented Jul 11, 2023

Copy link
Copy Markdown

Using commits from PR

gem 'cocoapods', git: 'https://github.com/CocoaPods/CocoaPods', ref: '400f290cb9269ea342948f629525a5542933627f'
gem 'cocoapods-core', git: 'https://github.com/CocoaPods/Core', ref: '9320bf557741d7ae80eda4415bc6fb2b0b3a8b9c'

see CocoaPods/CocoaPods#11961

@NachoSoto

Copy link
Copy Markdown
Contributor

We can look into it, but do you happen to know if releasing a Pod with visionos would break anyone using it with the latest release of CocoaPods?

@abbana

abbana commented Jul 11, 2023

Copy link
Copy Markdown

That would be helpfult, thanks.

No, I do not have an answer to that question, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants