`EntitlementInfo`: add a grace period limit to outdated entitlements by NachoSoto · Pull Request #2288 · RevenueCat/purchases-ios

NachoSoto · 2023-02-15T18:02:12Z

This prevents users from keeping an outdated active entitlement forever.
One could start a free trial then block all further requests from the backend in order to keep that active.

When this check fails, a new warning log is generated:

WARN: ⚠️ Entitlement is no longer active (expired 2023-02-12 18:15:11 +0000) and it's outside grace period window (last updated 2023-02-12 18:13:31 +0000)

Depends on #2310

codecov · 2023-02-15T18:12:45Z

Codecov Report

Merging #2288 (c4a0746) into main (da9ba39) will increase coverage by 0.01%.
The diff coverage is 99.26%.

❗ Current head c4a0746 differs from pull request most recent head b3fe95c. Consider uploading reports for the commit b3fe95c to get more accurate results

@@            Coverage Diff             @@
##             main    #2288      +/-   ##
==========================================
+ Coverage   86.50%   86.51%   +0.01%     
==========================================
  Files         188      188              
  Lines       12715    12743      +28     
==========================================
+ Hits        10999    11025      +26     
- Misses       1716     1718       +2

Impacted Files	Coverage Δ
Sources/Purchasing/EntitlementInfo.swift	`82.75% <95.45%> (+1.95%)`	⬆️
Sources/FoundationExtensions/Date+Extensions.swift	`100.00% <100.00%> (ø)`
...onExtensions/DispatchTimeInterval+Extensions.swift	`100.00% <100.00%> (ø)`
Sources/Identity/CustomerInfo.swift	`89.53% <100.00%> (ø)`
...sing/DataConverters/DateFormatter+Extensions.swift	`81.39% <100.00%> (+4.65%)`	⬆️
Sources/Logging/Strings/CustomerInfoStrings.swift	`92.68% <100.00%> (ø)`
Sources/Logging/Strings/PurchaseStrings.swift	`88.14% <100.00%> (+0.24%)`	⬆️
Sources/Logging/Strings/SigningStrings.swift	`95.00% <100.00%> (ø)`
Sources/Misc/Signing+ResponseVerification.swift	`98.01% <100.00%> (ø)`
Sources/Misc/Signing.swift	`88.76% <100.00%> (ø)`
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

NachoSoto · 2023-02-15T20:23:17Z

Don't merge this yet, we need to solve one issue with requestDates not getting updated from Etags.

NachoSoto · 2023-02-21T23:10:06Z

That will be fixed by #2310.

tonidero · 2023-02-22T12:04:13Z

Lmk if you need this reviewed then!

NachoSoto · 2023-02-23T22:40:57Z

Need to finish #2310 before this.

### Changes: - Added `HTTPResponseBody.copy(with newRequestDate:)` to be able to modify responses from the header request date - `CustomerInfo` implements this method to modify its request date - Added `HTTPResponse.requestDate` to be able to keep track of the request date from the server - Added `VerificationResult.from(cache:response:)` to determine the most restrictive verification result based on what's cached or checked from a response - Added `HTTPResponse.copy(with:)` to modify the verification result of a response using the previous method - `HTTPClient` now uses the most restrictive verification result - `HTTPClient` updates request date from server responses or cached responses (unless verification failed). This was the missing piece for #2288. ### Tests: - Verify that `ETagManager` does not use an ETag if verification was previously not enabled - Verify that `ETagManager` returns the request date from the server when returning a cached response - Verify that `HTTPClient` updates the request date from the server or from a cached response - Verify that `HTTPClient` does not update request date if verification failed - Tests for `HTTPResponse` request date parsing - Test for `CustomerInfoResponseHandler` updating request date - Tests for `CustomerInfo.copy(with newRequestDate:)` ### Other smaller changes: - Moved `CustomerInfo.asData()` into `Encodable.asJSONEncodedData()` - Renamed `requestTime` to `requestDate` everywhere for consistency

NachoSoto · 2023-02-28T00:35:58Z

JSON requires ISO8601 dates with no milliseconds.
Nothing else uses this, and technically this is more correct as noMilliseconds is implemented with only .withInternetDateTime.

NachoSoto · 2023-02-28T00:36:11Z

Slightly more precise test.

NachoSoto · 2023-02-28T00:39:11Z


    func testCopyWithNewRequestDateUpdatesEntitlements() throws {
        expect(self.customerInfo.entitlements.active).to(haveCount(2))
-        expect(self.customerInfo.entitlements["old_pro"]?.isActive) == false


This test was added in #2310.
old_pro no longer works because of the new grace period, so I've added a new expired_pro that expired not too far in the past.

NachoSoto · 2023-02-28T00:39:33Z

@tonidero this is ready now.

tonidero

LGTM!

tonidero · 2023-02-28T09:45:30Z

-        let referenceDate: Date = requestDate ?? Date()
-        return expirationDate.timeIntervalSince(referenceDate) >= 0
+        let (referenceDate, inGracePeriod) = Self.referenceDate(for: requestDate)
+        let isActive = expirationDate.timeIntervalSince(referenceDate) >= 0


I wonder if the grace period should apply to the expirationDate instead of to the request date... I think I could go either way so this is fine for now.

### Purpose: This is a prerequisite for #2288. The new grace period means that if we didn't update the date from the cached responses, entitlements would become stale and expired after 3 days. ### Changes: - Added `HTTPResponseBody.copy(with newRequestDate:)` to be able to modify responses from the header request date - `CustomerInfo` implements this method to modify its request date - Added `HTTPResponse.requestDate` to be able to keep track of the request date from the server - Added `VerificationResult.from(cache:response:)` to determine the most restrictive verification result based on what's cached or checked from a response - Added `HTTPResponse.copy(with:)` to modify the verification result of a response using the previous method - `HTTPClient` now uses the most restrictive verification result - `HTTPClient` updates request date from server responses or cached responses (unless verification failed). This was the missing piece for #2288. ### Tests: - Verify that `ETagManager` does not use an ETag if verification was previously not enabled - Verify that `ETagManager` returns the request date from the server when returning a cached response - Verify that `HTTPClient` updates the request date from the server or from a cached response - Verify that `HTTPClient` does not update request date if verification failed - Tests for `HTTPResponse` request date parsing - Test for `CustomerInfoResponseHandler` updating request date - Tests for `CustomerInfo.copy(with newRequestDate:)` ### Other smaller changes: - Moved `CustomerInfo.asData()` into `Encodable.asJSONEncodedData()` - Renamed `requestTime` to `requestDate` everywhere for consistency

This prevents users from keeping an outdated active entitlement forever. One could start a free trial then block all further requests from the backend in order to keep that active.

tonidero

@NachoSoto I noticed we didn't update the logic in CustomerInfo in https://github.com/RevenueCat/purchases-ios/blob/main/Sources/Identity/CustomerInfo.swift#L359 . We probably should update it there as well?

tonidero · 2023-03-07T14:51:06Z

 private extension EntitlementInfo {

-    class func isDateActive(expirationDate: Date?, forRequestDate requestDate: Date?) -> Bool {
+    static func isDateActive(expirationDate: Date?, for requestDate: Date?) -> Bool {


Also, while working on the Android side, I noticed we could assume we always have a requestDate, so this wouldn't be nullable. I think it would be the same in iOS, but not sure if I'm missing something.

I think you're right!

See #2288 (comment) This didn't need to be `Optional` since it's always there.

NachoSoto · 2023-03-07T16:50:35Z

@tonidero great catch! I'm going to make CustomerInfo use the same logic.

Follow up to #2288.

NachoSoto · 2023-03-07T17:09:50Z

@tonidero done: #2327

…2327) Follow up to #2288.

### Description Completes [SDK-2895](https://linear.app/revenuecat/issue/SDK-2895/create-a-grace-period-for-entitlements-when-the-backend-is-offline). Android equivalent of: RevenueCat/purchases-ios#2288 In this PR we are adding a 3 day grace period to entitlements expiration dates.

@NachoSoto

### New Features * New `ErrorCode.signatureVerificationFailed` which will be used for an upcoming feature ### Bugfixes * `Purchases.deinit`: don't reset `Purchases.proxyURL` (#2346) via NachoSoto (@NachoSoto) <details> <summary><b>Other Changes</b></summary> * Introduced `Configuration.EntitlementVerificationMode` and `VerificationResult` (#2277) via NachoSoto (@NachoSoto) * `PurchasesDiagnostics`: added step to verify signature verification (#2267) via NachoSoto (@NachoSoto) * `HTTPClient`: added signature validation and introduced `ErrorCode.signatureVerificationFailed` (#2272) via NachoSoto (@NachoSoto) * `ETagManager`: don't use ETags if response verification failed (#2347) via NachoSoto (@NachoSoto) * `Integration Tests`: removed `@preconcurrency import` (#2464) via NachoSoto (@NachoSoto) * Clean up: moved `ReceiptParserTests-Info.plist` out of root (#2460) via NachoSoto (@NachoSoto) * Update `CHANGELOG` (#2461) via NachoSoto (@NachoSoto) * Update `SwiftSnapshotTesting` (#2453) via NachoSoto (@NachoSoto) * Fixed docs (#2432) via Kaunteya Suryawanshi (@kaunteya) * Remove unnecessary line break (#2435) via Andy Boedo (@aboedo) * `ProductEntitlementMapping`: enabled entitlement mapping fetching (#2425) via NachoSoto (@NachoSoto) * `BackendPostReceiptDataTests`: increased timeout to fix flaky test (#2426) via NachoSoto (@NachoSoto) * Updated requirements to drop Xcode 13.x support (#2419) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed flaky errors when loading offerings (#2420) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed compilation for `internal` entitlement verification (#2417) via NachoSoto (@NachoSoto) * `ETagManager`/`HTTPClient`: sending new `X-RC-Last-Refresh-Time` header (#2373) via NachoSoto (@NachoSoto) * `ETagManager`: don't send validation time if not present (#2490) via NachoSoto (@NachoSoto) * SwiftUI Sample Project: Refactor Package terms method to a computed property (#2405) via Joseph Kokenge (@JOyo246) * Clean up v3 load shedder integration tests (#2402) via Andy Boedo (@aboedo) * Fix iOS 12 compilation (#2394) via NachoSoto (@NachoSoto) * Added new `VerificationResult.verifiedOnDevice` (#2379) via NachoSoto (@NachoSoto) * `PurchaseTester`: fix memory leaks (#2392) via Keita Watanabe (@kitwtnb) * Integration tests: add scheduled job (#2389) via Andy Boedo (@aboedo) * Add lane for running iOS v3 load shedder integration tests (#2388) via Andy Boedo (@aboedo) * iOS v3 load shedder integration tests (#2387) via Andy Boedo (@aboedo) * `Offline Entitlements`: created `LoadShedderIntegrationTests` (#2362) via NachoSoto (@NachoSoto) * Purchases.configure: log warning if attempting to use a static appUserID (#2385) via Mark Villacampa (@MarkVillacampa) * `SubscriberAttributesManagerIntegrationTests`: fixed flaky failures (#2381) via NachoSoto (@NachoSoto) * `@DefaultDecodable.Now`: fixed flaky test (#2374) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: fixed iOS compilation (#2376) via NachoSoto (@NachoSoto) * `SubscriberAttributesManagerIntegrationTests`: fixed potential race condition (#2380) via NachoSoto (@NachoSoto) * `Offline Entitlements`: create `CustomerInfo` from offline entitlements (#2358) via NachoSoto (@NachoSoto) * Added `@DefaultDecodable.Now` (#2372) via NachoSoto (@NachoSoto) * `HTTPClient`: debug log when performing redirects (#2371) via NachoSoto (@NachoSoto) * `HTTPClient`: new flag to force server errors (#2370) via NachoSoto (@NachoSoto) * `OfferingsManager`: fixed Xcode 13.x build (#2369) via NachoSoto (@NachoSoto) * `Offline Entitlements`: store `ProductEntitlementMapping` in cache (#2355) via NachoSoto (@NachoSoto) * `Offline Entitlements`: added support for fetching `ProductEntitlementMappingResponse` in `OfflineEntitlementsAPI` (#2353) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMapping` (#2365) via NachoSoto (@NachoSoto) * Implemented `NetworkError.isServerDown` (#2367) via NachoSoto (@NachoSoto) * `ETagManager`: added test for 304 responses with no etag (#2360) via NachoSoto (@NachoSoto) * `TestLogHandler`: increased default capacity (#2357) via NachoSoto (@NachoSoto) * `OfferingsManager`: moved log to common method to remove hardcoded string (#2363) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMappingResponse` (#2351) via NachoSoto (@NachoSoto) * `HTTPClient`: added test for 2xx response for request with etag (#2361) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI` improvements (#2345) via NachoSoto (@NachoSoto) * `ConfigureStrings`: fixed double-space typo (#2344) via NachoSoto (@NachoSoto) * `ETagManagerTests`: fixed tests on iOS 12 (#2349) via NachoSoto (@NachoSoto) * `DeviceCache`: simplified constructor (#2354) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: changed all APIs to `internal` (#2350) via NachoSoto (@NachoSoto) * `VerificationResult.notRequested`: removed caching reference (#2337) via NachoSoto (@NachoSoto) * Finished signature verification `HTTPClient` tests (#2333) via NachoSoto (@NachoSoto) * `Configuration.Builder.with(entitlementVerificationMode:)`: improved documentation (#2334) via NachoSoto (@NachoSoto) * `ETagManager`: don't ignore failed etags with `Signing.VerificationMode.informational` (#2331) via NachoSoto (@NachoSoto) * `IdentityManager`: clear `ETagManager` and `DeviceCache` if verification is enabled but cached `CustomerInfo` is not (#2330) via NachoSoto (@NachoSoto) * Made `Configuration.EntitlementVerificationMode.enforced` unavailable (#2329) via NachoSoto (@NachoSoto) * Refactor: reorganized files in new Security and Misc folders (#2326) via NachoSoto (@NachoSoto) * `CustomerInfo`: use same grace period logic for active subscriptions (#2327) via NachoSoto (@NachoSoto) * `HTTPClient`: don't verify 4xx/5xx responses (#2322) via NachoSoto (@NachoSoto) * `EntitlementInfo`: request date is not optional (#2325) via NachoSoto (@NachoSoto) * `CustomerInfo`: removed `entitlementVerification` (#2320) via NachoSoto (@NachoSoto) * Renamed `VerificationResult.notVerified` to `.notRequested` (#2321) via NachoSoto (@NachoSoto) * `EntitlementInfo`: add a grace period limit to outdated entitlements (#2288) via NachoSoto (@NachoSoto) * Update `CustomerInfo.requestDate` from 304 responses (#2310) via NachoSoto (@NachoSoto) * `Signing`: added request time & eTag to signature verification (#2309) via NachoSoto (@NachoSoto) * `HTTPClient`: changed header search to be case-insensitive (#2308) via NachoSoto (@NachoSoto) * `HTTPClient`: automatically add `nonce` based on `HTTPRequest.Path` (#2286) via NachoSoto (@NachoSoto) * `PurchaseTester`: added ability to reload `CustomerInfo` with a custom `CacheFetchPolicy` (#2312) via NachoSoto (@NachoSoto) * Fix issue where underlying error information for product fetch errors was not printed in log. (#2281) via Chris Vasselli (@chrisvasselli) * `PurchaseTester`: added ability to set `Configuration.EntitlementVerificationMode` (#2290) via NachoSoto (@NachoSoto) * SwiftUI: Paywall View should respond to changes on the UserView model (#2297) via ConfusedVorlon (@ConfusedVorlon) * Deprecate `usesStoreKit2IfAvailable` (#2293) via Andy Boedo (@aboedo) * `Signing`: updated to use production public key (#2274) via NachoSoto (@NachoSoto) </details> --------- Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>

@NachoSoto

### New Features * New `ErrorCode.signatureVerificationFailed` which will be used for an upcoming feature ### Bugfixes * `Purchases.deinit`: don't reset `Purchases.proxyURL` (RevenueCat#2346) via NachoSoto (@NachoSoto) <details> <summary><b>Other Changes</b></summary> * Introduced `Configuration.EntitlementVerificationMode` and `VerificationResult` (RevenueCat#2277) via NachoSoto (@NachoSoto) * `PurchasesDiagnostics`: added step to verify signature verification (RevenueCat#2267) via NachoSoto (@NachoSoto) * `HTTPClient`: added signature validation and introduced `ErrorCode.signatureVerificationFailed` (RevenueCat#2272) via NachoSoto (@NachoSoto) * `ETagManager`: don't use ETags if response verification failed (RevenueCat#2347) via NachoSoto (@NachoSoto) * `Integration Tests`: removed `@preconcurrency import` (RevenueCat#2464) via NachoSoto (@NachoSoto) * Clean up: moved `ReceiptParserTests-Info.plist` out of root (RevenueCat#2460) via NachoSoto (@NachoSoto) * Update `CHANGELOG` (RevenueCat#2461) via NachoSoto (@NachoSoto) * Update `SwiftSnapshotTesting` (RevenueCat#2453) via NachoSoto (@NachoSoto) * Fixed docs (RevenueCat#2432) via Kaunteya Suryawanshi (@kaunteya) * Remove unnecessary line break (RevenueCat#2435) via Andy Boedo (@aboedo) * `ProductEntitlementMapping`: enabled entitlement mapping fetching (RevenueCat#2425) via NachoSoto (@NachoSoto) * `BackendPostReceiptDataTests`: increased timeout to fix flaky test (RevenueCat#2426) via NachoSoto (@NachoSoto) * Updated requirements to drop Xcode 13.x support (RevenueCat#2419) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed flaky errors when loading offerings (RevenueCat#2420) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed compilation for `internal` entitlement verification (RevenueCat#2417) via NachoSoto (@NachoSoto) * `ETagManager`/`HTTPClient`: sending new `X-RC-Last-Refresh-Time` header (RevenueCat#2373) via NachoSoto (@NachoSoto) * `ETagManager`: don't send validation time if not present (RevenueCat#2490) via NachoSoto (@NachoSoto) * SwiftUI Sample Project: Refactor Package terms method to a computed property (RevenueCat#2405) via Joseph Kokenge (@JOyo246) * Clean up v3 load shedder integration tests (RevenueCat#2402) via Andy Boedo (@aboedo) * Fix iOS 12 compilation (RevenueCat#2394) via NachoSoto (@NachoSoto) * Added new `VerificationResult.verifiedOnDevice` (RevenueCat#2379) via NachoSoto (@NachoSoto) * `PurchaseTester`: fix memory leaks (RevenueCat#2392) via Keita Watanabe (@kitwtnb) * Integration tests: add scheduled job (RevenueCat#2389) via Andy Boedo (@aboedo) * Add lane for running iOS v3 load shedder integration tests (RevenueCat#2388) via Andy Boedo (@aboedo) * iOS v3 load shedder integration tests (RevenueCat#2387) via Andy Boedo (@aboedo) * `Offline Entitlements`: created `LoadShedderIntegrationTests` (RevenueCat#2362) via NachoSoto (@NachoSoto) * Purchases.configure: log warning if attempting to use a static appUserID (RevenueCat#2385) via Mark Villacampa (@MarkVillacampa) * `SubscriberAttributesManagerIntegrationTests`: fixed flaky failures (RevenueCat#2381) via NachoSoto (@NachoSoto) * `@DefaultDecodable.Now`: fixed flaky test (RevenueCat#2374) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: fixed iOS compilation (RevenueCat#2376) via NachoSoto (@NachoSoto) * `SubscriberAttributesManagerIntegrationTests`: fixed potential race condition (RevenueCat#2380) via NachoSoto (@NachoSoto) * `Offline Entitlements`: create `CustomerInfo` from offline entitlements (RevenueCat#2358) via NachoSoto (@NachoSoto) * Added `@DefaultDecodable.Now` (RevenueCat#2372) via NachoSoto (@NachoSoto) * `HTTPClient`: debug log when performing redirects (RevenueCat#2371) via NachoSoto (@NachoSoto) * `HTTPClient`: new flag to force server errors (RevenueCat#2370) via NachoSoto (@NachoSoto) * `OfferingsManager`: fixed Xcode 13.x build (RevenueCat#2369) via NachoSoto (@NachoSoto) * `Offline Entitlements`: store `ProductEntitlementMapping` in cache (RevenueCat#2355) via NachoSoto (@NachoSoto) * `Offline Entitlements`: added support for fetching `ProductEntitlementMappingResponse` in `OfflineEntitlementsAPI` (RevenueCat#2353) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMapping` (RevenueCat#2365) via NachoSoto (@NachoSoto) * Implemented `NetworkError.isServerDown` (RevenueCat#2367) via NachoSoto (@NachoSoto) * `ETagManager`: added test for 304 responses with no etag (RevenueCat#2360) via NachoSoto (@NachoSoto) * `TestLogHandler`: increased default capacity (RevenueCat#2357) via NachoSoto (@NachoSoto) * `OfferingsManager`: moved log to common method to remove hardcoded string (RevenueCat#2363) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMappingResponse` (RevenueCat#2351) via NachoSoto (@NachoSoto) * `HTTPClient`: added test for 2xx response for request with etag (RevenueCat#2361) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI` improvements (RevenueCat#2345) via NachoSoto (@NachoSoto) * `ConfigureStrings`: fixed double-space typo (RevenueCat#2344) via NachoSoto (@NachoSoto) * `ETagManagerTests`: fixed tests on iOS 12 (RevenueCat#2349) via NachoSoto (@NachoSoto) * `DeviceCache`: simplified constructor (RevenueCat#2354) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: changed all APIs to `internal` (RevenueCat#2350) via NachoSoto (@NachoSoto) * `VerificationResult.notRequested`: removed caching reference (RevenueCat#2337) via NachoSoto (@NachoSoto) * Finished signature verification `HTTPClient` tests (RevenueCat#2333) via NachoSoto (@NachoSoto) * `Configuration.Builder.with(entitlementVerificationMode:)`: improved documentation (RevenueCat#2334) via NachoSoto (@NachoSoto) * `ETagManager`: don't ignore failed etags with `Signing.VerificationMode.informational` (RevenueCat#2331) via NachoSoto (@NachoSoto) * `IdentityManager`: clear `ETagManager` and `DeviceCache` if verification is enabled but cached `CustomerInfo` is not (RevenueCat#2330) via NachoSoto (@NachoSoto) * Made `Configuration.EntitlementVerificationMode.enforced` unavailable (RevenueCat#2329) via NachoSoto (@NachoSoto) * Refactor: reorganized files in new Security and Misc folders (RevenueCat#2326) via NachoSoto (@NachoSoto) * `CustomerInfo`: use same grace period logic for active subscriptions (RevenueCat#2327) via NachoSoto (@NachoSoto) * `HTTPClient`: don't verify 4xx/5xx responses (RevenueCat#2322) via NachoSoto (@NachoSoto) * `EntitlementInfo`: request date is not optional (RevenueCat#2325) via NachoSoto (@NachoSoto) * `CustomerInfo`: removed `entitlementVerification` (RevenueCat#2320) via NachoSoto (@NachoSoto) * Renamed `VerificationResult.notVerified` to `.notRequested` (RevenueCat#2321) via NachoSoto (@NachoSoto) * `EntitlementInfo`: add a grace period limit to outdated entitlements (RevenueCat#2288) via NachoSoto (@NachoSoto) * Update `CustomerInfo.requestDate` from 304 responses (RevenueCat#2310) via NachoSoto (@NachoSoto) * `Signing`: added request time & eTag to signature verification (RevenueCat#2309) via NachoSoto (@NachoSoto) * `HTTPClient`: changed header search to be case-insensitive (RevenueCat#2308) via NachoSoto (@NachoSoto) * `HTTPClient`: automatically add `nonce` based on `HTTPRequest.Path` (RevenueCat#2286) via NachoSoto (@NachoSoto) * `PurchaseTester`: added ability to reload `CustomerInfo` with a custom `CacheFetchPolicy` (RevenueCat#2312) via NachoSoto (@NachoSoto) * Fix issue where underlying error information for product fetch errors was not printed in log. (RevenueCat#2281) via Chris Vasselli (@chrisvasselli) * `PurchaseTester`: added ability to set `Configuration.EntitlementVerificationMode` (RevenueCat#2290) via NachoSoto (@NachoSoto) * SwiftUI: Paywall View should respond to changes on the UserView model (RevenueCat#2297) via ConfusedVorlon (@ConfusedVorlon) * Deprecate `usesStoreKit2IfAvailable` (RevenueCat#2293) via Andy Boedo (@aboedo) * `Signing`: updated to use production public key (RevenueCat#2274) via NachoSoto (@NachoSoto) </details> --------- Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>

NachoSoto added the pr:fix A bug fix label Feb 15, 2023

NachoSoto requested a review from a team February 15, 2023 18:02

NachoSoto commented Feb 15, 2023

View reviewed changes

Comment thread Sources/Purchasing/EntitlementInfo.swift Outdated

NachoSoto added the do not merge label Feb 15, 2023

NachoSoto added the blocked label Feb 23, 2023

NachoSoto mentioned this pull request Feb 28, 2023

Update CustomerInfo.requestDate from 304 responses #2310

Merged

NachoSoto changed the base branch from main to nacho/sdk-2856-requestdate-not-returning-updated-value February 28, 2023 00:22

NachoSoto removed blocked do not merge labels Feb 28, 2023

NachoSoto force-pushed the nacho/sdk-2864-create-a-grace-period-for-entitlements branch from 282ea47 to 5e11954 Compare February 28, 2023 00:22

NachoSoto force-pushed the nacho/sdk-2856-requestdate-not-returning-updated-value branch from d50f942 to 7a2204d Compare February 28, 2023 00:24

NachoSoto force-pushed the nacho/sdk-2864-create-a-grace-period-for-entitlements branch from 5e11954 to 95b6442 Compare February 28, 2023 00:25

NachoSoto commented Feb 28, 2023

View reviewed changes

Comment thread Tests/UnitTests/Purchasing/CustomerInfoTests.swift Outdated

NachoSoto Feb 28, 2023

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly more precise test.

NachoSoto force-pushed the nacho/sdk-2864-create-a-grace-period-for-entitlements branch from 908c8d0 to c4a0746 Compare February 28, 2023 00:38

NachoSoto commented Feb 28, 2023

View reviewed changes

tonidero approved these changes Feb 28, 2023

View reviewed changes

Base automatically changed from nacho/sdk-2856-requestdate-not-returning-updated-value to main March 1, 2023 17:24

NachoSoto added 3 commits March 1, 2023 09:37

EntitlementInfo: add a grace period limit to outdated entitlements

9f653f8

This prevents users from keeping an outdated active entitlement forever. One could start a free trial then block all further requests from the backend in order to keep that active.

Added warning log

e3921e8

Fixed tests

b3fe95c

NachoSoto force-pushed the nacho/sdk-2864-create-a-grace-period-for-entitlements branch from c4a0746 to b3fe95c Compare March 1, 2023 17:37

NachoSoto enabled auto-merge (squash) March 1, 2023 17:39

NachoSoto disabled auto-merge March 1, 2023 17:39

NachoSoto enabled auto-merge (squash) March 1, 2023 17:39

NachoSoto added refactor and removed pr:fix A bug fix labels Mar 1, 2023

NachoSoto merged commit a157adf into main Mar 1, 2023

NachoSoto deleted the nacho/sdk-2864-create-a-grace-period-for-entitlements branch March 1, 2023 17:45

tonidero reviewed Mar 7, 2023

View reviewed changes

NachoSoto added a commit that referenced this pull request Mar 7, 2023

EntitlementInfo: request date is not optional

b7ecf2b

See #2288 (comment) This didn't need to be `Optional` since it's always there.

NachoSoto mentioned this pull request Mar 7, 2023

EntitlementInfo: request date is not optional #2325

Merged

NachoSoto added a commit that referenced this pull request Mar 7, 2023

EntitlementInfo: request date is not optional (#2325)

f5119bb

See #2288 (comment) This didn't need to be `Optional` since it's always there.

NachoSoto added a commit that referenced this pull request Mar 7, 2023

CustomerInfo: use same grace period logic for active subscriptions

6947df2

Follow up to #2288.

NachoSoto mentioned this pull request Mar 7, 2023

CustomerInfo: use same grace period logic for active subscriptions #2327

Merged

NachoSoto added a commit that referenced this pull request Mar 7, 2023

CustomerInfo: use same grace period logic for active subscriptions (#…

9c21d53

…2327) Follow up to #2288.

tonidero mentioned this pull request Mar 8, 2023

Grant grace period for entitlements when the backend is offline RevenueCat/purchases-android#851

Merged

NachoSoto mentioned this pull request Mar 14, 2023

Release/4.18.0-beta.1 #2335

Closed

RCGitBot mentioned this pull request May 3, 2023

[AUTOMATIC] Release/4.19.0 #2466

Closed

This was referenced May 12, 2023

Release/4.19 #2483

Closed

Release/4.19.0 #2491

Merged

Conversation

NachoSoto commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

NachoSoto commented Feb 15, 2023

Uh oh!

NachoSoto commented Feb 21, 2023

Uh oh!

tonidero commented Feb 22, 2023

Uh oh!

NachoSoto commented Feb 23, 2023

Uh oh!

NachoSoto Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto commented Feb 28, 2023

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

tonidero Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

tonidero Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto commented Mar 7, 2023

Uh oh!

NachoSoto commented Mar 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NachoSoto commented Feb 15, 2023 •

edited

Loading

codecov Bot commented Feb 15, 2023 •

edited

Loading