Grant grace period for entitlements when the backend is offline#851
Merged
tonidero merged 3 commits intoMar 8, 2023
Conversation
tonidero
commented
Mar 8, 2023
Contributor
Author
There was a problem hiding this comment.
I thought about adding these extensions to production code, but since I wasn't planning to use them yet, I left them as test code for now. We can move them in the future if needed.
Codecov Report
@@ Coverage Diff @@
## entitlements-verification #851 +/- ##
=============================================================
+ Coverage 82.62% 82.64% +0.01%
=============================================================
Files 137 137
Lines 4501 4511 +10
Branches 587 591 +4
=============================================================
+ Hits 3719 3728 +9
- Misses 562 563 +1
Partials 220 220
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
44c9010 to
60859d1
Compare
45f36c4 to
817c4fd
Compare
NachoSoto
approved these changes
Mar 8, 2023
Base automatically changed from
toniricodiez/sdk-2897-requestdate-not-returning-updated-value
to
entitlements-verification
March 8, 2023 15:25
a962240 to
282fd0b
Compare
tonidero
added a commit
that referenced
this pull request
Mar 15, 2023
### Description Completes [SDK-2895](https://linear.app/revenuecat/issue/SDK-2895/create-a-grace-period-for-entitlements-when-the-backend-is-offline). Android equivalent of: RevenueCat/purchases-ios#2288 In this PR we are adding a 3 day grace period to entitlements expiration dates.
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes SDK-2895.
Android equivalent of: RevenueCat/purchases-ios#2288
In this PR we are adding a 3 day grace period to entitlements expiration dates.