Introduced `Configuration.EntitlementVerificationMode` and `VerificationResult` by NachoSoto · Pull Request #2277 · RevenueCat/purchases-ios

NachoSoto · 2023-02-09T19:02:56Z

Fixes CSDK-629.
Depends on #2274 and #2267.

Entitlement verification is accomplished by preventing MiTM attacks between the SDK and the RevenueCat server.
With verification enabled, the SDK ensures that the response created by the server was not modified by a third-party, and the entitlements received are exactly what was sent.

Entitlements are only verified if enabled using Configuration.Builder.with(entitlementVerificationMode:), which is disabled by default.

Changes:

Added new VerificationResult, which replaces HTTPResponseVerificationResult
Renamed Configuration.EntitlementVerificationLevel to Configuration.EntitlementVerificationMode
Configuration.with(entitlementVerificationMode:) is now public
Added CustomerInfo.entitlementVerification
Added EntitlementInfos.verification and EntitlementInfo.verification
Added tests to cover serialization of these new values
CustomerInfoResponseHandler copies the ValidationResult to CustomerInfo (all operations that fetch CustomerInfo use this)
Renamed "validation" to "verification" everywhere for consistency
Finalized documentation

TODO:

Figure out whether to use a separate type from HTTPResponseValidationResult or rename that one
Figure out final API type and property names
Add tests for CustomerInfo.copy(with:)
Ensure validation result is encoded and decoded (for caching)
Add missing snapshots

codecov · 2023-02-09T20:01:16Z

Codecov Report

Merging #2277 (8fcf9ca) into nacho/signature-integration (8fcf9ca) will not change coverage.
The diff coverage is n/a.

❗ Current head 8fcf9ca differs from pull request most recent head 98b4b35. Consider uploading reports for the commit 98b4b35 to get more accurate results

@@                     Coverage Diff                      @@
##           nacho/signature-integration    #2277   +/-   ##
============================================================
  Coverage                        86.28%   86.28%           
============================================================
  Files                              187      187           
  Lines                            12420    12420           
============================================================
  Hits                             10717    10717           
  Misses                            1703     1703

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aboedo

looking great!

NachoSoto · 2023-02-10T23:24:28Z

    case unexpectedResponse(URLResponse?, Source)
    case errorResponse(ErrorResponse, HTTPStatusCode, Source)
-    case signatureVerificationFailed(HTTPRequest.Path, Source)
+    case signatureValidationFailed(HTTPRequest.Path, Source)


This hasn't shipped so we can safely change it.

cadamsdotcom

Looking good, but I wouldn't consider myself qualified to approve so just leaving a few comments

cadamsdotcom · 2023-02-13T05:43:55Z

                completion: CustomerAPI.CustomerInfoResponseHandler) {
        let result: Result<CustomerInfo, BackendError> = response
-            .map {
+            .map { response in


Nice clarification

cadamsdotcom · 2023-02-13T05:48:04Z

  - file_length
  - type_body_length
  - function_body_length
+  - force_try


nit: Not an expert here, but only seeing one try! in this PR, so is this worth trying to leave enabled?
My research took me to https://realm.github.io/SwiftLint/force_try.html and https://cocoacasts.com/what-is-the-difference-between-try-try-and-try where it looks like they spell out good reasons to avoid try!.. so thought I would raise it.

Oh I forgot to explain this. We don't actually run APITester code, we only compile it (thats by design). try! would crash at runtime, but because it never runs it doesn't matter. It simplifies the type checking.

tonidero

Looks great! Just some small things

NachoSoto · 2023-02-16T17:45:25Z

Gotta fix the snapshots

Entitlement validation is accomplished by preventing MiTM attacks between the SDK and the RevenueCat server. With validation enabled, the SDK ensures that the response created by the server was not modified by a third-party, and the entitlements received are exactly what was sent. Entitlements are only validated if enabled using `Configuration.Builder.with(entitlementValidationMode:)`, which is disabled by default. - Added new `EntitlementValidation`, this mostly mirrors `HTTPResponseValidationResult` but it's the public API specific to `CustomerInfo` and `EntitlementInfos` - Renamed `Configuration.EntitlementVerificationLevel` to `Configuration.EntitlementValidationMode` - `Configuration.with(entitlementValidationMode:)` is now `public` - Added `CustomerInfo.entitlementValidation` - Added `EntitlementInfos.validation` and `EntitlementInfo.validation` - Added tests to cover serialization of these new values - `CustomerInfoResponseHandler` copies the `HTTPResponseValidationResult` as `EntitlementValidation` to `CustomerInfo` (all operations that fetch `CustomerInfo` use this) - Renamed "verification" with "validation" everywhere for consistency - Renamed `ErrorCode.signatureVerificationFailed` to `ErrorCode.signatureValidationFailed` - Finalized documentation - Added new APIs to `APITesters`

…ficationMode` Depends on #2277

…2286) Instead of manually choosing when to include `nonce` in requests, this data-driven approach ensures that all requests to endpoints that support signature verification will make `HTTPClient` do the right thing. See also #2277 for how `CustomerInfo` and `EntitlementInfo` will use this.

@NachoSoto

### New Features * New `ErrorCode.signatureVerificationFailed` which will be used for an upcoming feature ### Bugfixes * `Purchases.deinit`: don't reset `Purchases.proxyURL` (#2346) via NachoSoto (@NachoSoto) <details> <summary><b>Other Changes</b></summary> * Introduced `Configuration.EntitlementVerificationMode` and `VerificationResult` (#2277) via NachoSoto (@NachoSoto) * `PurchasesDiagnostics`: added step to verify signature verification (#2267) via NachoSoto (@NachoSoto) * `HTTPClient`: added signature validation and introduced `ErrorCode.signatureVerificationFailed` (#2272) via NachoSoto (@NachoSoto) * `ETagManager`: don't use ETags if response verification failed (#2347) via NachoSoto (@NachoSoto) * `Integration Tests`: removed `@preconcurrency import` (#2464) via NachoSoto (@NachoSoto) * Clean up: moved `ReceiptParserTests-Info.plist` out of root (#2460) via NachoSoto (@NachoSoto) * Update `CHANGELOG` (#2461) via NachoSoto (@NachoSoto) * Update `SwiftSnapshotTesting` (#2453) via NachoSoto (@NachoSoto) * Fixed docs (#2432) via Kaunteya Suryawanshi (@kaunteya) * Remove unnecessary line break (#2435) via Andy Boedo (@aboedo) * `ProductEntitlementMapping`: enabled entitlement mapping fetching (#2425) via NachoSoto (@NachoSoto) * `BackendPostReceiptDataTests`: increased timeout to fix flaky test (#2426) via NachoSoto (@NachoSoto) * Updated requirements to drop Xcode 13.x support (#2419) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed flaky errors when loading offerings (#2420) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed compilation for `internal` entitlement verification (#2417) via NachoSoto (@NachoSoto) * `ETagManager`/`HTTPClient`: sending new `X-RC-Last-Refresh-Time` header (#2373) via NachoSoto (@NachoSoto) * `ETagManager`: don't send validation time if not present (#2490) via NachoSoto (@NachoSoto) * SwiftUI Sample Project: Refactor Package terms method to a computed property (#2405) via Joseph Kokenge (@JOyo246) * Clean up v3 load shedder integration tests (#2402) via Andy Boedo (@aboedo) * Fix iOS 12 compilation (#2394) via NachoSoto (@NachoSoto) * Added new `VerificationResult.verifiedOnDevice` (#2379) via NachoSoto (@NachoSoto) * `PurchaseTester`: fix memory leaks (#2392) via Keita Watanabe (@kitwtnb) * Integration tests: add scheduled job (#2389) via Andy Boedo (@aboedo) * Add lane for running iOS v3 load shedder integration tests (#2388) via Andy Boedo (@aboedo) * iOS v3 load shedder integration tests (#2387) via Andy Boedo (@aboedo) * `Offline Entitlements`: created `LoadShedderIntegrationTests` (#2362) via NachoSoto (@NachoSoto) * Purchases.configure: log warning if attempting to use a static appUserID (#2385) via Mark Villacampa (@MarkVillacampa) * `SubscriberAttributesManagerIntegrationTests`: fixed flaky failures (#2381) via NachoSoto (@NachoSoto) * `@DefaultDecodable.Now`: fixed flaky test (#2374) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: fixed iOS compilation (#2376) via NachoSoto (@NachoSoto) * `SubscriberAttributesManagerIntegrationTests`: fixed potential race condition (#2380) via NachoSoto (@NachoSoto) * `Offline Entitlements`: create `CustomerInfo` from offline entitlements (#2358) via NachoSoto (@NachoSoto) * Added `@DefaultDecodable.Now` (#2372) via NachoSoto (@NachoSoto) * `HTTPClient`: debug log when performing redirects (#2371) via NachoSoto (@NachoSoto) * `HTTPClient`: new flag to force server errors (#2370) via NachoSoto (@NachoSoto) * `OfferingsManager`: fixed Xcode 13.x build (#2369) via NachoSoto (@NachoSoto) * `Offline Entitlements`: store `ProductEntitlementMapping` in cache (#2355) via NachoSoto (@NachoSoto) * `Offline Entitlements`: added support for fetching `ProductEntitlementMappingResponse` in `OfflineEntitlementsAPI` (#2353) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMapping` (#2365) via NachoSoto (@NachoSoto) * Implemented `NetworkError.isServerDown` (#2367) via NachoSoto (@NachoSoto) * `ETagManager`: added test for 304 responses with no etag (#2360) via NachoSoto (@NachoSoto) * `TestLogHandler`: increased default capacity (#2357) via NachoSoto (@NachoSoto) * `OfferingsManager`: moved log to common method to remove hardcoded string (#2363) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMappingResponse` (#2351) via NachoSoto (@NachoSoto) * `HTTPClient`: added test for 2xx response for request with etag (#2361) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI` improvements (#2345) via NachoSoto (@NachoSoto) * `ConfigureStrings`: fixed double-space typo (#2344) via NachoSoto (@NachoSoto) * `ETagManagerTests`: fixed tests on iOS 12 (#2349) via NachoSoto (@NachoSoto) * `DeviceCache`: simplified constructor (#2354) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: changed all APIs to `internal` (#2350) via NachoSoto (@NachoSoto) * `VerificationResult.notRequested`: removed caching reference (#2337) via NachoSoto (@NachoSoto) * Finished signature verification `HTTPClient` tests (#2333) via NachoSoto (@NachoSoto) * `Configuration.Builder.with(entitlementVerificationMode:)`: improved documentation (#2334) via NachoSoto (@NachoSoto) * `ETagManager`: don't ignore failed etags with `Signing.VerificationMode.informational` (#2331) via NachoSoto (@NachoSoto) * `IdentityManager`: clear `ETagManager` and `DeviceCache` if verification is enabled but cached `CustomerInfo` is not (#2330) via NachoSoto (@NachoSoto) * Made `Configuration.EntitlementVerificationMode.enforced` unavailable (#2329) via NachoSoto (@NachoSoto) * Refactor: reorganized files in new Security and Misc folders (#2326) via NachoSoto (@NachoSoto) * `CustomerInfo`: use same grace period logic for active subscriptions (#2327) via NachoSoto (@NachoSoto) * `HTTPClient`: don't verify 4xx/5xx responses (#2322) via NachoSoto (@NachoSoto) * `EntitlementInfo`: request date is not optional (#2325) via NachoSoto (@NachoSoto) * `CustomerInfo`: removed `entitlementVerification` (#2320) via NachoSoto (@NachoSoto) * Renamed `VerificationResult.notVerified` to `.notRequested` (#2321) via NachoSoto (@NachoSoto) * `EntitlementInfo`: add a grace period limit to outdated entitlements (#2288) via NachoSoto (@NachoSoto) * Update `CustomerInfo.requestDate` from 304 responses (#2310) via NachoSoto (@NachoSoto) * `Signing`: added request time & eTag to signature verification (#2309) via NachoSoto (@NachoSoto) * `HTTPClient`: changed header search to be case-insensitive (#2308) via NachoSoto (@NachoSoto) * `HTTPClient`: automatically add `nonce` based on `HTTPRequest.Path` (#2286) via NachoSoto (@NachoSoto) * `PurchaseTester`: added ability to reload `CustomerInfo` with a custom `CacheFetchPolicy` (#2312) via NachoSoto (@NachoSoto) * Fix issue where underlying error information for product fetch errors was not printed in log. (#2281) via Chris Vasselli (@chrisvasselli) * `PurchaseTester`: added ability to set `Configuration.EntitlementVerificationMode` (#2290) via NachoSoto (@NachoSoto) * SwiftUI: Paywall View should respond to changes on the UserView model (#2297) via ConfusedVorlon (@ConfusedVorlon) * Deprecate `usesStoreKit2IfAvailable` (#2293) via Andy Boedo (@aboedo) * `Signing`: updated to use production public key (#2274) via NachoSoto (@NachoSoto) </details> --------- Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>

@NachoSoto

### New Features * New `ErrorCode.signatureVerificationFailed` which will be used for an upcoming feature ### Bugfixes * `Purchases.deinit`: don't reset `Purchases.proxyURL` (RevenueCat#2346) via NachoSoto (@NachoSoto) <details> <summary><b>Other Changes</b></summary> * Introduced `Configuration.EntitlementVerificationMode` and `VerificationResult` (RevenueCat#2277) via NachoSoto (@NachoSoto) * `PurchasesDiagnostics`: added step to verify signature verification (RevenueCat#2267) via NachoSoto (@NachoSoto) * `HTTPClient`: added signature validation and introduced `ErrorCode.signatureVerificationFailed` (RevenueCat#2272) via NachoSoto (@NachoSoto) * `ETagManager`: don't use ETags if response verification failed (RevenueCat#2347) via NachoSoto (@NachoSoto) * `Integration Tests`: removed `@preconcurrency import` (RevenueCat#2464) via NachoSoto (@NachoSoto) * Clean up: moved `ReceiptParserTests-Info.plist` out of root (RevenueCat#2460) via NachoSoto (@NachoSoto) * Update `CHANGELOG` (RevenueCat#2461) via NachoSoto (@NachoSoto) * Update `SwiftSnapshotTesting` (RevenueCat#2453) via NachoSoto (@NachoSoto) * Fixed docs (RevenueCat#2432) via Kaunteya Suryawanshi (@kaunteya) * Remove unnecessary line break (RevenueCat#2435) via Andy Boedo (@aboedo) * `ProductEntitlementMapping`: enabled entitlement mapping fetching (RevenueCat#2425) via NachoSoto (@NachoSoto) * `BackendPostReceiptDataTests`: increased timeout to fix flaky test (RevenueCat#2426) via NachoSoto (@NachoSoto) * Updated requirements to drop Xcode 13.x support (RevenueCat#2419) via NachoSoto (@NachoSoto) * `Integration Tests`: fixed flaky errors when loading offerings (RevenueCat#2420) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed compilation for `internal` entitlement verification (RevenueCat#2417) via NachoSoto (@NachoSoto) * `ETagManager`/`HTTPClient`: sending new `X-RC-Last-Refresh-Time` header (RevenueCat#2373) via NachoSoto (@NachoSoto) * `ETagManager`: don't send validation time if not present (RevenueCat#2490) via NachoSoto (@NachoSoto) * SwiftUI Sample Project: Refactor Package terms method to a computed property (RevenueCat#2405) via Joseph Kokenge (@JOyo246) * Clean up v3 load shedder integration tests (RevenueCat#2402) via Andy Boedo (@aboedo) * Fix iOS 12 compilation (RevenueCat#2394) via NachoSoto (@NachoSoto) * Added new `VerificationResult.verifiedOnDevice` (RevenueCat#2379) via NachoSoto (@NachoSoto) * `PurchaseTester`: fix memory leaks (RevenueCat#2392) via Keita Watanabe (@kitwtnb) * Integration tests: add scheduled job (RevenueCat#2389) via Andy Boedo (@aboedo) * Add lane for running iOS v3 load shedder integration tests (RevenueCat#2388) via Andy Boedo (@aboedo) * iOS v3 load shedder integration tests (RevenueCat#2387) via Andy Boedo (@aboedo) * `Offline Entitlements`: created `LoadShedderIntegrationTests` (RevenueCat#2362) via NachoSoto (@NachoSoto) * Purchases.configure: log warning if attempting to use a static appUserID (RevenueCat#2385) via Mark Villacampa (@MarkVillacampa) * `SubscriberAttributesManagerIntegrationTests`: fixed flaky failures (RevenueCat#2381) via NachoSoto (@NachoSoto) * `@DefaultDecodable.Now`: fixed flaky test (RevenueCat#2374) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: fixed iOS compilation (RevenueCat#2376) via NachoSoto (@NachoSoto) * `SubscriberAttributesManagerIntegrationTests`: fixed potential race condition (RevenueCat#2380) via NachoSoto (@NachoSoto) * `Offline Entitlements`: create `CustomerInfo` from offline entitlements (RevenueCat#2358) via NachoSoto (@NachoSoto) * Added `@DefaultDecodable.Now` (RevenueCat#2372) via NachoSoto (@NachoSoto) * `HTTPClient`: debug log when performing redirects (RevenueCat#2371) via NachoSoto (@NachoSoto) * `HTTPClient`: new flag to force server errors (RevenueCat#2370) via NachoSoto (@NachoSoto) * `OfferingsManager`: fixed Xcode 13.x build (RevenueCat#2369) via NachoSoto (@NachoSoto) * `Offline Entitlements`: store `ProductEntitlementMapping` in cache (RevenueCat#2355) via NachoSoto (@NachoSoto) * `Offline Entitlements`: added support for fetching `ProductEntitlementMappingResponse` in `OfflineEntitlementsAPI` (RevenueCat#2353) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMapping` (RevenueCat#2365) via NachoSoto (@NachoSoto) * Implemented `NetworkError.isServerDown` (RevenueCat#2367) via NachoSoto (@NachoSoto) * `ETagManager`: added test for 304 responses with no etag (RevenueCat#2360) via NachoSoto (@NachoSoto) * `TestLogHandler`: increased default capacity (RevenueCat#2357) via NachoSoto (@NachoSoto) * `OfferingsManager`: moved log to common method to remove hardcoded string (RevenueCat#2363) via NachoSoto (@NachoSoto) * `Offline Entitlements`: created `ProductEntitlementMappingResponse` (RevenueCat#2351) via NachoSoto (@NachoSoto) * `HTTPClient`: added test for 2xx response for request with etag (RevenueCat#2361) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI` improvements (RevenueCat#2345) via NachoSoto (@NachoSoto) * `ConfigureStrings`: fixed double-space typo (RevenueCat#2344) via NachoSoto (@NachoSoto) * `ETagManagerTests`: fixed tests on iOS 12 (RevenueCat#2349) via NachoSoto (@NachoSoto) * `DeviceCache`: simplified constructor (RevenueCat#2354) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: changed all APIs to `internal` (RevenueCat#2350) via NachoSoto (@NachoSoto) * `VerificationResult.notRequested`: removed caching reference (RevenueCat#2337) via NachoSoto (@NachoSoto) * Finished signature verification `HTTPClient` tests (RevenueCat#2333) via NachoSoto (@NachoSoto) * `Configuration.Builder.with(entitlementVerificationMode:)`: improved documentation (RevenueCat#2334) via NachoSoto (@NachoSoto) * `ETagManager`: don't ignore failed etags with `Signing.VerificationMode.informational` (RevenueCat#2331) via NachoSoto (@NachoSoto) * `IdentityManager`: clear `ETagManager` and `DeviceCache` if verification is enabled but cached `CustomerInfo` is not (RevenueCat#2330) via NachoSoto (@NachoSoto) * Made `Configuration.EntitlementVerificationMode.enforced` unavailable (RevenueCat#2329) via NachoSoto (@NachoSoto) * Refactor: reorganized files in new Security and Misc folders (RevenueCat#2326) via NachoSoto (@NachoSoto) * `CustomerInfo`: use same grace period logic for active subscriptions (RevenueCat#2327) via NachoSoto (@NachoSoto) * `HTTPClient`: don't verify 4xx/5xx responses (RevenueCat#2322) via NachoSoto (@NachoSoto) * `EntitlementInfo`: request date is not optional (RevenueCat#2325) via NachoSoto (@NachoSoto) * `CustomerInfo`: removed `entitlementVerification` (RevenueCat#2320) via NachoSoto (@NachoSoto) * Renamed `VerificationResult.notVerified` to `.notRequested` (RevenueCat#2321) via NachoSoto (@NachoSoto) * `EntitlementInfo`: add a grace period limit to outdated entitlements (RevenueCat#2288) via NachoSoto (@NachoSoto) * Update `CustomerInfo.requestDate` from 304 responses (RevenueCat#2310) via NachoSoto (@NachoSoto) * `Signing`: added request time & eTag to signature verification (RevenueCat#2309) via NachoSoto (@NachoSoto) * `HTTPClient`: changed header search to be case-insensitive (RevenueCat#2308) via NachoSoto (@NachoSoto) * `HTTPClient`: automatically add `nonce` based on `HTTPRequest.Path` (RevenueCat#2286) via NachoSoto (@NachoSoto) * `PurchaseTester`: added ability to reload `CustomerInfo` with a custom `CacheFetchPolicy` (RevenueCat#2312) via NachoSoto (@NachoSoto) * Fix issue where underlying error information for product fetch errors was not printed in log. (RevenueCat#2281) via Chris Vasselli (@chrisvasselli) * `PurchaseTester`: added ability to set `Configuration.EntitlementVerificationMode` (RevenueCat#2290) via NachoSoto (@NachoSoto) * SwiftUI: Paywall View should respond to changes on the UserView model (RevenueCat#2297) via ConfusedVorlon (@ConfusedVorlon) * Deprecate `usesStoreKit2IfAvailable` (RevenueCat#2293) via Andy Boedo (@aboedo) * `Signing`: updated to use production public key (RevenueCat#2274) via NachoSoto (@NachoSoto) </details> --------- Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>

NachoSoto added the refactor label Feb 9, 2023

NachoSoto requested a review from a team February 9, 2023 19:02

NachoSoto force-pushed the entitlement-verification-result branch from 256d6bb to 8a011ea Compare February 9, 2023 19:45

NachoSoto mentioned this pull request Feb 9, 2023

HTTPClient: added signature validation and introduced ErrorCode.signatureVerificationFailed #2272

Merged

NachoSoto force-pushed the nacho/signature-integration branch from 45b2ea1 to 8fcf9ca Compare February 9, 2023 19:50

NachoSoto force-pushed the entitlement-verification-result branch from 8a011ea to 8bb9818 Compare February 9, 2023 19:55

aboedo reviewed Feb 9, 2023

View reviewed changes

Comment thread Sources/Purchasing/EntitlementInfos.swift Outdated

NachoSoto force-pushed the entitlement-verification-result branch 5 times, most recently from e6595f2 to 98b4b35 Compare February 10, 2023 23:22

NachoSoto changed the title ~~[WIP] EntitlementInfo verified API~~ Introduced EntitlementValidation Feb 10, 2023

NachoSoto added pr:feat A new feature and removed refactor labels Feb 10, 2023

NachoSoto requested a review from a team February 10, 2023 23:23

NachoSoto marked this pull request as ready for review February 10, 2023 23:23

NachoSoto commented Feb 10, 2023

View reviewed changes

cadamsdotcom reviewed Feb 13, 2023

View reviewed changes

NachoSoto force-pushed the nacho/signature-integration branch from 8fcf9ca to a08492a Compare February 14, 2023 17:06

NachoSoto force-pushed the entitlement-verification-result branch from 98b4b35 to 7d7c55f Compare February 14, 2023 17:17

NachoSoto mentioned this pull request Feb 14, 2023

HTTPClient: automatically add nonce based on HTTPRequest.Path #2286

Merged

aboedo reviewed Feb 14, 2023

View reviewed changes

Comment thread Sources/Identity/CustomerInfo.swift Outdated

NachoSoto requested a review from a team February 15, 2023 17:24

tonidero approved these changes Feb 15, 2023

View reviewed changes

NachoSoto force-pushed the nacho/signature-integration branch from a08492a to 7a62e5b Compare February 15, 2023 21:50

NachoSoto force-pushed the entitlement-verification-result branch 2 times, most recently from 2008b2d to 6a533ee Compare February 15, 2023 23:26

NachoSoto changed the title ~~Introduced EntitlementValidation~~ Introduced EntitlementVerification Feb 15, 2023

Base automatically changed from nacho/signature-integration to main February 16, 2023 11:07

NachoSoto changed the base branch from main to health-request-signed February 16, 2023 11:30

NachoSoto force-pushed the entitlement-verification-result branch from 3b3606d to 172bc36 Compare February 16, 2023 11:31

Base automatically changed from health-request-signed to main February 16, 2023 17:27

NachoSoto force-pushed the entitlement-verification-result branch from 95ff1cc to 6ff5fac Compare February 16, 2023 17:27

NachoSoto enabled auto-merge (squash) February 16, 2023 17:28

NachoSoto mentioned this pull request Feb 16, 2023

Enable SSL Pinning to prevent MitM attack #1900

Closed

NachoSoto added 2 commits February 17, 2023 15:35

.informational

26ca042

NachoSoto force-pushed the entitlement-verification-result branch 4 times, most recently from 0352663 to 1821d54 Compare February 17, 2023 23:57

Fixed snapshots

8fb5f51

NachoSoto force-pushed the entitlement-verification-result branch 2 times, most recently from beeefed to 43ffb4e Compare February 18, 2023 00:23

Fixed tvOS

33170d0

NachoSoto force-pushed the entitlement-verification-result branch from 43ffb4e to 33170d0 Compare February 18, 2023 00:26

NachoSoto merged commit 84eed75 into main Feb 18, 2023

NachoSoto deleted the entitlement-verification-result branch February 18, 2023 00:49

NachoSoto added a commit that referenced this pull request Feb 21, 2023

PurchaseTester: added ability to set `Configuration.EntitlementVeri…

3a720b2

…ficationMode` Depends on #2277

NachoSoto mentioned this pull request Mar 14, 2023

Release/4.18.0-beta.1 #2335

Closed

RCGitBot mentioned this pull request May 3, 2023

[AUTOMATIC] Release/4.19.0 #2466

Closed

This was referenced May 12, 2023

Release/4.19 #2483

Closed

Release/4.19.0 #2491

Merged

Uh oh!

Conversation

NachoSoto commented Feb 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

TODO:

Uh oh!

codecov Bot commented Feb 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aboedo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NachoSoto Feb 10, 2023

Choose a reason for hiding this comment

Uh oh!

cadamsdotcom left a comment

Choose a reason for hiding this comment

Uh oh!

cadamsdotcom Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

cadamsdotcom Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

NachoSoto Feb 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NachoSoto commented Feb 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NachoSoto commented Feb 9, 2023 •

edited

Loading

codecov Bot commented Feb 9, 2023 •

edited

Loading