BundleSandboxEnvironmentDetector: always return true when running on simulator#2276
Merged
Conversation
… on simulator Thanks to @chrisvasselli for the find and initial implementation. This supersedes the workaround introduced in #1730, now making `IntegrationTests` not override the `SandboxEnvironmentDetector`.
NachoSoto
commented
Feb 9, 2023
| } | ||
| } | ||
|
|
||
| #if DEBUG |
Contributor
Author
There was a problem hiding this comment.
No longer needed. This is the main change from #2275.
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #2276 +/- ##
==========================================
+ Coverage 86.07% 86.21% +0.14%
==========================================
Files 186 186
Lines 12282 12285 +3
==========================================
+ Hits 10572 10592 +20
+ Misses 1710 1693 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonidero
approved these changes
Feb 10, 2023
Contributor
|
Ah will need to fix the usages of that function as well @NachoSoto |
24ed9db to
c75ab7a
Compare
NachoSoto
pushed a commit
that referenced
this pull request
Feb 15, 2023
**This is an automatic release.** ### Bugfixes * `PurchaseOrchestrator`: always refresh receipt purchasing in sandbox (#2280) via NachoSoto (@NachoSoto) * `BundleSandboxEnvironmentDetector`: always return `true` when running on simulator (#2276) via NachoSoto (@NachoSoto) * `OfferingsManager`: ensure underlying `OfferingsManager.Error.configurationError` is logged (#2266) via NachoSoto (@NachoSoto) ### Other Changes * `UserDefaultsDefaultTests`: fixed flaky failures (#2284) via NachoSoto (@NachoSoto) * `BaseBackendTest`: improved test failure message (#2285) via NachoSoto (@NachoSoto) * Updated targets and schemes for Xcode 14.2 (#2282) via NachoSoto (@NachoSoto) * `HTTPRequest.Path.health`: don't cache using `ETagManager` (#2278) via NachoSoto (@NachoSoto) * `EntitlementInfos.all`: fixed docstring (#2279) via NachoSoto (@NachoSoto) * `StoreKit2StorefrontListener`: added tests to fix flaky code coverage (#2265) via NachoSoto (@NachoSoto) * `NetworkError`: added underlying error to description (#2263) via NachoSoto (@NachoSoto) * Created `Signing.verify(message:hasValidSignature:with:)` (#2216) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @chrisvasselli for the find and initial implementation (#2275).
This supersedes the workaround introduced in #1730, now making
IntegrationTestsnot override theSandboxEnvironmentDetector.