Skip to content

NetworkError: added underlying error to description#2263

Merged
NachoSoto merged 2 commits into
mainfrom
network-error-underlying-error
Feb 8, 2023
Merged

NetworkError: added underlying error to description#2263
NachoSoto merged 2 commits into
mainfrom
network-error-underlying-error

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

Before:

[Purchases] - ERROR: 😿‼️ Error performing request.

After:

[Purchases] - ERROR: 😿‼️ Error performing request. The operation couldn’t be completed. (NSURLErrorDomain error -1.)

> [Purchases] - ERROR: 😿‼️ Error performing request.

After:
> [Purchases] - ERROR: 😿‼️ Error performing request. The operation couldn’t be completed. (NSURLErrorDomain error -1.)
@NachoSoto NachoSoto requested a review from a team February 3, 2023 20:44
@NachoSoto

Copy link
Copy Markdown
Contributor Author

This helped me figure out #2262.

@codecov

codecov Bot commented Feb 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2263 (f3777e7) into main (ec69c2d) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
- Coverage   85.96%   85.88%   -0.09%     
==========================================
  Files         183      183              
  Lines       12119    12119              
==========================================
- Hits        10418    10408      -10     
- Misses       1701     1711      +10     
Impacted Files Coverage Δ
Sources/Error Handling/ErrorUtils.swift 85.42% <100.00%> (ø)
Sources/Networking/HTTPClient/HTTPClient.swift 93.88% <0.00%> (-4.32%) ⬇️
Sources/Logging/Strings/NetworkStrings.swift 98.36% <0.00%> (-1.64%) ⬇️
...hasing/StoreKit2/StoreKit2StorefrontListener.swift 100.00% <0.00%> (+13.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NachoSoto NachoSoto merged commit 7c268db into main Feb 8, 2023
@NachoSoto NachoSoto deleted the network-error-underlying-error branch February 8, 2023 18:38
NachoSoto pushed a commit that referenced this pull request Feb 15, 2023
**This is an automatic release.**

### Bugfixes
* `PurchaseOrchestrator`: always refresh receipt purchasing in sandbox
(#2280) via NachoSoto (@NachoSoto)
* `BundleSandboxEnvironmentDetector`: always return `true` when running
on simulator (#2276) via NachoSoto (@NachoSoto)
* `OfferingsManager`: ensure underlying
`OfferingsManager.Error.configurationError` is logged (#2266) via
NachoSoto (@NachoSoto)
### Other Changes
* `UserDefaultsDefaultTests`: fixed flaky failures (#2284) via NachoSoto
(@NachoSoto)
* `BaseBackendTest`: improved test failure message (#2285) via NachoSoto
(@NachoSoto)
* Updated targets and schemes for Xcode 14.2 (#2282) via NachoSoto
(@NachoSoto)
* `HTTPRequest.Path.health`: don't cache using `ETagManager` (#2278) via
NachoSoto (@NachoSoto)
* `EntitlementInfos.all`: fixed docstring (#2279) via NachoSoto
(@NachoSoto)
* `StoreKit2StorefrontListener`: added tests to fix flaky code coverage
(#2265) via NachoSoto (@NachoSoto)
* `NetworkError`: added underlying error to description (#2263) via
NachoSoto (@NachoSoto)
* Created `Signing.verify(message:hasValidSignature:with:)` (#2216) via
NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants