StoreKit2StorefrontListener: added tests to fix flaky code coverage#2265
Merged
Conversation
dd1d8f4 to
0464b98
Compare
Codecov Report
@@ Coverage Diff @@
## main #2265 +/- ##
==========================================
+ Coverage 86.07% 86.17% +0.10%
==========================================
Files 186 186
Lines 12269 12282 +13
==========================================
+ Hits 10560 10584 +24
+ Misses 1709 1698 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aboedo
reviewed
Feb 8, 2023
| ) | ||
| } | ||
|
|
||
| init<S: AsyncSequence>( |
Member
There was a problem hiding this comment.
let's add a description and sample usage here, this init won't be intuitive to folks not very used to Swift
Contributor
Author
There was a problem hiding this comment.
I added a comment explaining this.
Similarly to #2262, test execution ordering was leading to [flaky code coverage results](https://app.codecov.io/gh/RevenueCat/purchases-ios/pull/2262) with this. Because we didn't have any test coverage, only if some other test changed the `Storefront`, this test was calling the delegate code. This adds explicit test coverage using a `MockAsyncSequence`. - Added `StorefrontType` to `StoreKit2StorefrontListenerDelegate` method - `Storefront` initializers are no longer `Optional` `init?` - Simplified `StoreKit2StorefrontListenerTests` by moving `AvailabilityChecks` to `setUp`
d1ff43b to
21e2d71
Compare
aboedo
approved these changes
Feb 8, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Feb 15, 2023
**This is an automatic release.** ### Bugfixes * `PurchaseOrchestrator`: always refresh receipt purchasing in sandbox (#2280) via NachoSoto (@NachoSoto) * `BundleSandboxEnvironmentDetector`: always return `true` when running on simulator (#2276) via NachoSoto (@NachoSoto) * `OfferingsManager`: ensure underlying `OfferingsManager.Error.configurationError` is logged (#2266) via NachoSoto (@NachoSoto) ### Other Changes * `UserDefaultsDefaultTests`: fixed flaky failures (#2284) via NachoSoto (@NachoSoto) * `BaseBackendTest`: improved test failure message (#2285) via NachoSoto (@NachoSoto) * Updated targets and schemes for Xcode 14.2 (#2282) via NachoSoto (@NachoSoto) * `HTTPRequest.Path.health`: don't cache using `ETagManager` (#2278) via NachoSoto (@NachoSoto) * `EntitlementInfos.all`: fixed docstring (#2279) via NachoSoto (@NachoSoto) * `StoreKit2StorefrontListener`: added tests to fix flaky code coverage (#2265) via NachoSoto (@NachoSoto) * `NetworkError`: added underlying error to description (#2263) via NachoSoto (@NachoSoto) * Created `Signing.verify(message:hasValidSignature:with:)` (#2216) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #2262, test execution ordering was leading to flaky code coverage results with this.
Because we didn't have any test coverage, only if some other test changed the
Storefront, this test was calling the delegate code.This adds explicit test coverage using a
MockAsyncSequence.Other changes:
StorefrontTypetoStoreKit2StorefrontListenerDelegatemethodStorefrontinitializers are no longerOptionalinit?StoreKit2StorefrontListenerTestsby movingAvailabilityCheckstosetUp