SPM: added APPLICATION_EXTENSION_API_ONLY flag to RevenueCat and ReceiptParser#2217
Merged
Conversation
ReceiptParser: added APPLICATION_EXTENSION_API_ONLY flagSPM: added APPLICATION_EXTENSION_API_ONLY flag to RevenueCat and ReceiptParser
Contributor
Author
|
Modified this to set it to |
aboedo
approved these changes
Jan 17, 2023
aboedo
approved these changes
Jan 17, 2023
d44b846 to
176ae73
Compare
This allows users to embed this package in non-app targets. Unfortunately setting the flag directly is the only way to do this at the moment.
02e8ef3 to
5cbdcd5
Compare
NachoSoto
added a commit
that referenced
this pull request
Jan 18, 2023
…eCat` and `ReceiptParser` (#2217)" This reverts commit 02c2bce. Unfortunately this breaks SPM integration under some conditions (see #2223): > error: The package product 'RevenueCat' cannot be used as a dependency of this target because it uses unsafe build flags. (in target 'PurchaseTester' from project 'PurchaseTester') I haven't been able to reproduce this locally, but better to remove this for now until `SPM` adds a way to set this flag without using unsafe flags.
NachoSoto
pushed a commit
that referenced
this pull request
Jan 18, 2023
**This is an automatic release.** ### Other Changes * set flag to extract objc info for swift symbols (#2218) via Andy Boedo (@aboedo) * Produce a compilation error when using an old `Xcode` version (#2222) via NachoSoto (@NachoSoto) * `SPM`: added `APPLICATION_EXTENSION_API_ONLY` flag to `RevenueCat` and `ReceiptParser` (#2217) via NachoSoto (@NachoSoto) * `PurchaseTester`: added section to visualize `AppleReceipt` (#2211) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
that referenced
this pull request
Jan 18, 2023
…eCat` and `ReceiptParser` (#2217)" (#2225) This reverts commit 02c2bce. Unfortunately this breaks SPM integration under some conditions (see #2223): > error: The package product 'RevenueCat' cannot be used as a dependency of this target because it uses unsafe build flags. (in target 'PurchaseTester' from project 'PurchaseTester') I haven't been able to reproduce this locally, but better to remove this for now until `SPM` adds a way to set this flag without using unsafe flags.
NachoSoto
pushed a commit
that referenced
this pull request
Jan 19, 2023
**This is an automatic release.** ### Bugfixes * `Purchases`: avoid potential crash when initializing in the background (#2231) via NachoSoto (@NachoSoto) ### Other Changes * `PurchaseTester`: ignore errors when restoring purchases (#2228) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed `isPurchasing` state when purchasing fails (#2229) via NachoSoto (@NachoSoto) * `PurchaseTester`: setting `changelog` when submitting to `TestFlight` (#2232) via NachoSoto (@NachoSoto) * Revert "`SPM`: added `APPLICATION_EXTENSION_API_ONLY` flag to `RevenueCat` and `ReceiptParser` (#2217)" (#2225) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag is already set in
Xcode's target, so setting it here matches it when embedding the frameworks throughSPM.This allows users to embed these package in non-app targets.
Unfortunately setting the flag directly is the only way to do this at the moment.