Produce a compilation error when using an old Xcode version#2222
Merged
Conversation
This will make it easier to figure out that the version is no longer compatible. Aditionally, I've added `UpdatingRequirements.md` so we have a single place to reference when changing these requirements.
Xcode version
NachoSoto
commented
Jan 18, 2023
|
|
||
| If these requirements change, there are several places that need to be updated: | ||
| - `README.md` | ||
| - https://www.revenuecat.com/docs/getting-started |
aboedo
approved these changes
Jan 18, 2023
Comment on lines
+16
to
+19
| #if swift(<5.5.2) | ||
| // See https://xcodereleases.com | ||
| #error("RevenueCat requires Xcode 13.2 with Swift 5.5.2 to compile.") | ||
| #endif |
NachoSoto
pushed a commit
that referenced
this pull request
Jan 18, 2023
**This is an automatic release.** ### Other Changes * set flag to extract objc info for swift symbols (#2218) via Andy Boedo (@aboedo) * Produce a compilation error when using an old `Xcode` version (#2222) via NachoSoto (@NachoSoto) * `SPM`: added `APPLICATION_EXTENSION_API_ONLY` flag to `RevenueCat` and `ReceiptParser` (#2217) via NachoSoto (@NachoSoto) * `PurchaseTester`: added section to visualize `AppleReceipt` (#2211) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make it easier to figure out that the version is no longer compatible.
Aditionally, I've added
UpdatingRequirements.mdso we have a single place to reference when changing these requirements.