Purchases: avoid potential crash when initializing in the background#2231
Merged
Conversation
5 tasks
#2224 likely fixes #1877. This change also avoids running the code being triggered in that crashing stack trace, since it's not necessary. `Purchases.delegate` setter already calls `sendCachedCustomerInfoToDelegateIfExists`, so that method was unnecessary. Removing this call to `sendCachedCustomerInfoIfAvailable` doesn't make any test fails because of that. This behavior is also verified by `PurchasesConfiguringTests`: `testFirstInitializationFromBackgroundCallsDelegateForAnonIfInfoCached` and `testSettingTheDelegateAfterInitializationSendsCachedCustomerInfo`. I also improved this by extracting it into its own method and adding an explanation for the `isApplicationBackgrounded` check.
2811150 to
fdfd257
Compare
aboedo
approved these changes
Jan 18, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Jan 19, 2023
**This is an automatic release.** ### Bugfixes * `Purchases`: avoid potential crash when initializing in the background (#2231) via NachoSoto (@NachoSoto) ### Other Changes * `PurchaseTester`: ignore errors when restoring purchases (#2228) via NachoSoto (@NachoSoto) * `PurchaseTester`: fixed `isPurchasing` state when purchasing fails (#2229) via NachoSoto (@NachoSoto) * `PurchaseTester`: setting `changelog` when submitting to `TestFlight` (#2232) via NachoSoto (@NachoSoto) * Revert "`SPM`: added `APPLICATION_EXTENSION_API_ONLY` flag to `RevenueCat` and `ReceiptParser` (#2217)" (#2225) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2224 likely fixes #1877. This change also avoids running the code being triggered in that crashing stack trace, since it's not necessary.
Purchases.delegatesetter already callssendCachedCustomerInfoToDelegateIfExists, so that method was unnecessary. Removing this call tosendCachedCustomerInfoIfAvailabledoesn't make any test fails because of that.This behavior is also verified by
PurchasesConfiguringTests:testFirstInitializationFromBackgroundCallsDelegateForAnonIfInfoCachedandtestSettingTheDelegateAfterInitializationSendsCachedCustomerInfo.I also improved this by extracting it into its own method and adding an explanation for the
isApplicationBackgroundedcheck.