HTTPClient: added log for failed requests#2048
Merged
Merged
Conversation
NachoSoto
commented
Nov 11, 2022
Contributor
Author
There was a problem hiding this comment.
debug only so we don't end up logging this error twice.
I'm looking into [CSDK-517], and it's hard to tell why we ended up with concurrent requests. It appears that a second request begins before the last one started. That's seemingly impossible, and the only explanation for the logs missing "request completed" is that the first request failed. This extra log will help us understand what's happening.
a220e44 to
544bc4c
Compare
vegaro
approved these changes
Nov 14, 2022
NachoSoto
pushed a commit
that referenced
this pull request
Nov 18, 2022
**This is an automatic release.** ### Bugfixes * `StoreKit 2`: don't finish transactions in observer mode (#2053) via NachoSoto (@NachoSoto) ### Other Changes * `CircleCI`: added ability to create a release manually (#2067) via NachoSoto (@NachoSoto) * Changelog: Fix links to V4 API Migration guide (#2051) via Kevin Quisquater (@KevinQuisquater) * `HTTPClient`: added log for failed requests (#2048) via NachoSoto (@NachoSoto) * `ErrorResponse.asBackendError`: serialize attribute errors as `NSDictionary` (#2034) via NachoSoto (@NachoSoto) * `ErrorCode.unknownBackendError`: include original error code (#2032) via NachoSoto (@NachoSoto) * `CI`: fixed `push-pods` job (#2045) via NachoSoto (@NachoSoto) * `PostReceiptDataOperation`: log Apple error when purchase equals expiration date (#2038) via NachoSoto (@NachoSoto) * Update Fastlane plugin (#2041) via Cesar de la Vega (@vegaro)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking into CSDK-517, and it's hard to tell why we ended up with concurrent requests. It appears that a second request begins before the last one started.
That's seemingly impossible, and the only explanation for the logs missing "request completed" is that the first request failed.
This extra log will help us understand what's happening.