Skip to content

ErrorResponse.asBackendError: serialize attribute errors as NSDictionary#2034

Merged
NachoSoto merged 1 commit into
mainfrom
user-info-dictionary
Nov 11, 2022
Merged

ErrorResponse.asBackendError: serialize attribute errors as NSDictionary#2034
NachoSoto merged 1 commit into
mainfrom
user-info-dictionary

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

I noticed this error in an integration test failure:

BackendIntegrationTestsHostApp[3972:15171] Exception attempting to serialize sanitized error of issue. All userInfo with be discarded except localized description: NSInvalidUnarchiveOperationException: The data couldn’t be read because it isn’t in the correct format.

This was the only instance I could see that might potentially fail to serialize (it's [String: String].
This should be a safe conversion anyway, so it's worth trying.

@NachoSoto NachoSoto added the test label Nov 7, 2022
@NachoSoto NachoSoto requested a review from a team November 7, 2022 22:14
…ionary`

I noticed this error in an integration test failure:
> BackendIntegrationTestsHostApp[3972:15171] Exception attempting to serialize sanitized error of issue. All userInfo with be discarded except localized description: NSInvalidUnarchiveOperationException: The data couldn’t be read because it isn’t in the correct format.

This was the only instance I could see that might potentially fail to serialize (it's `[String: String]`.
This should be a safe conversion anyway, so it's worth trying.
@NachoSoto NachoSoto force-pushed the user-info-dictionary branch from be5757b to 72124c2 Compare November 9, 2022 14:40
@NachoSoto NachoSoto merged commit 66fee52 into main Nov 11, 2022
@NachoSoto NachoSoto deleted the user-info-dictionary branch November 11, 2022 16:05
NachoSoto pushed a commit that referenced this pull request Nov 18, 2022
**This is an automatic release.**

### Bugfixes
* `StoreKit 2`: don't finish transactions in observer mode (#2053) via
NachoSoto (@NachoSoto)
### Other Changes
* `CircleCI`: added ability to create a release manually (#2067) via
NachoSoto (@NachoSoto)
* Changelog: Fix links to V4 API Migration guide (#2051) via Kevin
Quisquater (@KevinQuisquater)
* `HTTPClient`: added log for failed requests (#2048) via NachoSoto
(@NachoSoto)
* `ErrorResponse.asBackendError`: serialize attribute errors as
`NSDictionary` (#2034) via NachoSoto (@NachoSoto)
* `ErrorCode.unknownBackendError`: include original error code (#2032)
via NachoSoto (@NachoSoto)
* `CI`: fixed `push-pods` job (#2045) via NachoSoto (@NachoSoto)
* `PostReceiptDataOperation`: log Apple error when purchase equals
expiration date (#2038) via NachoSoto (@NachoSoto)
* Update Fastlane plugin (#2041) via Cesar de la Vega (@vegaro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants