PostReceiptDataOperation: log Apple error when purchase equals expiration date#2038
Merged
Conversation
ca77557 to
378f9d0
Compare
Contributor
Author
|
Hmm wait this didn't work? |
Contributor
Author
|
Oh it's because there's no |
aboedo
reviewed
Nov 8, 2022
Contributor
Author
|
Removed |
378f9d0 to
40554f4
Compare
NachoSoto
added a commit
that referenced
this pull request
Nov 9, 2022
…around 0-second subscriptions As exposed by #2038, weekly subscriptions were leading to false negatives because they were always expired by the time the purchase was made using `TimeRate.monthlyRenewalEveryThirtySeconds`, instead of lasting 10 seconds as documented. (`FB11767559`) The advantage of using weekly subscriptions was to also work around `FB11767679`, which means that we have to manually _wait_ for the subscription to expire, as `SKTestSession.expireSubscription(productIdentifier:)` doesn't actually change the receipt. Because we had to wait, using weekly subscriptions was faster, since we only needed to wait 10 seconds. This does mean that expirations in these tests now have to wait 30 seconds instead of 10, but now they're no longer flaky 🎉
NachoSoto
added a commit
that referenced
this pull request
Nov 9, 2022
…around 0-second subscriptions As exposed by #2038, weekly subscriptions were leading to false negatives because they were always expired by the time the purchase was made using `TimeRate.monthlyRenewalEveryThirtySeconds`, instead of lasting 10 seconds as documented. (`FB11767559`) The advantage of using weekly subscriptions was to also work around `FB11767679`, which means that we have to manually _wait_ for the subscription to expire, as `SKTestSession.expireSubscription(productIdentifier:)` doesn't actually change the receipt. Because we had to wait, using weekly subscriptions was faster, since we only needed to wait 10 seconds. This does mean that expirations in these tests now have to wait 30 seconds instead of 10, but now they're no longer flaky 🎉
NachoSoto
added a commit
that referenced
this pull request
Nov 9, 2022
…around 0-second subscriptions (#2042) As exposed by #2038, weekly subscriptions were leading to false negatives because they were always expired by the time the purchase was made (using `TimeRate.monthlyRenewalEveryThirtySeconds`), instead of lasting 10 seconds as documented. This is reported as `FB11767559`. The advantage of using weekly subscriptions was to also work around `FB11767679`, which means that we have to manually _wait_ for the subscription to expire, as `SKTestSession.expireSubscription(productIdentifier:)` doesn't actually change the receipt. Because we had to wait, using weekly subscriptions was faster, since we only needed to wait 10 seconds. This does mean that expirations in these tests now have to wait 30 seconds instead of 10, but now they're no longer flaky 🎉 Looks like tests right now pass in CI in less than 7 minutes, which I believe is totally acceptable, especially for the benefit of no longer having these flaky tests.
…ration date A large amount of flaky integration tests are due to this bug, so detecting it early in the logs will help debug this. Radar: `FB11767559`.
40554f4 to
d84768c
Compare
d84768c to
8cdf8fb
Compare
aboedo
approved these changes
Nov 9, 2022
NachoSoto
pushed a commit
that referenced
this pull request
Nov 18, 2022
**This is an automatic release.** ### Bugfixes * `StoreKit 2`: don't finish transactions in observer mode (#2053) via NachoSoto (@NachoSoto) ### Other Changes * `CircleCI`: added ability to create a release manually (#2067) via NachoSoto (@NachoSoto) * Changelog: Fix links to V4 API Migration guide (#2051) via Kevin Quisquater (@KevinQuisquater) * `HTTPClient`: added log for failed requests (#2048) via NachoSoto (@NachoSoto) * `ErrorResponse.asBackendError`: serialize attribute errors as `NSDictionary` (#2034) via NachoSoto (@NachoSoto) * `ErrorCode.unknownBackendError`: include original error code (#2032) via NachoSoto (@NachoSoto) * `CI`: fixed `push-pods` job (#2045) via NachoSoto (@NachoSoto) * `PostReceiptDataOperation`: log Apple error when purchase equals expiration date (#2038) via NachoSoto (@NachoSoto) * Update Fastlane plugin (#2041) via Cesar de la Vega (@vegaro)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large amount of flaky integration tests are due to this bug, so detecting it early in the logs will help debug this.
Radar:
FB11767559.productTypeis missing inStoreKitTestpurchases, so I changedisSubscriptionto default to checking if there is an expiration when the type is.unknown.To simplify the code, I changed
ProductType?to be non-optional, since we already have.unknownas a case.Example: