Skip to content

Makes hold job wait for installation tests to pass#2017

Merged
vegaro merged 1 commit into
mainfrom
fix-deploy-workflow
Nov 1, 2022
Merged

Makes hold job wait for installation tests to pass#2017
vegaro merged 1 commit into
mainfrom
fix-deploy-workflow

Conversation

@vegaro

@vegaro vegaro commented Nov 1, 2022

Copy link
Copy Markdown
Member

Equivalent of https://github.com/RevenueCat/purchases-android/pull/644/files

Fixes two things:

  • Makes sure installation tests pass before deploying anything
  • Prevents installation tests from running also when the branch is tagged (after the hold job is approved), which was unnecessary and caused unnecessary waiting time

@vegaro vegaro changed the title fix deploy workflow Makes hold job wait for installation tests to pass Nov 1, 2022
@vegaro vegaro added the ci label Nov 1, 2022
@vegaro vegaro requested a review from a team November 1, 2022 17:28
@vegaro vegaro merged commit 2b745c2 into main Nov 1, 2022
@vegaro vegaro deleted the fix-deploy-workflow branch November 1, 2022 18:13

@NachoSoto NachoSoto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@RCGitBot RCGitBot mentioned this pull request Nov 3, 2022
NachoSoto pushed a commit that referenced this pull request Nov 4, 2022
### New Features
* Introduced `PurchasesDiagnostics` to help diagnose SDK configuration
errors (#1977) via NachoSoto (@NachoSoto)
### Bugfixes
* Avoid posting empty receipts by making`TransactionsManager` always use
`SK1` implementation (#2015) via NachoSoto (@NachoSoto)
* `NetworkOperation`: workaround for iOS 12 crashes (#2008) via
NachoSoto (@NachoSoto)
### Other Changes
* Makes hold job wait for installation tests to pass (#2017) via Cesar
de la Vega (@vegaro)
* Update fastlane-plugin-revenuecat_internal (#2016) via Cesar de la
Vega (@vegaro)
* `bug_report.md`: changed SK2 wording (#2010) via NachoSoto
(@NachoSoto)
* Added `Set + Set` and `Set += Set` operators (#2013) via NachoSoto
(@NachoSoto)
* fix the link to StoreKit Config file from watchOS purchaseTester
(#2009) via Andy Boedo (@aboedo)
* `PurchaseTesterSwiftUI`: combined targets into one multi-platform and
fixed `macOS` (#1996) via NachoSoto (@NachoSoto)
* Less Array() (#2005) via SabinaHuseinova (@SabinaHuseinova)
* Docs: fixed `logIn` references (#2002) via NachoSoto (@NachoSoto)
* CI: use `Xcode 14.1` (#1992) via NachoSoto (@NachoSoto)
* `PurchaseTesterSwiftUI`: fixed warnings and simplified code using
`async` methods (#1985) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants