Skip to content

Moves hold job after integration tests #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vegaro merged 2 commits into from
Oct 25, 2022
Merged

Moves hold job after integration tests #644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c40f635
moves hold job after integration tests
vegaro Oct 14, 2022
02ba314
Merge branch 'main' into fix-deploy-workflow
vegaro Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
aliases:
release-tags-and-branches: &release-tags-and-branches
filters:
tags:
ignore:
- /^.*-SNAPSHOT/
- latest
branches:
only: /^release\/.*/

release-tags: &release-tags
filters:
tags:
Expand Down Expand Up @@ -370,26 +361,23 @@ workflows:
- test
- assemble-sample-app

integration-test:
deploy:
when:
not:
equal: [ scheduled_pipeline, << pipeline.trigger_source >> ]
jobs:
- integration-tests-build: *release-tags-and-branches
- integration-tests-build: *release-branches

@vegaro vegaro Oct 14, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release-tags-and-branches was running this twice, on the PR and on the tag created by revenuecat/tag-current-branch, but both results should be the same, so I just changed it to run on the branch and removed the filter

- run-firebase-tests-latest-dependencies:
requires:
- integration-tests-build
- run-firebase-tests-unityIAP:
requires:
- integration-tests-build

deploy:
when:
not:
equal: [ scheduled_pipeline, << pipeline.trigger_source >> ]
jobs:
- hold:
type: approval
requires:
- run-firebase-tests-latest-dependencies
- run-firebase-tests-unityIAP
<<: *release-branches
- revenuecat/tag-current-branch:
requires:
Expand Down