Avoid posting empty receipts by makingTransactionsManager always use SK1 implementation#2015
Merged
Conversation
TransactionsManager: always use SK1 implementationTransactionsManager always use SK1 implementation
aboedo
approved these changes
Oct 31, 2022
aboedo
left a comment
Member
There was a problem hiding this comment.
One small note, ready to go otherwise
Fixes [CSDK-513]. The SDK still uses `SK1` when it comes to fetching receipts to post to the backend. The `SK1` implementation checks whether there are transactions inside of the receipt. However, this could lead to issues if `SK2` has transactions but SK1 doesn't. In those cases, we would end up posting an empty receipt. This fixes that.
bfc285c to
05e8910
Compare
Merged
NachoSoto
pushed a commit
that referenced
this pull request
Nov 4, 2022
### New Features * Introduced `PurchasesDiagnostics` to help diagnose SDK configuration errors (#1977) via NachoSoto (@NachoSoto) ### Bugfixes * Avoid posting empty receipts by making`TransactionsManager` always use `SK1` implementation (#2015) via NachoSoto (@NachoSoto) * `NetworkOperation`: workaround for iOS 12 crashes (#2008) via NachoSoto (@NachoSoto) ### Other Changes * Makes hold job wait for installation tests to pass (#2017) via Cesar de la Vega (@vegaro) * Update fastlane-plugin-revenuecat_internal (#2016) via Cesar de la Vega (@vegaro) * `bug_report.md`: changed SK2 wording (#2010) via NachoSoto (@NachoSoto) * Added `Set + Set` and `Set += Set` operators (#2013) via NachoSoto (@NachoSoto) * fix the link to StoreKit Config file from watchOS purchaseTester (#2009) via Andy Boedo (@aboedo) * `PurchaseTesterSwiftUI`: combined targets into one multi-platform and fixed `macOS` (#1996) via NachoSoto (@NachoSoto) * Less Array() (#2005) via SabinaHuseinova (@SabinaHuseinova) * Docs: fixed `logIn` references (#2002) via NachoSoto (@NachoSoto) * CI: use `Xcode 14.1` (#1992) via NachoSoto (@NachoSoto) * `PurchaseTesterSwiftUI`: fixed warnings and simplified code using `async` methods (#1985) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CSDK-513.
The SDK still uses
SK1when it comes to fetching receipts to post to the backend.The
SK1implementation checks whether there are transactions inside of the receipt.However, this could lead to issues if
SK2has transactions but SK1 doesn't. In those cases, we would end up posting an empty receipt. This PR fixes that.