Fixed snapshots for iOS 12 and 13#1783
Merged
Merged
Conversation
Merged
taquitos
approved these changes
Jul 29, 2022
| }, | ||
| "method" : "POST", | ||
| "url" : "https://api.revenuecat.com/v1/receipts" | ||
| "url" : "https:\/api.revenuecat.com\/v1\/receipts" |
Contributor
Author
There was a problem hiding this comment.
It's not weird: #1560
We have better formatting for iOS 13+, but that's not available on iOS 12.
NachoSoto
added a commit
that referenced
this pull request
Jul 29, 2022
Follow up to #1783. I couldn't run iOS 12 tests locally (not working with Xcode 14), so I couldn't verify that this was wrong. Downloading the full `.xcresult` from https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7546/workflows/b47843e1-bf9a-40f3-9992-220581772f00/jobs/32130/artifacts (thanks to #1773) helped me see what was wrong.
Merged
NachoSoto
added a commit
that referenced
this pull request
Jul 29, 2022
Follow up to #1783. I couldn't run iOS 12 tests locally (not working with Xcode 14), so I couldn't verify that this was wrong. Downloading the full `.xcresult` from https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7546/workflows/b47843e1-bf9a-40f3-9992-220581772f00/jobs/32130/artifacts (thanks to #1773) helped me see what was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7535/workflows/3c2dc5ac-372c-4861-9bb0-506ce01eabd7/jobs/32015
These were wrong in #1778.