Skip to content

Fixed iOS 12 snapshot#1785

Merged
NachoSoto merged 1 commit into
mainfrom
ios12-13-fixes-2
Jul 29, 2022
Merged

Fixed iOS 12 snapshot#1785
NachoSoto merged 1 commit into
mainfrom
ios12-13-fixes-2

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

Follow up to #1783. I couldn't run iOS 12 tests locally (not working with Xcode 14), so I couldn't verify that this was wrong.
Downloading the full .xcresult from https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7546/workflows/b47843e1-bf9a-40f3-9992-220581772f00/jobs/32130/artifacts (thanks to #1773) helped me see what was wrong.

Follow up to #1783. I couldn't run iOS 12 tests locally (not working with Xcode 14), so I couldn't verify that this was wrong.
Downloading the full `.xcresult` from https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7546/workflows/b47843e1-bf9a-40f3-9992-220581772f00/jobs/32130/artifacts (thanks to #1773) helped me see what was wrong.
@NachoSoto NachoSoto requested a review from taquitos July 29, 2022 21:26

@taquitos taquitos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐🔥
download-85

@NachoSoto NachoSoto merged commit cac949a into main Jul 29, 2022
@NachoSoto NachoSoto deleted the ios12-13-fixes-2 branch July 29, 2022 23:29
This was referenced Aug 1, 2022
@revenuecat-circleci-ios-certs

Copy link
Copy Markdown
Collaborator

👀 [TST-24] We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@aboedo

aboedo commented Sep 21, 2022

Copy link
Copy Markdown
Member

this is me excelling at breaking things, FFTI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants